PATCH: dpt_i2o memory leak comments
A message that is not in the archive (sent off-list or not yet received): [email protected]
| @@ -1318,7 +1318,9 @@
| while(*status == 0){
| if(time_after(jiffies,timeout)){
| printk(KERN_WARNING"%s: IOP Reset Timeout\n",pHba->name);
| - kfree(status);
| + /* We loose 4 bytes of "status" here, but we cannot
| + free these because controller may awake and corrupt
| + those bytes at any time */s/loose/lose/
| @@ -1336,6 +1338,9 @@
| }
| if(time_after(jiffies,timeout)){
| printk(KERN_ERR "%s:Timeout waiting for IOP Reset.\n",pHba->name);
| + /* We loose 4 bytes of "status" here, but we cannot
| + free these because controller may awake and corrupt
| + those bytes at any time */s/loose/lose/
or is this a Brit vs. Amer difference? (not that I know of)
--
~Randy
Quoted 17 lines · Randy.Dunlap
| @@ -1318,7 +1318,9 @@ | while(*status == 0){ | if(time_after(jiffies,timeout)){ | printk(KERN_WARNING"%s: IOP Reset Timeout\n",pHba->name); | - kfree(status); | + /* We loose 4 bytes of "status" here, but we cannot | + free these because controller may awake and corrupt | + those bytes at any time */s/loose/lose/
| @@ -1336,6 +1338,9 @@ | } | if(time_after(jiffies,timeout)){ | printk(KERN_ERR "%s:Timeout waiting for IOP Reset.\n",pHba->name); | + /* We loose 4 bytes of "status" here, but we cannot | + free these because controller may awake and corrupt | + those bytes at any time */
Quoted 7 lines
s/loose/lose/
or is this a Brit vs. Amer difference? (not that I know of)
--
~Randy
-
Loose means that something is rattling around, not connected, or not tied down. Lose is what happens on the Crap Tables (as above).
Cheers,
Dick Johnson
Penguin : Linux version 2.4.20 on an i686 machine (797.90 BogoMips). Why is the government concerned about the lunatic fringe? Think about it.
Quoted 2 lines · Richard B. Johnson
Loose means that something is rattling around, not connected, or not tied down. Lose is what happens on the Crap Tables (as above).
Is it clearer to say: Loose is a state, lose is a verb?
Regards,
Nigel
Signature · 6 lines
Nigel Cunningham 495 St Georges Road South, Hastings 4201, New Zealand Be diligent to present yourself approved to God as a workman who does not need to be ashamed, handling accurately the word of truth. -- 2 Timothy 2:14, NASB.
Quoted 5 lines · Nigel Cunningham
Quoted 2 lines · Richard B. Johnson
Loose means that something is rattling around, not connected, or not tied down. Lose is what happens on the Crap Tables (as above).
Is it clearer to say: Loose is a state, lose is a verb?
No, because loose is also a verb meaning to make loose or remove restraints. English is such a fun language.
To lose something implies the loss is unintended, either real or pretense. Unless the loss is unintentional you really shouldn't be using the word "lose". If it is unintentional it should probably be past tense (lost).
At this point I cannot be sure of the context here but what is probably meant would be clearer if we used the word "discard".
Signature · 5 lines
________________________________________________________________ J.W. Schultz Pegasystems Technologies email address: [email protected] Remember Cernan and Schmitt
Quoted 2 lines · jw schultz
No, because loose is also a verb meaning to make loose or remove restraints. English is such a fun language.
To make loose is "loosen", to set free can be "loose", although from "let loose" I suspect.
Quoted 4 lines
To lose something implies the loss is unintended, either real or pretense. Unless the loss is unintentional you really shouldn't be using the word "lose". If it is unintentional it should probably be past tense (lost).
Umm ? "The annoyed team members set out to lose"
You can intentionally lose something. The difference is whether you expect to be able to retrieve it.
Quoted 11 lines · Randy.Dunlap
| @@ -1318,7 +1318,9 @@ | while(*status == 0){ | if(time_after(jiffies,timeout)){ | printk(KERN_WARNING"%s: IOP Reset Timeout\n",pHba->name); | - kfree(status); | + /* We loose 4 bytes of "status" here, but we cannot | + free these because controller may awake and corrupt | + those bytes at any time */s/loose/lose/
Quoted 8 lines
| @@ -1336,6 +1338,9 @@ | } | if(time_after(jiffies,timeout)){ | printk(KERN_ERR "%s:Timeout waiting for IOP Reset.\n",pHba->name); | + /* We loose 4 bytes of "status" here, but we cannot | + free these because controller may awake and corrupt | + those bytes at any time */s/loose/lose/
It might also be nice to point out, that we lose the 4 bytes once per *boot*, not continuously. Some people like me have a much easier time to accept the loss then. :)
Jörn
Signature · 2 lines
It's just what we asked for, but not what we want! -- anonymous
Quoted 3 lines · Randy.Dunlap
s/loose/lose/
or is this a Brit vs. Amer difference? (not that I know of)
Your corrections are right