Skip to contentSkip to conversation

phy: exynos: fix building as a module

PATCH In review Arnd Bergmann 2 participants 2 messages Mar 12, 2014 – Mar 13, 2014 Generic PHY framework

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 phy: exynos: fix building as a module

The top-level phy-samsung-usb2 driver may be configured as a loadable module, which currently causes link errors because of the dependency on the exynos{5250,4x12,4210}_usb2_phy_config symbol. Solving this could be achieved by exporting these symbols, but as the SoC-specific parts of the driver are not currently built as modules, it seems better to just link everything into one module and avoid the need for the export.

Signed-off-by Arnd Bergmann <[email protected]>
drivers/phy/Makefile +5 -4
index 2faf78e..7728518 100644
@@ -13,8 +13,9 @@ obj-$(CONFIG_TI_PIPE3)			+= phy-ti-pipe3.o
 obj-$(CONFIG_TWL4030_USB)		+= phy-twl4030-usb.o
 obj-$(CONFIG_PHY_EXYNOS5250_SATA)	+= phy-exynos5250-sata.o
 obj-$(CONFIG_PHY_SUN4I_USB)		+= phy-sun4i-usb.o
-obj-$(CONFIG_PHY_SAMSUNG_USB2)		+= phy-samsung-usb2.o
-obj-$(CONFIG_PHY_EXYNOS4210_USB2)	+= phy-exynos4210-usb2.o
-obj-$(CONFIG_PHY_EXYNOS4X12_USB2)	+= phy-exynos4x12-usb2.o
-obj-$(CONFIG_PHY_EXYNOS5250_USB2)	+= phy-exynos5250-usb2.o
+obj-$(CONFIG_PHY_SAMSUNG_USB2)		+= phy-exynos-usb2.o
+phy-exynos-usb2-y			+= phy-samsung-usb2.o
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4210_USB2)	+= phy-exynos4210-usb2.o
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2)	+= phy-exynos4x12-usb2.o
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2)	+= phy-exynos5250-usb2.o
 obj-$(CONFIG_PHY_XGENE)			+= phy-xgene.o
Acked-by on v1 1/1
#1 lore raw

Hi Arnd,

Quoted 10 lines

From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: Wednesday, March 12, 2014 4:48 PM

The top-level phy-samsung-usb2 driver may be configured as a loadable module, which currently causes link errors because of the dependency on the exynos{5250,4x12,4210}_usb2_phy_config
symbol. Solving this could be achieved by exporting these symbols, but as the SoC-specific parts of the driver are not currently built as modules, it seems better to just link everything into one module and avoid the need for the export.

Thank you for this patch and spotting this error.

Acked-by Kamil Debski <[email protected]>

Best wishes,

Signature · 2 lines
Kamil Debski
Samsung R&D Institute Poland

drivers/phy/Makefile obj-$(CONFIG_TI_PIPE3) +=

Quoted 8 lines
Signed-off-by Arnd Bergmann <[email protected]>
drivers/phy/Makefile index renamed from drivers/phy/Makefile +0 -0

2faf78e..7728518 100644

drivers/phy/Makefile +0 -0
@@ -13,8 +13,9 @@ obj-$(CONFIG_TI_PIPE3)			+=

phy-ti-pipe3.o

drivers/phy/Makefile obj-$(CONFIG_TI_PIPE3) += phy-ti-pipe3.o

Quoted 10 lines
drivers/phy/Makefile +3 -4
 obj-$(CONFIG_TWL4030_USB)		+= phy-twl4030-usb.o
 obj-$(CONFIG_PHY_EXYNOS5250_SATA)	+= phy-exynos5250-sata.o
 obj-$(CONFIG_PHY_SUN4I_USB)		+= phy-sun4i-usb.o
-obj-$(CONFIG_PHY_SAMSUNG_USB2)		+= phy-samsung-usb2.o
-obj-$(CONFIG_PHY_EXYNOS4210_USB2)	+= phy-exynos4210-usb2.o
-obj-$(CONFIG_PHY_EXYNOS4X12_USB2)	+= phy-exynos4x12-usb2.o
-obj-$(CONFIG_PHY_EXYNOS5250_USB2)	+= phy-exynos5250-usb2.o
+obj-$(CONFIG_PHY_SAMSUNG_USB2)		+= phy-exynos-usb2.o
+phy-exynos-usb2-y			+= phy-samsung-usb2.o
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4210_USB2)	+=

phy-exynos4210-usb2.o

drivers/phy/Makefile obj-$(CONFIG_TI_PIPE3) += · line 19

Quoted 1 line
drivers/phy/Makefile +1 -0
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS4X12_USB2)	+=

phy-exynos4x12-usb2.o

drivers/phy/Makefile obj-$(CONFIG_TI_PIPE3) += · line 20

Quoted 1 line
drivers/phy/Makefile +1 -0
+phy-exynos-usb2-$(CONFIG_PHY_EXYNOS5250_USB2)	+=

phy-exynos5250-usb2.o

Quoted 1 line
drivers/phy/Makefile +0 -0
 obj-$(CONFIG_PHY_XGENE)			+= phy-xgene.o