Skip to contentSkip to conversation

mod_timer fix for dst.c

PATCH In review Vinay K Nallamothu 2 participants 2 messages May 3, 2003 Networking

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mod_timer fix for dst.c

Hi,

Small fix converting {del,add}_timer to mod_timer.

Applicable for 2.4.x also

vinay

net/core/dst.c +1 -3
@@ -154,11 +154,9 @@
 	dst->next = dst_garbage_list;
 	dst_garbage_list = dst;
 	if (dst_gc_timer_inc > DST_GC_INC) {
-		del_timer(&dst_gc_timer);
 		dst_gc_timer_inc = DST_GC_INC;
 		dst_gc_timer_expires = DST_GC_MIN;
-		dst_gc_timer.expires = jiffies + dst_gc_timer_expires;
-		add_timer(&dst_gc_timer);
+		mod_timer(&dst_gc_timer, jiffies + dst_gc_timer_expires);
 	}
 	spin_unlock_bh(&dst_lock);
 }
#1 lore raw

Post this to where it belongs, the linux-net and netdev lists.

This is occuring far too frequently, and I'll be damned if I'm going to be required to read each and every linux-kernel posting to catch all of the networking patches.

Therefore, from now on I'm going to flat out ignore every networking patch that is sent to lkml and isn't at least CC:'d to linux-net, netdev, or the listed networking maintainers. I mean what the heck is the purpose of the MAINTAINERS entry if people don't even use it?

Signature · 1 line
David S. Miller <[email protected]>