Latest GCC-3.3 is much quieter about sign/unsigned comparisons
Hi.
This change ...
2003-05-02 Zack Weinberg <[email protected]>
PR c/10604
* c-opts.c (c_common_decode_option <OPT_Wall>): Set warn_sign_compare for C++ only.
* doc/invoke.texi: Clarify documentation of -Wsign-compare.
... has eliminated all the warnings that GCC-3.3 by default printed with regards to signed/unsigned comparisons. A build of today's BK with this compiler is much quieter than those previously done with the 3.3 snapshots.
Art Haas
Signature · 4 lines
To announce that there must be no criticism of the President, or that we are to stand by the President, right or wrong, is not only unpatriotic and servile, but is morally treasonable to the American public. -- Theodore Roosevelt, Kansas City Star, 1918
Hello there, :-)
Quoted 11 lines · Art Haas
Hi.
This change ...
2003-05-02 Zack Weinberg <[email protected]>
PR c/10604
*c-opts.c(c_common_decode_option<OPT_Wall>): Setwarn_sign_comparefor C++ only.
* doc/invoke.texi: Clarify documentation of -Wsign-compare.
Quoted 4 lines
... has eliminated all the warnings that GCC-3.3 by default printed with regards to signed/unsigned comparisons. A build of today's BK with this compiler is much quieter than those previously done with the 3.3 snapshots.
Yes, it means the warnings are not printed, it doesn't mean the problem has gone away though.
I'd still like for someone to tell me if there is a specific reason to use signed numbers in for example inode.c in one of the filesystems (can't remember which one of the top of my head). I for one would get rather surprised if some of my data started getting stored with negative inodes...
Regards,
/Anders
Quoted 9 lines · Anders Karlsson
Quoted 5 lines · Art Haas
This change ...
... has eliminated all the warnings that GCC-3.3 by default printed with regards to signed/unsigned comparisons. A build of today's BK with this compiler is much quieter than those previously done with the 3.3 snapshots.Yes, it means the warnings are not printed, it doesn't mean the problem has gone away though.
Which one do you mean? The real signed-unsigned bugs in the kernel or the problem of gcc to weed out the false positives.
"find /usr/src/linux -type f | xargs cat" will catch every single bug in the linux kernel, but I bet it won't get too many fixed. Those gcc warnings are a bit better, but just a bit.
Quoted 5 lines
I'd still like for someone to tell me if there is a specific reason to use signed numbers in for example
inode.cin one of the filesystems (can't remember which one of the top of my head). I for one would get rather surprised if some of my data started getting stored with negative inodes...
If you manually seperate false positives from real bugs, then those real ones should get fixed. Feel free to bombard me with any, but try to keep the ratio of false positives low.
Jörn
Signature · 2 lines
"Translations are and will always be problematic. They inflict violence upon two languages." (translation from German)
Quoted 6 lines
... has eliminated all the warnings that GCC-3.3 by default printed with regards to signed/unsigned comparisons. A build of today's BK with this compiler is much quieter than those previously done with the 3.3 snapshots.
Is this a good thing, though? I'm quite sure those warnings were useful.
Signature · 1 line
Tomas Szepe <[email protected]>
Quoted 6 lines · Tomas Szepe
Quoted 4 lines
... has eliminated all the warnings that GCC-3.3 by default printed with regards to signed/unsigned comparisons. A build of today's BK with this compiler is much quieter than those previously done with the 3.3 snapshots.
Is this a good thing, though? I'm quite sure those warnings were useful.
In a lot of cases, they were just noise. They are still there with -W if you really want to see them.
Dave