Skip to contentSkip to conversation

bk15 build fails with modular apm (undefined reference to MODULE_OWNER)

DISCUSSION ismail donmez 2 participants 2 messages May 22, 2003

lore
Share & tools
lore

ismail donmez

author
#0 lore raw

Hi,

Adding
#define SET_MODULE_OWNER(apm_proc) do { } while (0) to arch/i386/kernel/apm.c fixes this.

-----Original Message-----
From: Jurriaan <[email protected]>
To: [email protected]
Date: Thu, 22 May 2003 09:41:40 +0200
Subject: Re: bk15 build fails with modular apm (undefined reference to MODULE_OWNER)

From: Jurriaan <[email protected]>
Date: Thu, May 22, 2003 at 08:47:46AM +0200

Quoted 13 lines

gcc -Wp,-MD,init/.version.o.d -D__KERNEL__ -Iinclude -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-pipe -mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include -DKBUILD_BASENAME=
version -DKBUILD_MODNAME=version -c -o init/version.o init/version.c
ld -m elf_i386 -r -o init/built-in.o init/main.o init/version.o init/mounts.o init/initramfs.o

        ld -m elf_i386  -T arch/i386/vmlinux.lds.s arch/i386/kernel/head.o arch/i386/kernel/init_task.o   init/built-in.o --start-gro

up usr/built-in.o arch/i386/kernel/built-in.o arch/i386/mm/built-in.o arch/i386/mach-default/built-in.o kernel/built-in.o mm/bu ilt-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o lib/lib.a arch/i386/lib/lib.a drivers/built-in.o sound/built-in.o arch/i386/pci/built-in.o net/built-in.o --end-group -o .tmp_vmlinux1 arch/i386/kernel/built-in.o(.init.text+0x5744): In function `apm_init':
: undefined reference to `SET_MODULE_OWNER'
make: *** [.tmp_vmlinux1] Error 1
:

Quoted 4 lines

Is SET_MODULE_OWNER needed or not?
Browsing the source it seems it is defined as a nop in some places (include/linux/netdevice.h) which is where it is mostly used...

Sorry for not being clear the first time:

this is _not_ with apm modular, but with CONFIG_APM=y.

Jurriaan

Signature · 10 lines
In the middle of a good time
Truth gave me her icy kiss
Look around, you must be joking
	Oysterband - All that way for this
Debian (Unstable) GNU/Linux 2.5.69-bk11 4104 bogomips load av: 0.26 0.21 0.22
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#1 lore raw

In article <[email protected]> (at Thu, 22 May 2003 02:33:39 -0600), "ismail donmez" <[email protected]> says:

Quoted 3 lines

Adding
#define SET_MODULE_OWNER(apm_proc) do { } while (0) to arch/i386/kernel/apm.c fixes this.

:

Quoted 6 lines
Quoted 6 lines

arch/i386/kernel/built-in.o(.init.text+0x5744): In function `apm_init':
: undefined reference to `SET_MODULE_OWNER'
make: *** [.tmp_vmlinux1] Error 1
:

Is SET_MODULE_OWNER needed or not?

I believe we should set apm_proc->owner here.

Index: linux25-LINUS/arch/i386/kernel/apm.c
===================================================================
RCS file: /cvsroot/usagi/usagi-backport/linux25/arch/i386/kernel/apm.c,v retrieving revision 1.1.1.12

arch/i386/kernel/apm.c +1 -1
diff -u -r1.1.1.12 apm.c
@@ -2013,7 +2013,7 @@
 
 	apm_proc = create_proc_info_entry("apm", 0, NULL, apm_get_info);
 	if (apm_proc)
-		SET_MODULE_OWNER(apm_proc);
+		apm_proc->owner = THIS_MODULE;
 
 	kernel_thread(apm, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGHAND | SIGCHLD);
Signature · 2 lines
Hideaki YOSHIFUJI @ USAGI Project <[email protected]>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA