radeonfb doesn't compile in 2.4.21-rc6
PATCH 1/1 radeonfb doesn't compile in 2.4.21-rc6
It seems to me that this was already reported for previous 2.4.21-rc's, but never applied.
Here's the patch that make radeonfb compile (and work) on my Ibook:
--- linux-2.4.21-rc6/drivers/video/radeonfb.c 2003-04-11
19:06:04.0000
00000 +0200
+++ linux-2.4.21-rc6-fixed/drivers/video/radeonfb.c 2003-06-01
20:58:42.0000
00000 +0200
@@ -1001,8 +1001,8 @@
/* According to XFree86 4.2.0, some production M6's return 0
for 8MB. */
if (rinfo->video_ram == 0 &&
- (pdev->device == PCI_DEVICE_ID_RADEON_LY ||
- pdev->device == PCI_DEVICE_ID_RADEON_LZ)) {
+ (pdev->device == PCI_DEVICE_ID_ATI_RADEON_LY ||
+ pdev->device == PCI_DEVICE_ID_ATI_RADEON_LZ)) {
rinfo->video_ram = 8192 * 1024;
}Linux version 2.4.21-rc6-fixed (jocelyn@(none)) (gcc version 3.2) #3 Sun Jun 1 21:02:23 CEST 2003
cpu : 750FX
clock : 700MHz
revision : 1.18 (pvr 7000 0112)
bogomips : 1389.36
machine : PowerBook4,3
motherboard : PowerBook4,3 MacRISC2 MacRISC Power Macintosh
detected as : 257 (iBook 2 rev. 2)
pmac flags : 0000000b
L2 cache : 512K unified
memory : 384MB
pmac-generation : NewWorld
PCI devices found:
Bus 0, device 11, function 0:
Host bridge: Apple Computer Inc. UniNorth/Pangea AGP (rev 0).
Master Capable. Latency=16.
Bus 0, device 16, function 0:
VGA compatible controller: ATI Technologies Inc Radeon Mobility M6
LY (rev 0).
IRQ 48.
Master Capable. Latency=255. Min Gnt=8.
Prefetchable 32 bit memory at 0x98000000 [0x9fffffff].
I/O at 0x802400 [0x8024ff].
Non-prefetchable 32 bit memory at 0x90000000 [0x9000ffff]....
Signature · 1 line
Jocelyn Mayer <[email protected]>
On Monday 02 June 2003 20:24, Jocelyn Mayer wrote:
Hi Jocelyn,
Quoted 4 lines
It seems to me that this was already reported for previous 2.4.21-rc's, but never applied.
Here's the patch that make radeonfb compile (and work) on my Ibook:
maybe it was never applied because you don't cc the 2.4 maintainer (Marcelo Tosati)?
ciao, Marc
Quoted 12 lines · Jocelyn Mayer
It seems to me that this was already reported for previous 2.4.21-rc's, but never applied.
Here's the patch that make radeonfb compile (and work) on my Ibook:19:06:04.0000
00000 +0200
+++linux-2.4.21-rc6-fixed/drivers/video/radeonfb.c2003-06-01
20:58:42.0000
00000 +0200
Review line 1007
Quoted 9 lines
(quoted diff) +2
-2@@ -1001,8 +1001,8 @@ /* According to XFree86 4.2.0, some production M6's return 0 for 8MB. */ if (rinfo->video_ram == 0 && - (pdev->device == PCI_DEVICE_ID_RADEON_LY || - pdev->device == PCI_DEVICE_ID_RADEON_LZ)) { + (pdev->device == PCI_DEVICE_ID_ATI_RADEON_LY || + pdev->device == PCI_DEVICE_ID_ATI_RADEON_LZ)) { rinfo->video_ram = 8192 * 1024; }
Hi,
I can't seem to find PCI_DEVICE_ID_ATI_RADEON_LY or PCI_DEVICE_ID_ATI_RADEON_LZ defined *anywhere* in 2.4.21-rc6, and the 2.4.21-rc6 version of radeonfb.c compiled just fine for me.
- James
Hello all,
Please apologize:
I checked the code and I finaly noticed
that this is a linuxPPC bug and that the buggy lines haven't been reported in the main kernel tree.
So I will resend the patch to the LinuxPPC mainteners instead.
I promise I will check better before complaining,
the next time I'll do :=)
Quoted 11 lines · James Mayer
Quoted 5 lines · Jocelyn Mayer
It seems to me that this was already reported for previous 2.4.21-rc's, but never applied.
Here's the patch that make radeonfb compile (and work) on my Ibook:maybe it was never applied because you don't cc the 2.4 maintainer (Marcelo Tosati)?
ciao, Marc
Ooops, I didn't post this patch before, but I think someone did. That's the point I wanted to show...
Quoted 24 lines
Quoted 7 lines
19:06:04.0000
00000 +0200
+++linux-2.4.21-rc6-fixed/drivers/video/radeonfb.c2003-06-01
20:58:42.0000
00000 +0200Review line 1007
Quoted 9 lines
(quoted diff) +2
-2@@ -1001,8 +1001,8 @@ /* According to XFree86 4.2.0, some production M6's return 0 for 8MB. */ if (rinfo->video_ram == 0 && - (pdev->device == PCI_DEVICE_ID_RADEON_LY || - pdev->device == PCI_DEVICE_ID_RADEON_LZ)) { + (pdev->device == PCI_DEVICE_ID_ATI_RADEON_LY || + pdev->device == PCI_DEVICE_ID_ATI_RADEON_LZ)) { rinfo->video_ram = 8192 * 1024; }Hi,
I can't seem to find
PCI_DEVICE_ID_ATI_RADEON_LYorPCI_DEVICE_ID_ATI_RADEON_LZdefined *anywhere* in 2.4.21-rc6, and the 2.4.21-rc6 version ofradeonfb.ccompiled just fine for me.- James
Signature · 1 line
Jocelyn Mayer <[email protected]>