Skip to contentSkip to conversation

[2.5.70][PPC] Small change to config

PATCH Daniele Pala 2 participants 3 messages Jun 5, 2003 – Jun 6, 2003 1 message not in the archive Framebuffer layer

lore
Share & tools
lore
#0 lore raw

Since "control" and "platinum" display support doesn't compile if /dev/nvram suppor is selected as a module, here's this small patch. The problem is that the suppor for /dev/nvram is asked after the "control" and "platinum" support... Cheers,
Daniele

drivers/video/Kconfig +2 -2
@@ -242,14 +242,14 @@
 
 config FB_CONTROL
 	bool "Apple \"control\" display support"
-	depends on FB && PPC && ALL_PPC
+	depends on FB && PPC && ALL_PPC && NVRAM=y
 	help
 	  This driver supports a frame buffer for the graphics adapter in the
 	  Power Macintosh 7300 and others.
 
 config FB_PLATINUM
 	bool "Apple \"platinum\" display support"
-	depends on FB && PPC && ALL_PPC
+	depends on FB && PPC && ALL_PPC && NVRAM=y
 	help
 	  This driver supports a frame buffer for the "platinum" graphics
 	  adapter in some Power Macintoshes.
#1 lore raw
Quoted 3 lines · Daniele Pala

Since "control" and "platinum" display support doesn't compile if /dev/nvram suppor is selected as a module, here's this small patch. The problem is that the suppor for /dev/nvram is asked after the "control" and "platinum" support... Cheers,

The proper fix is for those drivers to use the low level nvram access functions and have those always built in on pmac, the config option beeing only useful for the char device wrapper...

Anyway, pmac stuff in 2.5 is about to be significantly changed once I'm done with the move to the new driver model, hopefully, I'll fix those things along.

Ben.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 11 lines · Martin Zwickel

On Fri, 1 Jan 1904 02:51:54 +0100
Daniele Pala <[email protected]> bubbled:

Quoted 1 line

Date: Fri, 1 Jan 1904 02:51:54 +0100

just a hint:
would be nice if you set your date and time correctly ... ;)

Regards,
Martin

mmmm...yeah, of course my clock is 1 minute late. sorry :) Cheers,
Daniele