Skip to contentSkip to conversation

add bootmem failure warning

PATCH New Dave Hansen 1 participant 1 message Jun 6, 2003 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add bootmem failure warning

__alloc_bootmem_core() has a couple of BUG_ON()'s. Since the handlers aren't set up this early, if you hit it, you just get along stream of "Unknown Interrupt" messages. It would be very nice to have a little bit more information when something has decided to BUG() out this early.

Signature · 2 lines
Dave Hansen
[email protected]
mm/bootmem.c +5 -1
@@ -151,7 +151,11 @@ __alloc_bootmem_core(struct bootmem_data
 	unsigned long i, start = 0, incr, eidx;
 	void *ret;
 
-	BUG_ON(!size);
+	if(!size) {
+		printk("__alloc_bootmem_core(): zero-sized request\n");
+		dump_stack();
+		BUG();
+	}
 	BUG_ON(align & (align-1));
 
 	eidx = bdata->node_low_pfn - (bdata->node_boot_start >> PAGE_SHIFT);

diff -rup linux-2.5.70-clean/mm/page_alloc.c linux-2.5.70-early/mm/page_alloc.c