Skip to contentSkip to conversation

remove superfluous inode superblock check from shmem_mmap

PATCH José Luis Alarcón Sánchez 1 participant 1 message Jun 15, 2003

lore
Share & tools
lore
#0 lore raw
Quoted 7 lines

------- Mensaje Original -------

DeJames Morris <[email protected]>
FechaMon, 16 Jun 2003 02:14:37 +1000 (EST)

This patch against current 2.5 bk removes a (now) unecessary check

for an

Quoted 1 line

inode superblock in shmem_mmap(). In the current kernel, all inodes

must

Quoted 12 lines

be associated with a superblock.

- James

Signature · 4 lines
James Morris


diff -purN -X dontdiff bk.pending/mm/shmem.c bk.w1/mm/shmem.c

mm/shmem.c 2003-06-16 02:06:55.142303751 +1000 static int shmem_mmap(struct file *file, · line 1016

Quoted 8 lines
mm/shmem.c 2003-06-16 02:06:55.142303751 +1000 renamed from mm/shmem.c 2003-06-16 00:56:13.000000000 +1000 +1 -1
@@ -1010,7 +1010,7 @@ static int shmem_mmap(struct file *file,
 struct inode *inode = file->f_dentry->d_inode;
 
 ops = &shmem_vm_ops;
- if (!inode->i_sb || !S_ISREG(inode->i_mode))
+ if (!S_ISREG(inode->i_mode))
  return -EACCES;
 update_atime(inode);
 vma->vm_ops = ops;

Can i apply this patch against the 2.5.69 kernel?.

Thanks yo very much, in advance.

Regards.

Jose.

http://linuxespana.scripterz.org

FreeBSD RELEASE 4.8.
Mandrake Linux 9.1 Kernels 2.4.21 & 2.5.69 XFS. Registered Linux User #213309. Memories..... You are talking about memories. Rick Deckard. Blade Runner.

_________________________________________________________
Envia tus postales desde Tarjetas Nico. Entra en http://www.tarjetasnico.com/es/index.html?partner=lycoses&nico_usr=premium