Skip to contentSkip to conversation

(Resent) [PATCH] 2.5.72 smb_proc_setattr_unix warnings

PATCH Flameeyes 2 participants 2 messages Jun 19, 2003

lore
Share & tools
lore

Flameeyes

author
#0 lore raw

This patch fixes these warnings:

CC fs/smbfs/proc.o
fs/smbfs/proc.c: In function `smb_proc_setattr_unix':
fs/smbfs/proc.c:3044: warning: integer constant is too large for "long" type
fs/smbfs/proc.c:3045: warning: integer constant is too large for "long" type
fs/smbfs/proc.c:3046: warning: integer constant is too large for "long" type
fs/smbfs/proc.c:3047: warning: integer constant is too large for "long" type
fs/smbfs/proc.c:3048: warning: integer constant is too large for "long" type

it simply adds the ULL attr at the end of the constants in include/linux/smbno.h

Signature · 1 line
Flameeyes <[email protected]>
linux/smbno.h renamed from linux/smbno.h.orig +2 -2
@@ -347,8 +347,8 @@
 #define SMB_MODE_NO_CHANGE		0xFFFFFFFF
 #define SMB_UID_NO_CHANGE		0xFFFFFFFF
 #define SMB_GID_NO_CHANGE		0xFFFFFFFF
-#define SMB_TIME_NO_CHANGE		0xFFFFFFFFFFFFFFFF
-#define SMB_SIZE_NO_CHANGE		0xFFFFFFFFFFFFFFFF
+#define SMB_TIME_NO_CHANGE		0xFFFFFFFFFFFFFFFFULL
+#define SMB_SIZE_NO_CHANGE		0xFFFFFFFFFFFFFFFFULL
 
 /* UNIX filetype mappings. */
 #define UNIX_TYPE_FILE		0
#1 lore raw
Quoted 2 lines · Flameeyes

it simply adds the ULL attr at the end of the constants in include/linux/smbno.h

It's in Andrew Morton's tree already, I expect it should be sent upwards soon :)

-Josh

Signature · 1 line
New PGP public key: 0x27AFC3EE