Skip to contentSkip to conversation

fix info leak

PATCH New Albert Cahalan 1 participant 1 message Jul 18, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix info leak

Here's a better fix for the kernel stack data leaking out into user-space. (due to padding) This fix takes advantage of the fact that an i386 machine is little-endian. The type of st_rdev may be widened to fill the gap, causing the extra 2 bytes to get zeroed when st_rdev is written to.

Everybody: use -Wpadded to find these

include/asm-i386/stat.h +1 -1
@@ -9,6 +9,6 @@
 	unsigned short st_uid;
 	unsigned short st_gid;
-	unsigned short st_rdev;
+	unsigned int   st_rdev;
 	unsigned long  st_size;
 	unsigned long  st_atime;
 	unsigned long  st_mtime;