Skip to contentSkip to conversation

md: Fix badness in sysfs_notify caused by md_new_event

PATCH New NeilBrown 1 participant 1 message May 30, 2006 1 message not in the archive MD RAID

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20060530152626.4554.patches@notabene

NeilBrown

author
#1 lore raw

PATCH 1/1 md: Fix badness in sysfs_notify caused by md_new_event

Here is a patch for a bug in 2.6.17-rc that just came to light. It should get into 2.6.17 if possible and so is in 'obviously correct' form rather than "correct final fix" form (see comments). The patch was actually generated agains -rc4-mm3, but applies to -rc4-git9 with a moderate offset for one of the chunks (no fuzz).

Thanks,
NeilBrown

### Comments for Changeset

If an error is reported by a drive in a RAID array (which is done via bi_end_io - in interrupt context), we call md_error and md_new_event which calls sysfs_notify.
However sysfs_notify grabs a mutex and so cannot be called in interrupt context.

This patch just creates a variant of md_new_event which avoids the sysfs call, and uses that.
A better fix for later is to arrange for the event to be called from user-context.

Note: avoiding the sysfs call isn't a problem as an error will not, by itself, modify the sync_action attribute. (We do still need to wake_up(&md_event_waiters) as an error by itself will modify /proc/mdstat).

### Diffstat output

 ./drivers/md/md.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/md/md.c renamed from drivers/md/md.c~current~ +10 -1
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
@@ -172,6 +172,15 @@ void md_new_event(mddev_t *mddev)
 }
 EXPORT_SYMBOL_GPL(md_new_event);
 
+/* Alternate version that can be called from interrupts
+ * when calling sysfs_notify isn't needed.
+ */
+void md_new_event_inintr(mddev_t *mddev)
+{
+	atomic_inc(&md_event_count);
+	wake_up(&md_event_waiters);
+}
+
 /*
  * Enables to iterate over all existing md arrays
  * all_mddevs_lock protects this list.
@@ -4268,7 +4277,7 @@ void md_error(mddev_t *mddev, mdk_rdev_t
 	set_bit(MD_RECOVERY_INTR, &mddev->recovery);
 	set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
 	md_wakeup_thread(mddev->thread);
-	md_new_event(mddev);
+	md_new_event_inintr(mddev);
 }
 
 /* seq_file implementation /proc/mdstat */