Skip to contentSkip to conversation

fix off-by-one error in ioremap()

DISCUSSION Arjan van de Ven 2 participants 2 messages Sep 18, 2003 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 9 lines · Linux Kernel Mailing List

ChangeSet 1.1063.43.5, 2003/09/12 04:15:36-04:00, [email protected]

fix off-by-one error in ioremap()
fixes kernel crash in acpi mode: http://bugzilla.kernel.org/show_bug.cgi?id=1085

diff -Nru a/arch/i386/mm/ioremap.c b/arch/i386/mm/ioremap.c

arch/i386/mm/ioremap.c line 144

Quoted 6 lines
arch/i386/mm/ioremap.c +1 -1
@@ -140,7 +140,7 @@
 	 */
 	offset = phys_addr & ~PAGE_MASK;
 	phys_addr &= PAGE_MASK;
-	size = PAGE_ALIGN(last_addr) - phys_addr;
+	size = PAGE_ALIGN(last_addr+1) - phys_addr;
 

A bit higher in that function is:

        /* Don't allow wraparound or zero size */
        last_addr = phys_addr + size - 1;
        if (!size || last_addr < phys_addr)
                return NULL;

so why do you undo the deliberate -1 there ?

#2 lore raw
Quoted 20 lines · Arjan van de Ven
Quoted 9 lines · Linux Kernel Mailing List

ChangeSet 1.1063.43.5, 2003/09/12 04:15:36-04:00, [email protected]

fix off-by-one error in ioremap()
fixes kernel crash in acpi mode: http://bugzilla.kernel.org/show_bug.cgi?id=1085

diff -Nru a/arch/i386/mm/ioremap.c b/arch/i386/mm/ioremap.c

arch/i386/mm/ioremap.c line 144

Quoted 6 lines
arch/i386/mm/ioremap.c +1 -1
@@ -140,7 +140,7 @@
 	 */
 	offset = phys_addr & ~PAGE_MASK;
 	phys_addr &= PAGE_MASK;
-	size = PAGE_ALIGN(last_addr) - phys_addr;
+	size = PAGE_ALIGN(last_addr+1) - phys_addr;
 

A bit higher in that function is:

Quoted 7 lines
        /* Don't allow wraparound or zero size */
        last_addr = phys_addr + size - 1;
        if (!size || last_addr < phys_addr)
                return NULL;

so why do you undo the deliberate -1 there ?

Because:

last_addr = phys_addr + size - 1
means that
size = last_addr - phys_addr + 1
not
size = last_addr - phys_addr

If you leave out this change, then a request for a page-aligned 4096+1 bytes will give you a single 4096 byte page, and the kernel will crash when you access byte 4096+1.

As this bug has been in the kernel for years, it apparently isn't common to access 4097-byte item starting on page boundaries;-)

However, ACPI maps tables that are left on arbitrary byte boundaries by the BIOS. In this case we got a table that started near the end of a page and overflowed 1 byte into the next page -- which has the same effect as the simpler case above.

cheers,
-Len

ps. this fix has been in 2.6 for several months -- sort of a bummer it had to be debugged and fixed twice.