Skip to contentSkip to conversation

igb: Don't add PHY address to PCDL address

PATCH New Aaron Sierra 2 participants 2 messages Nov 3, 2015 – Dec 3, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 2/5 igb: Don't add PHY address to PCDL address

There is no reason to add the PHY address into the PCDL register address.

---
 drivers/net/ethernet/intel/igb/e1000_phy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/intel/igb/e1000_phy.c +1 -2
index ec1aea5..407d44a 100644
@@ -1734,8 +1734,7 @@ s32 igb_get_cable_length_m88_gen2(struct e1000_hw *hw)
 			goto out;
 
 		/* Get cable length from PHY Cable Diagnostics Control Reg */
-		ret_val = phy->ops.read_reg(hw, (I347AT4_PCDL + phy->addr),
-					    &phy_data);
+		ret_val = phy->ops.read_reg(hw, I347AT4_PCDL, &phy_data);
 		if (ret_val)
 			goto out;
 
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/5 igb: Don't add PHY address to PCDL address

Quoted 6 lines

From: Intel-wired-lan [intel-wired-lan-bounces at lists.osuosl.org] on behalf of Aaron Sierra [asierra at xes-inc.com]
Sent: Tuesday, November 03, 2015 10:37 AM
To: Kirsher, Jeffrey T; intel-wired-lan at lists.osuosl.org
Cc: Joe Schultz
Subject: [Intel-wired-lan] [PATCH 2/5] igb: Don't add PHY address to PCDL address

Quoted 6 lines

There is no reason to add the PHY address into the PCDL register address.

---
 drivers/net/ethernet/intel/igb/e1000_phy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)