Skip to contentSkip to conversation

1.1-rc9 acpi_disabled==0x30 on resume

DISCUSSION Nigel Cunningham 4 participants 10 messages Sep 26, 2003 – Sep 30, 2003 8 messages not in the archive ACPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

Nigel Cunningham

author
#2 lore raw

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

Regards,

Nigel

Quoted 20 lines · Michael Frank

Hi Nigel,

I found that acpi modules can't be inserted on resume because acpi ends up disabled with acpi_disabled==0x30 .

Setting acpi_disabled to 0 using kdb fixes it.

Regards
Michael

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
swsusp-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/swsusp-devel

Signature · 13 lines
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

You see, at just the right time, when we were still powerless,
Christ died for the ungodly.
	-- Romans 5:6, NIV.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Thus wrote Nigel Cunningham:

Quoted 4 lines

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

I believe the patch is already merged. I wonder how could this bug be present for that long without anyone noticing...
Best regards,

Signature · 8 lines
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/[email protected]


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): 20030927000908.GB8008-DETuoxkZsSqrDJvtcaxF/[email protected]

author
#6 lore raw

Ah. Ok. I was looking at 2.4.22, not my bk tree. Michael, what are you running?

Regards.

Nigel

Quoted 9 lines · Karol Kozimor

Thus wrote Nigel Cunningham:

Quoted 4 lines

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

I believe the patch is already merged. I wonder how could this bug be present for that long without anyone noticing...
Best regards,

Signature · 13 lines
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

You see, at just the right time, when we were still powerless,
Christ died for the ungodly.
	-- Romans 5:6, NIV.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw

mhf76 2.4.22

    +kdb
    +win4lin +win4lin-option 
    +acpi-option
    +/acpi-20030916-2.4.22.diff
    +swsusp-1.1-rc9

arch/i386/kernel/acpi.c:

#ifdef	CONFIG_ACPI_INTERPRETER
	int acpi_disabled __initdata = 0;
#else
	int acpi_disabled __initdata = 1;

#endif

This should be irrelevant anyway as that kernel
is overwritten...

I find the value 0x30 strange. Are we hunting phantoms?

Regards
Michael

Quoted 9 lines · Nigel Cunningham

Ah. Ok. I was looking at 2.4.22, not my bk tree. Michael, what are you running?

Regards.

Nigel

Quoted 1 line · Karol Kozimor

Thus wrote Nigel Cunningham:

Quoted 18 lines
Quoted 8 lines
Quoted 4 lines

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

I believe the patch is already merged. I wonder how could this bug be present for that long without anyone noticing...
Best regards,

Signature · 6 lines
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

You see, at just the right time, when we were still powerless,
Christ died for the ungodly.
	-- Romans 5:6, NIV.

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#10 lore raw

My guess would be that the memory is being freed and reused, and that's where the 0x30 comes from. Could you use kdb to check it prior to suspending?

Regards,

Nigel

Quoted 15 lines · Michael Frank

mhf76 2.4.22

    +kdb
    +win4lin +win4lin-option 
    +acpi-option
    +/acpi-20030916-2.4.22.diff
    +swsusp-1.1-rc9

arch/i386/kernel/acpi.c:

#ifdef	CONFIG_ACPI_INTERPRETER
	int acpi_disabled __initdata = 0;
#else
	int acpi_disabled __initdata = 1;

#endif

Quoted 7 lines

This should be irrelevant anyway as that kernel
is overwritten...

I find the value 0x30 strange. Are we hunting phantoms?

Regards
Michael

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw

Thus wrote Nigel Cunningham:

Quoted 3 lines

My guess would be that the memory is being freed and reused, and that's where the 0x30 comes from. Could you use kdb to check it prior to suspending?

Your guess is right. Prior to fixing, acpi_disabled value was inconsistent over suspends. Getting rid of __initdata fixes those problems, and AFAIR this has already been done in linux-acpi bk tree (see linux-acpi.bkbits.com).
Best regards,

Signature · 8 lines
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/[email protected]


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

A message that is not in the archive (sent off-list or not yet received): 20030927135856.GA16612-DETuoxkZsSqrDJvtcaxF/[email protected]

#14 lore raw
Quoted 3 lines · Karol Kozimor

AFAIR
this has already been done in linux-acpi bk tree (see linux-acpi.bkbits.com).

and also done in: patch-2.4.23-pre4-pre5.bz2
(http://www.kernel.org/pub/linux/kernel/v2.4/testing/incr/patch-2.4.23-pre4-pre5.bz2 )

Quoted 5 lines

Best regards,

Signature · 2 lines
Karol 'sziwan' Kozimor
sziwan-DETuoxkZsSqrDJvtcaxF/[email protected]
Signature · 11 lines
SérgioMB
email: [email protected]

Who gives me one shell, give me everything.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
#15 lore raw
In reply to a message not in the archive
Quoted 4 lines · Nigel Cunningham

My guess would be that the memory is being freed and reused, and that's where the 0x30 comes from. Could you use kdb to check it prior to suspending?

Manual checking would not be practical, so the script unloads/loads/unloads ac prior to suspend and loads it on resume and logs/beeps when failure.

It last happend with -rc9 but not yet with -rc9D.

Last time data from the memory dump were remains of an ascii file:

in len */ /* lowowrd last bytes sought */ #define .....

Guess data not initialized on resume, but can't be major or other problems would pop up.

Regards
Michael

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

author
#16 lore raw
In reply to a message not in the archive

Yes, it is in BK.

N.

Quoted 9 lines · Karol Kozimor

Thus wrote Nigel Cunningham:

Quoted 4 lines

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

I believe the patch is already merged. I wonder how could this bug be present for that long without anyone noticing...
Best regards,

Signature · 13 lines
Nigel Cunningham
495 St Georges Road South, Hastings 4201, New Zealand

You see, at just the right time, when we were still powerless,
Christ died for the ungodly.
	-- Romans 5:6, NIV.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
#17 lore raw
In reply to a message not in the archive
Quoted 10 lines · Karol Kozimor

Thus wrote Nigel Cunningham:

Quoted 4 lines

Hi.

In arch/i386/kernel, acpi_disabled is declared __init_data. If you remove that attribute, is the issue fixed?

I believe the patch is already merged. I wonder how could this bug be present for that long without anyone noticing...
Best regards,

Well, I "use" swsusp actively in a portable application only since -rc9, and did not use ACPI modules for stress testing.

I wrote s script which loads ACPI ac module and reads the state. When online, it starts all the office stuff such as network, nfs... and found out when ac refused to load. Then I remembered something about acpi being disabled on resume and had a look with kdb...

Regards
Michael

-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf