Skip to contentSkip to conversation

2.6.0-test5 - stuck keys on iBook

PATCH In review cliff white 4 participants 5 messages Sep 30, 2003 – Oct 3, 2003

lore
Share & tools
lore

cliff white

author
#0 lore raw

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't change anything.

Haven't done much other debug, since i can't successfully login to the system from console.

Further information if needed.
Please cc me if you reply from linuxppc-dev, i am not on that group.

cliffw
[email protected]

#1 lore raw
Quoted 7 lines · cliff white

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

I've tried reverting drivers/input/keyboards/atkbd.c back to v1.31, doesn't change anything.

Just FYI, atkbd isn't used on pmacs.

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#2 lore raw
In reply to cliff white
Quoted 3 lines · cliff white

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

I can confirm this problem on my ibook r2.2 with vanilla kernel.org 2.6.0-test6. No problem with the latest test5 I tried.

Brice

#3 lore raw

PATCH 1/1 macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)

In reply to cliff white

Hi Cliff,

Quoted 3 lines · cliff white

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

Here is a patch that fixes the keyboard problem. The input layer REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb was not updated accordingly.

I hope this will help you.

Brice

macintosh/adbhid.c renamed from macintosh/adbhid.c.orig +2 -2
@@ -611,8 +611,8 @@
 		/* HACK WARNING!! This should go away as soon there is an utility
 		 * to control that for event devices.
 		 */
-		adbhid[id]->input.rep[REP_DELAY] = HZ/2;   /* input layer default: HZ/4 */
-		adbhid[id]->input.rep[REP_PERIOD] = HZ/15; /* input layer default: HZ/33 */
+		adbhid[id]->input.rep[REP_DELAY] = 500;   /* input layer default: 250 */
+		adbhid[id]->input.rep[REP_PERIOD] = 66;   /* input layer default:  33 */
 	}
 }
#4 lore raw

Re: [PATCH] macintosh/adbhid.c REP_DELAY fix (was Re: 2.6.0-test5 - stuck keys on iBook)

Quoted 5 lines · Brice Figureau

Hi Cliff,

Quoted 2 lines · cliff white

Kernel version: latest from ppc.bkbits.net/linuxppc-2.5

Quoted 7 lines
Quoted 1 line

Symptom: keyboard diarrhea - single keypress == 3-7 characters.

Here is a patch that fixes the keyboard problem. The input layer REP_DELAY (and REP_PERIOD) were changed from jiffies to ms but the adb was not updated accordingly.

I hope this will help you.

Thanks, I'll test & commit.

Ben.