Skip to contentSkip to conversation

bnxt_en: add VXLAN dependency

PATCH Applied Arnd Bergmann 3 participants 3 messages Nov 4, 2015 – Nov 5, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bnxt_en: add VXLAN dependency

VXLAN may be a loadable module, and this driver cannot be built-in in that case, or we get a link error:

drivers/built-in.o: In function `__bnxt_open_nic':
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'

This adds a Kconfig dependency that ensures that either VXLAN is disabled (which the driver handles correctly), or we depend on VXLAN itself and disallow built-in compilation when VXLAN is a module.

Fixes c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
drivers/net/ethernet/broadcom/Kconfig +1 -0
index 67a7d520d9f5..8550df189ceb 100644
@@ -173,6 +173,7 @@ config SYSTEMPORT
 config BNXT
 	tristate "Broadcom NetXtreme-C/E support"
 	depends on PCI
+	depends on VXLAN || VXLAN=n
 	select FW_LOADER
 	select LIBCRC32C
 	---help---
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Arnd Bergmann

VXLAN may be a loadable module, and this driver cannot be built-in in that case, or we get a link error:

drivers/built-in.o: In function `__bnxt_open_nic':
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'

Quoted 6 lines

This adds a Kconfig dependency that ensures that either VXLAN is disabled (which the driver handles correctly), or we depend on VXLAN itself and disallow built-in compilation when VXLAN is a module.

Thanks.

Quoted 15 lines
Fixes c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
drivers/net/ethernet/broadcom/Kconfig +1 -0
index 67a7d520d9f5..8550df189ceb 100644
@@ -173,6 +173,7 @@ config SYSTEMPORT
 config BNXT
 	tristate "Broadcom NetXtreme-C/E support"
 	depends on PCI
+	depends on VXLAN || VXLAN=n
 	select FW_LOADER
 	select LIBCRC32C
 	---help---
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann

From: Arnd Bergmann <[email protected]>
Date: Wed, 04 Nov 2015 16:00:32 +0100

Quoted 6 lines

VXLAN may be a loadable module, and this driver cannot be built-in in that case, or we get a link error:

drivers/built-in.o: In function `__bnxt_open_nic':
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'

Quoted 7 lines

This adds a Kconfig dependency that ensures that either VXLAN is disabled (which the driver handles correctly), or we depend on VXLAN itself and disallow built-in compilation when VXLAN is a module.

Fixes c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")

Applied, thanks.