Skip to contentSkip to conversation

Fix firmware loader docs

PATCH Pavel Machek 2 participants 4 messages Nov 16, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi!

AFAICS, sysfs should be mounted on /sys these days...

Documentation/firmware_class/README renamed from linux/Documentation/firmware_class/README +2 -2
@@ -60,9 +60,9 @@
 
 	HOTPLUG_FW_DIR=/usr/lib/hotplug/firmware/
 
-	echo 1 > /sysfs/$DEVPATH/loading
+	echo 1 > /sys/$DEVPATH/loading
 	cat $HOTPLUG_FW_DIR/$FIRMWARE > /sysfs/$DEVPATH/data
-	echo 0 > /sysfs/$DEVPATH/loading
+	echo 0 > /sys/$DEVPATH/loading
 
  Random notes:
  ============
Documentation/firmware_class/hotplug-script renamed from linux/Documentation/firmware_class/hotplug-script +2 -2
@@ -6,9 +6,9 @@
 
 HOTPLUG_FW_DIR=/usr/lib/hotplug/firmware/
 
-echo 1 > /sysfs/$DEVPATH/loading
+echo 1 > /sys/$DEVPATH/loading
 cat $HOTPLUG_FW_DIR/$FIRMWARE > /sysfs/$DEVPATH/data
-echo 0 > /sysfs/$DEVPATH/loading
+echo 0 > /sys/$DEVPATH/loading
 
 # To cancel the load in case of error:
 #
Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw

Hi Pavel,

Quoted 1 line

AFAICS, sysfs should be mounted on /sys these days...

we can remove the hotplug-script from 2.4 and 2.6 completly, because the firmware.agent script is now part of the linux-hotplug scripts and there is no need to write one. You only have to put the firmware file into the firmware directory, which is by default /usr/lib/hotplug/firmware/ and everything works as expected.

Regards

Marcel

#2 lore raw

Hi!

Quoted 7 lines
Quoted 1 line

AFAICS, sysfs should be mounted on /sys these days...

we can remove the hotplug-script from 2.4 and 2.6 completly, because the firmware.agent script is now part of the linux-hotplug scripts and there is no need to write one. You only have to put the firmware file into the firmware directory, which is by default /usr/lib/hotplug/firmware/ and everything works as expected.

Well, I'd keep them for a while... To stop people wondering "WTF is this"?
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#3 lore raw

Hi Pavel,

Quoted 8 lines
Quoted 5 lines

we can remove the hotplug-script from 2.4 and 2.6 completly, because the firmware.agent script is now part of the linux-hotplug scripts and there is no need to write one. You only have to put the firmware file into the firmware directory, which is by default /usr/lib/hotplug/firmware/ and everything works as expected.

Well, I'd keep them for a while... To stop people wondering "WTF is this"?

I don't think so. There is a README that should explain this and the example hotplug-script should go away, because it confuses more than it helps. The current one looks very different and is working fine for 2.4 and 2.6. If people don't have a firmware.agent script on their system they can either update the hotplug utils or use the Internet to find one.

Regards

Marcel