knfsd: Stop NFSD writes from being broken into lots of little writes to filesystem.
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): 20070213170049.3488.patches@notabene
PATCH 1/1 knfsd: Stop NFSD writes from being broken into lots of little writes to filesystem.
Another nfsd patch for 2.6.21...
### Comments for Changeset
When NFSD receives a write request, the data is typically in a number of 1448 byte segments and writev is used to collect them together.
Unfortunately, generic_file_buffered_write passes these to the filesystem one at a time, so an e.g. 32K over-write becomes a series of partial-page writes to each page, causing the filesystem to have to pre-read those pages - wasted effort.
generic_file_buffered_write handles one segment of the vector at a time as it has to pre-fault in each segment to avoid deadlocks. When writing from kernel-space (and nfsd does) this is not an issue, so generic_file_buffered_write does not need to break and iovec from nfsd into little pieces.
This patch avoids the splitting when get_fs is KERNEL_DS as it is from NFSd.
This issue was introduced by commit 6527c2bdf1f833cc18e8f42bd97973d583e4aa83
### Diffstat output
./mm/filemap.c | 32 +++++++++++++++++++------------- 1 file changed, 19 insertions(+), 13 deletions(-)
mm/filemap.c +19 -13
@@ -2160,21 +2160,27 @@ generic_file_buffered_write(struct kiocb/* Limit the size of the copy to the caller's write size */ bytes =min (bytes, count); -/* -* Limit the size of the copy to that of the current segment, -* because fault_in_pages_readable() doesn't know how to walk -* segments. +/* We only need to worry about prefaulting when writes are from +* user-space. NFSd uses vfs_writev with several non-aligned +* segments in the vector, and limiting to one segment a time is +* a noticeable performance for re-write */ - bytes =min (bytes, cur_iov->iov_len - iov_base); - -/* -* Bring in the user page that we will copy from _first_. -* Otherwise there's a nasty deadlock on copying from the -* same page as we're writing to, without it being marked -* up-to-date. -*/ -fault_in_pages_readable (buf, bytes); +if (!segment_eq (get_fs (),KERNEL_DS )) { +/* +* Limit the size of the copy to that of the current +* segment, because fault_in_pages_readable() doesn't +* know how to walk segments. +*/ + bytes =min (bytes, cur_iov->iov_len - iov_base); +/* +* Bring in the user page that we will copy from +* _first_. Otherwise there's a nasty deadlock on +* copying from the same page as we're writing to, +* without it being marked up-to-date. +*/ +fault_in_pages_readable (buf, bytes); + } page =__grab_cache_page (mapping,index,&cached_page,&lru_pvec);if (!page) { status = -ENOMEM ;
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
Quoted 18 lines · NeilBrown
Another nfsd patch for 2.6.21...
### Comments for Changeset
When NFSD receives a write request, the data is typically in a number of 1448 byte segments and writev is used to collect them together.
Unfortunately,
generic_file_buffered_writepasses these to the filesystem one at a time, so an e.g. 32K over-write becomes a series of partial-page writes to each page, causing the filesystem to have to pre-read those pages - wasted effort.
generic_file_buffered_writehandles one segment of the vector at a time as it has to pre-fault in each segment to avoid deadlocks. When writing from kernel-space (and nfsd does) this is not an issue, sogeneric_file_buffered_writedoes not need to break and iovec from nfsd into little pieces.
Quoted 6 lines
This patch avoids the splitting when
get_fsisKERNEL_DSas it is from NFSd.This issue was introduced by commit
6527c2bdf1f833cc18e8f42bd97973d583e4aa83Cc Nick Piggin <[email protected]>
FWIW, you can put Acked-by: me there if you'd like.
Thanks,
Nick
Signature · 2 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
Andrew Morton
maintainerQuoted 19 lines · On Tue, 13 Feb 2007 17:11:19 +1100 Nick Piggin <[email protected]> wrote:
Quoted 18 lines · NeilBrown
Another nfsd patch for 2.6.21...
### Comments for Changeset
When NFSD receives a write request, the data is typically in a number of 1448 byte segments and writev is used to collect them together.
Unfortunately,
generic_file_buffered_writepasses these to the filesystem one at a time, so an e.g. 32K over-write becomes a series of partial-page writes to each page, causing the filesystem to have to pre-read those pages - wasted effort.
generic_file_buffered_writehandles one segment of the vector at a time as it has to pre-fault in each segment to avoid deadlocks. When writing from kernel-space (and nfsd does) this is not an issue, sogeneric_file_buffered_writedoes not need to break and iovec from nfsd into little pieces.
Quoted 9 lines
Quoted 6 lines
This patch avoids the splitting when
get_fsisKERNEL_DSas it is from NFSd.This issue was introduced by commit
6527c2bdf1f833cc18e8f42bd97973d583e4aa83Cc Nick Piggin <[email protected]>FWIW, you can put Acked-by: me there if you'd like.
It's yet another patch we need to revert if/when we get the write()-deadlock stuff sorted out. So please add negative-this to that patch series.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs