2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels
I don't think this:
+# if defined(CONFIG_X86_SUMMIT) || defined(CONFIG_X86_GENERICARCH)
Is a good idea. You're contaminating the default subarch with another subarch specific #define.
generic arch additions are fine here, but you should find a better way to abstract the summit stuff.
James
Quoted 11 lines · James Bottomley
I don't think this:
+# if
defined(CONFIG_X86_SUMMIT)||defined(CONFIG_X86_GENERICARCH)Is a good idea. You're contaminating the default subarch with another subarch specific #define.
generic arch additions are fine here, but you should find a better way to abstract the summit stuff.
James
Sorry, but we've had distro installer kernels, which are uni-proc generic subarch kernels, blow up with array overflows on large systems.
What would you suggest I do instead?
Signature · 3 lines
James Cleverdon
IBM xSeries Linux Solutions
{jamesclv(Unix, preferred), cleverdj(Notes)} at us dot ibm dot commQuoted 4 lines · James Cleverdon
Sorry, but we've had distro installer kernels, which are uni-proc generic subarch kernels, blow up with array overflows on large systems.
What would you suggest I do instead?
For Summit just add an irq_vectors.h file that includes mach-generic/irq-vectors.h and overrides the NR_IRQ_VECTORS value
For genericarch, I'm less certain, but it seems, given the idea behind genericarch that it should probably be set at runtime when the arch type becomes known
James