Skip to contentSkip to conversation

[2.4.18]: Reiserfs: vs-2120: add_save_link: insert_item returned -28

DISCUSSION Jan De Luyck 6 participants 14 messages Jan 9, 2004 – Jan 16, 2004

lore
Share & tools
lore
#0 lore raw

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

Signature · 2 lines
It is exactly because a man cannot do a thing that he is a proper judge of it.
		-- Oscar Wilde
#1 lore raw
Quoted 6 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

Quoted 8 lines

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

Nevermind this... I was looking at the wrong partition... for half an hour....

:-(

Jan

Signature · 2 lines
My apologies if I sound angry.  I feel like I'm talking to a void.
	-- Avery Pennarun
#2 lore raw
In reply to Jan De Luyck

Hello

Quoted 10 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 9 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

#3 lore raw
Quoted 11 lines · Vladimir Saveliev

Hello

Quoted 6 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

Quoted 26 lines
Quoted 4 lines

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 9 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

why do we generate this warning? It should be fixed, yes?

Signature · 1 line
Hans
#4 lore raw
Quoted 43 lines · Hans Reiser
Quoted 13 lines · Vladimir Saveliev

Hello

Quoted 8 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

Quoted 28 lines
Quoted 4 lines

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 11 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

Quoted 1 line

why do we generate this warning? It should be fixed, yes?

Yes

#5 lore raw
Quoted 24 lines · Vladimir Saveliev
Quoted 23 lines · Hans Reiser
Quoted 22 lines · Vladimir Saveliev

Hello

Quoted 9 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 6 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

why do we generate this warning? It should be fixed, yes?

Yes

Just returning a message that makes sense to people would be nice.

Jan

Signature · 2 lines
People think love is an emotion.  Love is good sense.
		-- Ken Kesey
#6 lore raw
Quoted 45 lines · Jan De Luyck
Quoted 42 lines · Vladimir Saveliev
Quoted 39 lines · Hans Reiser
Quoted 11 lines · Vladimir Saveliev

Hello

Quoted 6 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

Quoted 22 lines
Quoted 5 lines

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 12 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

why do we generate this warning? It should be fixed, yes?

Quoted 10 lines
Quoted 3 lines

Yes

Just returning a message that makes sense to people would be nice.

Jan

there is no need for a warning at all, it is a normal condition, and returning ENOSPACE says all that we should say.

Signature · 1 line
Hans
#7 lore raw
Quoted 51 lines · Hans Reiser
Quoted 49 lines · Jan De Luyck
Quoted 45 lines · Vladimir Saveliev
Quoted 30 lines · Hans Reiser
Quoted 27 lines · Vladimir Saveliev

Hello

Quoted 11 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 6 lines

I can't seem to find much on this issue, is this a bug in reiserfs (which is fixed in a later version)? Is something wrong with the fs itself?

Thanks for answers.

Quoted 9 lines
Quoted 6 lines
Quoted 6 lines

[I'm not subscribed @ reiserfs-list, so please cc me with answers from that list]

Jan

why do we generate this warning? It should be fixed, yes?

Yes

Quoted 8 lines
Quoted 6 lines

Just returning a message that makes sense to people would be nice.

Jan

there is no need for a warning at all, it is a normal condition, and returning ENOSPACE says all that we should say.

At this case we do not return ENOSPC. Operation which failed due to ENOSPC was "save link" insertion. The major operation (unlink or truncate) just continues without "save links". (save link are used to be able to complete removal of unlinked/truncated files on reboot if they did not manage to get properly removed/truncated due to unclean shutdown).

#8 lore raw
Quoted 50 lines · Vladimir Saveliev
Quoted 39 lines · Hans Reiser
Quoted 35 lines · Jan De Luyck
Quoted 30 lines · Vladimir Saveliev
Quoted 25 lines · Hans Reiser
Quoted 20 lines · Vladimir Saveliev

Hello

Quoted 13 lines · Jan De Luyck

Hello list,

Today I discovered I could no longer create files on one of my boxes, which still runs 2.4.18 (box is too far away to upgrade right now). It gives me 'disk full' messages.

The following message is all over my logs since January 3:

vs-2120: add_save_link: insert_item returned -28

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

This is just a warning. You should be able to free some disk space by removing some files.

Quoted 13 lines

At this case we do not return ENOSPC. Operation which failed due to ENOSPC was "save link" insertion. The major operation (unlink or truncate) just continues without "save links". (save link are used to be able to complete removal of unlinked/truncated files on reboot if they did not manage to get properly removed/truncated due to unclean shutdown).

so it is a real bug which can result in space leaks?

Signature · 1 line
Hans
#9 lore raw
Quoted 8 lines · Hans Reiser
Quoted 6 lines

At this case we do not return ENOSPC. Operation which failed due to ENOSPC was "save link" insertion. The major operation (unlink or truncate) just continues without "save links". (save link are used to be able to complete removal of unlinked/truncated files on reboot if they did not manage to get properly removed/truncated due to unclean shutdown).

so it is a real bug which can result in space leaks?

It's a limitation. The only way around it would be to somehow reserve the space for the savelink when you create the file. It's a rare case and the FS carries on as best it can.

-chris

#10 lore raw
Quoted 19 lines · Chris Mason
Quoted 11 lines · Hans Reiser
Quoted 8 lines

At this case we do not return ENOSPC. Operation which failed due to ENOSPC was "save link" insertion. The major operation (unlink or truncate) just continues without "save links". (save link are used to be able to complete removal of unlinked/truncated files on reboot if they did not manage to get properly removed/truncated due to unclean shutdown).

Quoted 3 lines

so it is a real bug which can result in space leaks?

Quoted 11 lines

It's a limitation. The only way around it would be to somehow reserve the space for the savelink when you create the file. It's a rare case and the FS carries on as best it can.

-chris

does it leak space?

Signature · 1 line
Hans
#11 lore raw
In reply to Hans Reiser

Hello!

Quoted 3 lines · Hans Reiser
Quoted 3 lines
Quoted 1 line

vs-2120: add_save_link: insert_item returned -28

This is just a warning. You should be able to free some disk space by removing some files.

HR> why do we generate this warning? It should be fixed, yes?

Yes, it is fixed in newer kernels.

Bye,
Oleg

#12 lore raw
In reply to Vladimir Saveliev
Quoted 2 lines · Vladimir Saveliev

This is just a warning. You should be able to free some disk space by removing some files.

Is this just the *obvious* "removing files frees space", or is there some sort of garbage collection that will be triggered, so removing a 1K file will make it redo tables/linked lists/whatever and return lots of blocks that used to contain metadata?

#13 lore raw
Quoted 9 lines · On Fri, 2004-01-16 at 19:19, [email protected] wrote:
Quoted 2 lines · Vladimir Saveliev

This is just a warning. You should be able to free some disk space by removing some files.

Is this just the *obvious* "removing files frees space", or is there some sort of garbage collection that will be triggered, so removing a 1K file will make it redo tables/linked lists/whatever and return lots of blocks that used to contain metadata?

This is the *obvious* "removing files frees space".