Skip to contentSkip to conversation

openpowerlink: new package

PATCH Superseded Romain Naour 2 participants 3 messages Sep 23, 2013 – Oct 4, 2013 1 message not in the archive

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/1 openpowerlink: new package

---
v2:
- Fix case
- Fix statements

v1:
- Move openpowerlink to hardware handling menu
- Add package sources url
- Add some help in menuconfig
- Fix typo
- Move openpowerlink demos in a submenu
- Fix patch name
- Fix debug default value
- Add build Release or Debug depending on BR2_ENABLE_DEBUG

v0: initial commit
- Add openpowerlink package.

 package/Config.in                                  |    1 +
 package/openpowerlink/Config.in                    |  107 ++++++++++++++++++++
 .../openpowerlink-0001-fix-demo-mn-qt.patch        |   22 ++++
 package/openpowerlink/openpowerlink.mk             |   91 +++++++++++++++++
 4 files changed, 221 insertions(+)
 create mode 100644 package/openpowerlink/Config.in
 create mode 100644 package/openpowerlink/openpowerlink-0001-fix-demo-mn-qt.patch
 create mode 100644 package/openpowerlink/openpowerlink.mk
package/Config.in +1 -0
index 1dd60d1..aac0c12 100644
@@ -309,6 +309,7 @@ source "package/ofono/Config.in"
 source "package/on2-8170-modules/Config.in"
 source "package/open2300/Config.in"
 source "package/openocd/Config.in"
+source "package/openpowerlink/Config.in"
 source "package/owl-linux/Config.in"
 source "package/parted/Config.in"
 source "package/pciutils/Config.in"
package/openpowerlink/Config.in new file +107 -0

107 lines not on this page · raw message

package/openpowerlink/openpowerlink-0001-fix-demo-mn-qt.patch new file +22 -0
new file mode 100644
index 0000000..fcbdd52
@@ -0,0 +1,22 @@
+commit 8658075bd7c49a7481e8f6d0d7a13b0651e1dfd7
+Author: Romain Naour <[email protected]>
+Date:   Wed Sep 18 23:33:04 2013 +0200
+
+    [FIX] demo_mn_qt: add EplDebug.c in demo_sources list
+
+    demo_mn_qt use EplGetEmergErrCodeStr()
+
+    Signed-off-by: Romain Naour <[email protected]>
+
+diff --git a/Examples/X86/Generic/demo_mn_qt/CMakeLists.txt b/Examples/X86/Generic/demo_mn_qt/CMakeLists.txt
+index 9db2f7f..48ae9eb 100644
+--- a/Examples/X86/Generic/demo_mn_qt/CMakeLists.txt
++++ b/Examples/X86/Generic/demo_mn_qt/CMakeLists.txt
+@@ -78,6 +78,7 @@ SET(DEMO_SOURCES src/EplApi.cpp
+                  src/MainWindow.cpp
+                  src/NodeState.cpp
+                  ${POWERLINK_SOURCE_DIR}/ObjDicts/${OBJDICT}/EplApiProcessImageSetup.c
++                 ${POWERLINK_SOURCE_DIR}/EplStack/EplDebug.c
+     )
+ 
+ # The TRACE macros need trace.c on the Windows platform
package/openpowerlink/openpowerlink.mk new file +91 -0

91 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#2 lore raw

PATCH v2 1/1 openpowerlink: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"R" == Romain Naour <[email protected]> writes:

Hi,

R> +++ b/package/openpowerlink/Config.in
R> @@ -0,0 +1,107 @@
R> +comment "openpowerlink requires thread support in toolchain"
R> + depends on !BR2_TOOLCHAIN_HAS_THREADS

It also needs C++ support. From CMakeLists.txt:

PROJECT (openPOWERLINK C CXX)

R> +
R> +config BR2_PACKAGE_OPENPOWERLINK

 R> +        bool "openpowerlink"
 R> +        depends on BR2_TOOLCHAIN_HAS_THREADS
 R> +        depends on BR2_i386 || BR2_x86_64
 R> +        help

Your indentation is wrong. Config.in files should be indented with <tab> (and help lines with <tab><space><space>).

 R> +          openPOWERLINK is an Open Source Industrial Ethernet
 R> +          stack implementing the POWERLINK protocol for Managing Node
 R> +          (MN, POWERLINK Master) and Controlled Node (CN, POWERLINK Slave).

R> +
R> + It is provided by SYSTEC electronic (http://www.systec-electronic.com),

Too long line, please wrap after 'provided by'.

Besides this, it looks good. I did a quick test build with everything kept to their default and got:

[100%] Built target powerlink
make[2]: Leaving directory /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3' make[1]: Leaving directory /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'

Quoted 1 line
Quoted 1 line
Quoted 1 line

openpowerlink V1.08.3 Installing to staging directory

PATH="/home/peko/source/buildroot/output/host/bin:/home/peko/source/buildroot/output/host/usr/bin:/home/peko/source/buildroot/output/host/usr/sbin/:/home/peko/bin:/home/peko/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/opt/barco/current/usr/bin:/opt/barco/current/usr/bin" PERLLIB="/home/peko/source/buildroot/output/host/usr/lib/perl" /usr/bin/make -j5 DESTDIR=/home/peko/source/buildroot/output/host/usr/i686-buildroot-linux-uclibc/sysroot install -C /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/ make[1]: Entering directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make[1]: *** No rule to make target `install'. Stop.
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
make: *** [/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/.stamp_staging_installed] Error 2

So I guess you're missing something?

Please fix and resubmit, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 openpowerlink: new package

Hi,

----- Mail original -----

| De: "Peter Korsgaard" <[email protected]>
| ?: "Romain Naour" <[email protected]>
| Cc: buildroot at busybox.net
| Envoy?: Mercredi 2 Octobre 2013 23:37:07
| Objet: Re: [PATCH v2 1/1] openpowerlink: new package
| 
| >>>>> "R" == Romain Naour <[email protected]> writes:
| 
| Hi,
| 
|  R> +++ b/package/openpowerlink/Config.in
|  R> @@ -0,0 +1,107 @@
|  R> +comment "openpowerlink requires thread support in toolchain"
|  R> +        depends on !BR2_TOOLCHAIN_HAS_THREADS
| 
| It also needs C++ support. From CMakeLists.txt:
| 
| PROJECT (openPOWERLINK C CXX)

Indedd, but C++ support is currently only needded for qt demo which is not always selected. I'll fix that, thanks.

| 
|  R> +
|  R> +config BR2_PACKAGE_OPENPOWERLINK
|  R> +        bool "openpowerlink"
|  R> +        depends on BR2_TOOLCHAIN_HAS_THREADS
|  R> +        depends on BR2_i386 || BR2_x86_64
|  R> +        help
| 
| Your indentation is wrong. Config.in files should be indented with
| <tab>
| (and help lines with <tab><space><space>).

Sory for that, it's my webmail...

| 
|  R> +          openPOWERLINK is an Open Source Industrial Ethernet
|  R> +          stack implementing the POWERLINK protocol for Managing
|  Node
|  R> +          (MN, POWERLINK Master) and Controlled Node (CN,
|  POWERLINK Slave).
|  R> +
|  R> +          It is provided by SYSTEC electronic
|  (http://www.systec-electronic.com),
| 
| Too long line, please wrap after 'provided by'.
| 

Ok

| Besides this, it looks good. I did a quick test build with everything
| kept to their default and got:
| 
| [100%] Built target powerlink
| make[2]: Leaving directory
| `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
| make[1]: Leaving directory
| `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
| >>> openpowerlink V1.08.3 Installing to staging directory
| PATH="/home/peko/source/buildroot/output/host/bin:/home/peko/source/buildroot/output/host/usr/bin:/home/peko/source/buildroot/output/host/usr/sbin/:/home/peko/bin:/home/peko/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/opt/barco/current/usr/bin:/opt/barco/current/usr/bin"
| PERLLIB="/home/peko/source/buildroot/output/host/usr/lib/perl"
|  /usr/bin/make -j5
|  DESTDIR=/home/peko/source/buildroot/output/host/usr/i686-buildroot-linux-uclibc/sysroot
| install -C
| /home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/
| make[1]: Entering directory
| `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
| make[1]: *** No rule to make target `install'.  Stop.
| make[1]: Leaving directory
| `/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3'
| make: ***
| [/home/peko/source/buildroot/output/build/openpowerlink-V1.08.3/.stamp_staging_installed]
| Error 2
| 
| So I guess you're missing something?

I see, the user space stack is selected but no demo is build. So, there is no INSTALL rules for libpowerlink.a I'll fix that.

Furthermore, if the kernel space is sectected the build may break with latest kernels since openpowerlink stack is not mainline. openpowerlink 1.8.3 break with kernels >= 3.5.
I'll backport a patch from devel branch for that.

|
| Please fix and resubmit, thanks.

Thanks, for testing.
I'll resubmit as soon as possible.

Best regards,
Romain Naour

| 
| --
| Bye, Peter Korsgaard
|