Skip to contentSkip to conversation

Question on qla2xxx Kconfig update in 2.6.2

DISCUSSION Mike Anderson 2 participants 4 messages Feb 5, 2004 SCSI

lore
Share & tools
lore

Mike Anderson

author
#0 lore raw

Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?

After a fresh bk pull and make config I could not get the qla2xxx
directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.

-andmike
--
Michael Anderson
[email protected]

#1 lore raw
Quoted 5 lines · Mike Anderson

Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?

After a fresh bk pull and make config I could not get the qla2xxx
directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.

Erk, my fault. I quietly fixed it by altering drivers/scsi/Makefile (to make obj-$(CONFIG_SCSI_QLA2XXX_CONFIG) += qla2xxx/)

but then I apparently lost it from the tree on a rebuild.

I'll add it back.

James

author
#2 lore raw
Quoted 10 lines · James Bottomley [[email protected]] wrote:
Quoted 5 lines · Mike Anderson

Is the usage of SCSI_QLA2XXX_CONFIG instead of SCSI_QLA2XXX correct in drivers/scsi/qla2xxx/Kconfig or have I just not had enough coffee this morning?

After a fresh bk pull and make config I could not get the qla2xxx
directory selected during a make modules. If I change to using SCSI_QLA2XXX in the Kconfig file everything is fine.

Erk, my fault. I quietly fixed it by altering drivers/scsi/Makefile (to make obj-$(CONFIG_SCSI_QLA2XXX_CONFIG) += qla2xxx/)

ok.

Should we fix it the other way around (i.e., have qla2xxx Kconfig use SCSI_QLA2XXX) to be consistent with other Kconfig users. I see only one other in the .config file that I am using that has a _CONFIG postfix.

-andmike
--
Michael Anderson
[email protected]

#3 lore raw
Quoted 3 lines · Mike Anderson

Should we fix it the other way around (i.e., have qla2xxx Kconfig use SCSI_QLA2XXX) to be consistent with other Kconfig users. I see only one other in the .config file that I am using that has a _CONFIG postfix.

Well, least line of resistance when things don't work.

But I agree, removing the _CONFIG in qla2xxx/Kconfig does look better.

James