Bug in "select" dependency checking?
Hello,
I think the dependency check in scripts/kconfig/symbol.c has a bug related to "select", but possibly it's only a misunderstanding what select is supposed to do. I have the following symbols and dependencies (simplified):
config NFS_ACL_SUPPORT
tristate
config NFSD
tristate "..." select NFS_ACL_SUPPORT if NFSD_ACL
config NFSD_V3
bool "..." depends on NFSD
config NFSD_ACL
bool "..." depends on NFSD_V3
config NFS_FS
tristate "..." select NFS_ACL_SUPPORT if NFS_ACL
config NFS_V3
bool "..." depends on NFS_FS
config NFS_ACL
bool "..." depends on NFS_V3
The intention of this is as follows: NFS_ACL_SUPPORT is a symbol without menu entry. It activates an object which is either a module or linked into the kernel. It is needed if NFSD_ACL is y or NFS_ACL is y. When it is needed, it should have max(NFSD,NFS_FS).
With this configuration, menuconf gives me this message (among others):
Warning! Found recursive dependency: NFSD_V3 NFSD_ACL NFSD NFSD_V3
In my understanding, the select statement does not cause a dependency of NFSD on NFSD_ACL. I can write the same thing without selects as follows:
config NFS_ACL_SUPPORT
tristate
default y if (NFSD=y || NFS_FS=y) && (NFSD_ACL || NFS_ACL)
default m if (NFSD!=y && NFS_FS!=y) && (NFSD=m || NFS_FS=m) &&
(NFSD_ACL || NFS_ACL)Any thoughts?
Cheers,
Signature · 2 lines
Andreas Gruenbacher <[email protected]> SUSE Labs, SUSE LINUX AG
Hi,
Quoted 3 lines · Andreas Gruenbacher
With this configuration, menuconf gives me this message (among others):
Warning! Found recursive dependency:
NFSD_V3NFSD_ACLNFSDNFSD_V3
This is indeed a wrong positive, the patch below fixes this, but you if change your config into e.g.:
config NFSD_ACL
bool "..."
depends on NFSD_V3
select NFS_ACL_SUPPORT if NFSD
you avoid the warning and it does the same.
Quoted 8 lines
In my understanding, the select statement does not cause a dependency of NFSD on
NFSD_ACL. I can write the same thing without selects as follows:config
NFS_ACL_SUPPORTtristate default y if (NFSD=y || NFS_FS=y) && (NFSD_ACL || NFS_ACL) default m if (NFSD!=y && NFS_FS!=y) && (NFSD=m || NFS_FS=m) && (NFSD_ACL || NFS_ACL)
Or you could also write this simpler as:
config NFS_ACL_SUPPORT
tristate default (NFSD && NFSD_ACL) || (NFS_FS && NFS_ACL)
bye, Roman
Index: scripts/kconfig/symbol.c
===================================================================
RCS file: /home/other/cvs/linux/linux-2.6/scripts/kconfig/symbol.c,v retrieving revision 1.1.1.2
kconfig/symbol.c +1 -1
@@ -706,7 +706,7 @@ struct symbol *sym_check_deps(struct sym goto out;for (prop = sym->prop; prop; prop = prop->next) { -if (prop->type ==P_CHOICE ) +if (prop->type ==P_CHOICE || prop->type ==P_SELECT )continue ; sym2 =sym_check_expr_deps (prop->visible.expr);if (sym2)
Quoted 11 lines · Roman Zippel
Hi,
Quoted 3 lines · Andreas Gruenbacher
With this configuration, menuconf gives me this message (among others):
Warning! Found recursive dependency:
NFSD_V3NFSD_ACLNFSDNFSD_V3This is indeed a wrong positive, the patch below fixes this, but you if change your config into e.g.:
Quoted 6 lines
config
NFSD_ACL
bool "..."
depends onNFSD_V3
selectNFS_ACL_SUPPORTif NFSDyou avoid the warning and it does the same.
Does it? I would assume this to limit NFS_ACL_SUPPORT to y or n depending on the value of NFSD_ACL. If should be y, m or n depending on the value of NFSD.
Quoted 5 lines
Or you could also write this simpler as:
config
NFS_ACL_SUPPORTtristate default (NFSD && NFSD_ACL) || (NFS_FS && NFS_ACL)
That's much more elegant than my "handwired" version. But I prefer
select: NFSD_ACL and NFS_ACL are in different patches; with select, the patches don't conflict with each other.
Thanks,
Signature · 2 lines
Andreas Gruenbacher <[email protected]> SUSE Labs, SUSE LINUX AG
Hi,
Quoted 10 lines · Andreas Gruenbacher
Quoted 6 lines
config
NFSD_ACL
bool "..."
depends onNFSD_V3
selectNFS_ACL_SUPPORTif NFSDyou avoid the warning and it does the same.
Does it? I would assume this to limit
NFS_ACL_SUPPORTto y or n depending on the value ofNFSD_ACL. If should be y, m or n depending on the value of NFSD.
That's what the "if NFSD" part does, it's added to the expression and so modifies how NFS_ACL_SUPPORT is selected. If you enable the debug options in xconfig you can see the generated expression, which is used to calculate the final value.
While looking at this, I noticed that a bit too much is added, the NFSD_V3 dependency is also added, but it belongs to NFSD_ACL, otherwise it can also unintentionally turn the bool into a tristate. I'll have to fix this...
bye, Roman