Skip to contentSkip to conversation

Tuner bug(?) and fix

DISCUSSION Neal Stephenson 1 participant 1 message Feb 18, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

In 2.6.2, I noticed that my modprobe.conf line for tuner "options tuner
type=2" no longer worked. It even failed with insmod "insmod tuner.ko type=2". dmesg reported

vmunix: tuner: chip found @ 0xc0
vmunix: tuner: type set to 19 (Temic PAL* auto (4006 FN5))
vmunix: tuner: type forced to 19 (Temic PAL* auto (4006 FN5)) [insmod]

I noticed that the a line had been removed from 2.6.1 and when it is added everything works again. patch attached

--- - 2004-02-17 21:53:57.000000000 -0500
+++ /usr/src/linux-2.6.2-skas/drivers/media/video/tuner.c

2004-02-17 21:39:06.000000000 -0500

@@ -1040,6 +1040,7 @@

         i2c_attach_client(client);
        if (type < TUNERS) {
+               t->type = type;
                printk("tuner: type forced to %d (%s) [insmod]\n",
                       t->type,tuners[t->type].name);
                set_type(client,type);