Skip to contentSkip to conversation

Dropping CONFIG_PM_DISK?

DISCUSSION Pavel Machek 4 participants 7 messages Feb 28, 2004 – Mar 1, 2004

lore
Share & tools
lore
#0 lore raw

Hi!

Would there be any major screaming if I tried to drop CONFIG_PM_DISK? It seems noone is maintaining it, equivalent functionality is provided by swsusp, and it is confusing users...
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#1 lore raw
Quoted 5 lines · Pavel Machek

Hi!

Would there be any major screaming if I tried to drop CONFIG_PM_DISK? It seems noone is maintaining it, equivalent functionality is provided by swsusp, and it is confusing users...

Except that pmdisk code is +/- readable, swsusp is not...

Ben.

#2 lore raw
Quoted 8 lines · Benjamin Herrenschmidt
Quoted 5 lines · Pavel Machek

Hi!

Would there be any major screaming if I tried to drop CONFIG_PM_DISK? It seems noone is maintaining it, equivalent functionality is provided by swsusp, and it is confusing users...

Except that pmdisk code is +/- readable, swsusp is not...

Would you be willing to either maintain pmdisk or (preffered) split it up and submit me pieces?

Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#3 lore raw
Quoted 5 lines
Quoted 2 lines

Except that pmdisk code is +/- readable, swsusp is not...

Would you be willing to either maintain pmdisk or (preffered) split it up and submit me pieces?

Heh, if I had time ... :)

Ben.

#4 lore raw

Hi!

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Except that pmdisk code is +/- readable, swsusp is not...

Would you be willing to either maintain pmdisk or (preffered) split it up and submit me pieces?

Heh, if I had time ... :)

Well, unless someone steps up, I guess I'll just let it bitrot, and when its broken enough, I'll attempt removal. I really do not have time to maintain two implementations...
Pavel

Signature · 2 lines
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
#5 lore raw

I'd like to work on patching it into suspend2. I'm being real slow at the moment because I'm not working on suspend much at all, but that doesn't mean I don't want to do anything :>

Regards,

Nigel

Quoted 13 lines · Pavel Machek

Hi!

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Except that pmdisk code is +/- readable, swsusp is not...

Would you be willing to either maintain pmdisk or (preffered) split it up and submit me pieces?

Heh, if I had time ... :)

Well, unless someone steps up, I guess I'll just let it bitrot, and when its broken enough, I'll attempt removal. I really do not have time to maintain two implementations...
Pavel

Signature · 2 lines
My work on Software Suspend was graciously brought to you between
October and January by LinuxFund.org.
#6 lore raw
In reply to Pavel Machek
Quoted 6 lines · Pavel Machek

Hi!

Would there be any major screaming if I tried to drop CONFIG_PM_DISK? It seems noone is maintaining it, equivalent functionality is provided by swsusp, and it is confusing users...
Pavel

Last time I tried (2.6.1) PM_DISK was the only suspend mechanism that worked on my vaio with ACPI enabled (PGC-FX701). I had not time (my humble apologies to Nigel) to make more tests, I've been swamped with a conference deadline, but I can try to help finding out the problem in the next weeks, I hope.

Romano

Signature · 2 lines
Romano Giannetti             -  Univ. Pontificia Comillas (Madrid, Spain)
Electronic Engineer - phone +34 915 422 800 ext 2416  fax +34 915 596 569