loop setup race
Subsystems (2)
PATCH 1/1 loop setup race
Hello everyone,
There's a race in loopback setup, it's easiest to trigger with one or more procs doing loopback mounts at the same time. The problem is that fs/block_dev.c:do_open() only calls bdev_set_size on the first open. Picture two procs:
proc1: mount -o loop file1 mnt1
proc2: mount -o loop file2 mnt2
proc1 proc2
open /dev/loop0 # bd_openers now 1do_open
bd_set_size(bdev, 0) # loop unbound, so bdev size is 0
open /dev/loop0 # bd_openers now 2loop_set_fd # disk capacity now correct, but
# bdev not updated mount /dev/loop0 /mnt do_open
Because bd_openers != 0 for the last do_open, bd_set_size is not called again and a size of 0 is used. This eventually leads to an oops when the loop device is unmounted, because fsync_bdev calls block_write_full_page who decides every page on the block device is outside i_size and unmaps them.
When ext2 or reiserfs try to sync a metadata buffer, we get an oops on because the buffers are no longer mapped.
The patch below changes loop_set_fd and loop_clr_fd to also manipulate the size of the block device, which fixes things for me. It might need some massaging to fit into -mm, but I think the bug is still present there.
drivers/block/loop.c +2 -0
@@ -559,6 +559,7 @@ error = -EFBIG ; goto out_putf; } +bd_set_size (bdev,(loff_t )get_capacity (disks[lo->lo_number])<<9 ); lo->old_gfp_mask =mapping_gfp_mask (mapping);mapping_set_gfp_mask (mapping, lo->old_gfp_mask & ~(__GFP_IO|__GFP_FS));
@@ -659,6 +660,7 @@memset (lo->lo_file_name,0 ,LO_NAME_SIZE );invalidate_bdev (bdev,0 );set_capacity (disks[lo->lo_number],0 ); +bd_set_size (bdev,0 );mapping_set_gfp_mask (filp->f_mapping, gfp); lo->lo_state = Lo_unbound;fput (filp);
fs/block_dev.c +2 -1
@@ -523,7 +523,7 @@EXPORT_SYMBOL (check_disk_change); -static void bd_set_size (struct block_device *bdev,loff_t size) +void bd_set_size (struct block_device *bdev,loff_t size) {unsigned bsize =bdev_hardsect_size (bdev);
@@ -536,6 +536,7 @@ bdev->bd_block_size = bsize; bdev->bd_inode->i_blkbits =blksize_bits (bsize); } +EXPORT_SYMBOL (bd_set_size);static int do_open (struct block_device *bdev,struct file *file) {
include/linux/fs.h +1 -0
@@ -1138,6 +1139,7 @@extern int register_blkdev (unsigned int ,const char *);extern int unregister_blkdev (unsigned int ,const char *);extern struct block_device *bdget (dev_t ); +extern void bd_set_size (struct block_device *,loff_t size);extern void bd_forget (struct inode *inode);extern void bdput (struct block_device *);extern int blkdev_open (struct inode *,struct file *);