OOPS when force unloading sctp with CONFIG_DEBUG_SLAB enabled
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 1 line · Andrew Morton
Some advice on this please?
This patch just went to Linus. Summary, there is a problem, their patch makes it worse, but original problem only happens with rmmod --wait.
BTW, "forced unloading of xxx causes yyy" reports pretty much have to be ignored.
Cheers,
Rusty.
Quoted 1 line
From [email protected]
From: [email protected]
To: [email protected]
Subject: [PATCH 1] Set mod->waiter Before Calling stop_machine
Name: Set mod->waiter Before Calling stop_machine
Status: Tested on 2.6.5-rc1-bk4
mod->waiter needs to be set before we try to stop the module: setting it in __try_stop_module means it gets set to the kthread, not rmmod.
Spotted by someone else, but I can't find the mail... 8(
kernel/module.c +3 -1
@@ -493,7 +493,6 @@ static inline int __try_stop_module(void }/* Mark it as dying. */ - sref->mod->waiter = current; sref->mod->state =MODULE_STATE_GOING ;return 0 ; }
@@ -588,6 +587,9 @@ sys_delete_module(const char __user *nam } } +/* Set this up before setting mod->state */ + mod->waiter = current; +/* Stop the machine so refcounts can't move and disable module. */ ret =try_stop_module (mod, flags, &forced);
Signature · 1 line
Anyone who quotes me in their signature is an idiot -- Rusty Russell