2.6.5-rc2 lots of warnings for dma_error
Subsystems (4)
2.6.5-rc2 generic build, lots of warnings for dma_error. Latest patch from
http://www.kernel.org/pub/linux/kernel/ports/ia64/v2.6/testing/cset/cset-1.1661.1.156-to-1.1668.txt.gz
makes no difference.
In file included from include/asm/pci.h:58,
from include/linux/pci.h:720,
from fs/compat_ioctl.c:58,
from arch/ia64/ia32/ia32_ioctl.c:15:include/asm-generic/pci-dma-compat.h: In function `pci_dma_error':include/asm-generic/pci-dma-compat.h:104: warning: implicit declaration of function `dma_error'
# grep DMA /build/kaos/2.6.5-rc2-kdb-v4.3-ia64/.config CONFIG_BLK_DEV_IDEDMA_PCI=y # CONFIG_BLK_DEV_IDEDMA_FORCED is not set CONFIG_IDEDMA_PCI_AUTO=y # CONFIG_IDEDMA_ONLYDISK is not set CONFIG_BLK_DEV_ADMA=y CONFIG_HPT34X_AUTODMA=y CONFIG_BLK_DEV_IDEDMA=y # CONFIG_IDEDMA_IVB is not set CONFIG_IDEDMA_AUTO=y # CONFIG_DMA_NONPCI is not set
Quoted 5 lines · Keith Owens
2.6.5-rc2 generic build, lots of warnings for
dma_error. Latest patch from
http://www.kernel.org/pub/linux/kernel/ports/ia64/v2.6/testing/cset/cset-1.1661.1.156-to-1.1668.txt.gz
makes no difference.
Quoted 7 lines
In file included from
include/asm/pci.h:58,from include/linux/pci.h:720, from fs/compat_ioctl.c:58, from arch/ia64/ia32/ia32_ioctl.c:15:
include/asm-generic/pci-dma-compat.h: In function `pci_dma_error':include/asm-generic/pci-dma-compat.h:104: warning: implicit declaration of function `dma_error'
Yes, sorry, that patch was, umm, a little less complete than I had believed.
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
---
25-akpm/arch/ia64/lib/swiotlb.c | 7 +++++++ 25-akpm/arch/ia64/sn/io/machvec/pci_dma.c | 13 +++++++++++++ 25-akpm/include/asm-ia64/dma-mapping.h | 1 + 25-akpm/include/asm-ia64/machvec.h | 8 ++++++++ 25-akpm/include/asm-ia64/machvec_sn2.h | 2 ++ include/asm-ia64/machvec_hpzx1.h | 0 6 files changed, 31 insertions(+)
include/asm-ia64/dma-mapping.h renamed from include/asm-ia64/dma-mapping.h~ia64-dma_error-fix +1 -0
@@ -18,6 +18,7 @@#define dma_sync_sg_for_cpu platform_dma_sync_sg_for_cpu#define dma_sync_single_for_device platform_dma_sync_single_for_device#define dma_sync_sg_for_device platform_dma_sync_sg_for_device +#define dma_error platform_dma_error#define dma_map_page (dev, pg, off, size, dir) \ dma_map_single(dev, page_address(pg) + (off), (size), (dir))
include/asm-ia64/machvec.h renamed from include/asm-ia64/machvec.h~ia64-dma_error-fix +8 -0
@@ -46,6 +46,7 @@ typedef void ia64_mv_dma_sync_single_fortypedef void ia64_mv_dma_sync_sg_for_cpu (struct device *,struct scatterlist *,int ,int );typedef void ia64_mv_dma_sync_single_for_device (struct device *,dma_addr_t ,size_t ,int );typedef void ia64_mv_dma_sync_sg_for_device (struct device *,struct scatterlist *,int ,int ); +typedef int ia64_mv_dma_error (dma_addr_t dma_addr);typedef int ia64_mv_dma_supported (struct device *,u64 );/*
@@ -110,6 +111,7 @@ extern void machvec_memory_fence (void);# define platform_dma_sync_sg_for_cpu ia64_mv.dma_sync_sg_for_cpu# define platform_dma_sync_single_for_device ia64_mv.dma_sync_single_for_device# define platform_dma_sync_sg_for_device ia64_mv.dma_sync_sg_for_device +# define platform_dma_error ia64_mv.dma_error# define platform_dma_supported ia64_mv.dma_supported# define platform_irq_desc ia64_mv.irq_desc# define platform_irq_to_vector ia64_mv.irq_to_vector
@@ -158,6 +160,7 @@ struct ia64_machine_vector {ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; + ia64_mv_dma_error *dma_error ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
@@ -202,6 +205,7 @@ struct ia64_machine_vector { platform_dma_sync_sg_for_cpu, \ platform_dma_sync_single_for_device, \ platform_dma_sync_sg_for_device, \ + platform_dma_error, \ platform_dma_supported, \ platform_irq_desc, \ platform_irq_to_vector, \
@@ -243,6 +247,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu swiotlb_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device swiotlb_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device swiotlb_sync_sg_for_device; +extern ia64_mv_dma_error swiotlb_dma_error;extern ia64_mv_dma_supported swiotlb_dma_supported;/*
@@ -312,6 +317,9 @@ extern ia64_mv_dma_supported swiotlb_dm#ifndef platform_dma_sync_sg_for_device# define platform_dma_sync_sg_for_device swiotlb_sync_sg_for_device#endif +#ifndef platform_dma_error +# define platform_dma_error swiotlb_dma_error +#endif #ifndef platform_dma_supported# define platform_dma_supported swiotlb_dma_supported#endif
diff -puN include/asm-ia64/machvec_hpzx1.h~ia64-dma_error-fix include/asm-ia64/machvec_hpzx1.h
include/asm-ia64/machvec_sn2.h renamed from include/asm-ia64/machvec_sn2.h~ia64-dma_error-fix +2 -0
@@ -66,6 +66,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device sn_dma_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device sn_dma_sync_sg_for_device; +extern ia64_mv_dma_error sn_dma_error;extern ia64_mv_dma_supported sn_dma_supported;/*
@@ -111,6 +112,7 @@ extern ia64_mv_dma_supported sn_dma_sup#define platform_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu#define platform_dma_sync_single_for_device sn_dma_sync_single_for_device#define platform_dma_sync_sg_for_device sn_dma_sync_sg_for_device +#define platform_dma_error sn_dma_error#define platform_dma_supported sn_dma_supported#include <asm/sn/sn2/io.h>
arch/ia64/lib/swiotlb.c renamed from arch/ia64/lib/swiotlb.c~ia64-dma_error-fix +7 -0
@@ -498,6 +498,12 @@ swiotlb_sync_sg_for_device (struct devicsync_single (hwdev, (void *) sg->dma_address, sg->dma_length, dir); } +int +swiotlb_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/* * Return whether the given PCI device DMA address mask can be supported properly. For * example, if your device can only drive the low 24-bits during PCI bus mastering, then
@@ -518,6 +524,7 @@ EXPORT_SYMBOL(swiotlb_sync_single_for_cpEXPORT_SYMBOL (swiotlb_sync_single_for_device);EXPORT_SYMBOL (swiotlb_sync_sg_for_cpu);EXPORT_SYMBOL (swiotlb_sync_sg_for_device); +EXPORT_SYMBOL (swiotlb_dma_error);EXPORT_SYMBOL (swiotlb_alloc_coherent);EXPORT_SYMBOL (swiotlb_free_coherent);EXPORT_SYMBOL (swiotlb_dma_supported);
arch/ia64/sn/io/machvec/pci_dma.c renamed from arch/ia64/sn/io/machvec/pci_dma.c~ia64-dma_error-fix +13 -0
@@ -483,6 +483,12 @@ sn_pci_dma_sync_sg_for_device(struct pcireturn ; } +int +sn_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/** * sn_dma_supported - test a DMA mask * @hwdev: device to test
@@ -652,6 +658,13 @@ sn_dma_sync_sg_for_device(struct device }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); +void +sn_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} + +EXPORT_SYMBOL (sn_dma_error);EXPORT_SYMBOL (sn_pci_unmap_single);EXPORT_SYMBOL (sn_pci_map_single);EXPORT_SYMBOL (sn_pci_dma_sync_single_for_cpu);
_
Quoted 2 lines · Andrew Morton
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
I needed the following additional patch to build the generic kernel:
arch/ia64/sn/io/machvec/pci_dma.c +1 -7
@@ -483,12 +483,6 @@return ; } -int -sn_dma_error (dma_addr_t dma_addr) -{ -return 0 ; -} -/** * sn_dma_supported - test a DMA mask * @hwdev: device to test
@@ -658,7 +652,7 @@ }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); -void +int sn_dma_error (dma_addr_t dma_addr) {return 0 ;
include/asm-ia64/machvec.h +1 -1
@@ -160,7 +160,7 @@ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; - ia64_mv_dma_error *dma_error +ia64_mv_dma_error *dma_error;ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
Quoted 2 lines · Andrew Morton
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
In addition, I needed the following patch to build the ide-cd driver because the ia64 generic target makes "dma_error" a #define.
drivers/ide/ide-cd.c +10 -10
@@ -1044,7 +1044,7 @@int ireason, len, sectors_to_transfer, nskip;struct cdrom_info *info = drive->driver_data;u8 lowcyl =0 , highcyl =0 ; -int dma = info->dma, dma_error =0 ; +int dma = info->dma, dma_err =0 ;struct request *rq =HWGROUP (drive)->rq;
@@ -1053,7 +1053,7 @@*/ if (dma) { info->dma =0 ; -if ((dma_error =HWIF (drive)->ide_dma_end (drive))) +if ((dma_err =HWIF (drive)->ide_dma_end (drive)))__ide_dma_off (drive); }
@@ -1061,7 +1061,7 @@return ide_stopped;if (dma) { -if (!dma_error) { +if (!dma_err) {ide_end_request (drive,1 , rq->nr_sectors);return ide_stopped; }else
@@ -1645,17 +1645,17 @@ {struct cdrom_info *info = drive->driver_data;struct request *rq =HWGROUP (drive)->rq; -int dma_error, dma, stat, ireason, len, thislen; +int dma_err, dma, stat, ireason, len, thislen;u8 lowcyl, highcyl;xfer_func_t *xferfunc;unsigned long flags;/* Check for errors. */ - dma_error =0 ; + dma_err =0 ; dma = info->dma;if (dma) { info->dma =0 ; - dma_error =HWIF (drive)->ide_dma_end (drive); + dma_err =HWIF (drive)->ide_dma_end (drive); }if (cdrom_decode_status (drive,0 , &stat)) {
@@ -1671,7 +1671,7 @@* using dma, transfer is complete now */ if (dma) { -if (dma_error) { +if (dma_err) {printk ("ide-cd: dma error\n" );__ide_dma_off (drive);return DRIVER (drive)->error (drive,"dma error" , stat);
@@ -1790,7 +1790,7 @@ {int stat, ireason, len, sectors_to_transfer, uptodate;struct cdrom_info *info = drive->driver_data; -int dma_error =0 , dma = info->dma; +int dma_err =0 , dma = info->dma;u8 lowcyl =0 , highcyl =0 ;struct request *rq =HWGROUP (drive)->rq;
@@ -1798,7 +1798,7 @@/* Check for errors. */ if (dma) { info->dma =0 ; -if ((dma_error =HWIF (drive)->ide_dma_end (drive))) { +if ((dma_err =HWIF (drive)->ide_dma_end (drive))) {printk ("ide-cd: write dma error\n" );__ide_dma_off (drive); }
@@ -1811,7 +1811,7 @@* using dma, transfer is complete now */ if (dma) { -if (dma_error) +if (dma_err)return DRIVER (drive)->error (drive,"dma error" , stat);ide_end_request (drive,1 , rq->nr_sectors);
Quoted 5 lines · Bjorn Helgaas
Quoted 2 lines · Andrew Morton
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
I needed the following additional patch to build the generic kernel:
And we probably want sba_iommu to have it's own dma_error routine:
arch/ia64/hp/common/sba_iommu.c +7 -0
@@ -1979,6 +1980,12 @@return ((mask &0xFFFFFFFFUL ) =0xFFFFFFFFUL ); } +int +sba_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +__setup ("nosbagart" , nosbagart); static int __init
@@ -2004,6 +2011,7 @@__setup ("sbapagesize=" ,sba_page_override); +EXPORT_SYMBOL (sba_dma_error);EXPORT_SYMBOL (sba_map_single);EXPORT_SYMBOL (sba_unmap_single);EXPORT_SYMBOL (sba_map_sg);
include/asm-ia64/machvec_hpzx1.h +2 -0
@@ -9,6 +9,7 @@extern ia64_mv_dma_map_sg sba_map_sg;extern ia64_mv_dma_unmap_sg sba_unmap_sg;extern ia64_mv_dma_supported sba_dma_supported; +extern ia64_mv_dma_error sba_dma_error;/* * This stuff has dual use!
@@ -31,5 +32,6 @@#define platform_dma_sync_single_for_device ((ia64_mv_dma_sync_single_for_device *) machvec_memory_fence)#define platform_dma_sync_sg_for_device ((ia64_mv_dma_sync_sg_for_device *) machvec_memory_fence)#define platform_dma_supported sba_dma_supported +#define platform_dma_error sba_dma_error#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
Quoted 11 lines · Bjorn Helgaas
Quoted 2 lines · Andrew Morton
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
In addition, I needed the following patch to build the ide-cd driver because the ia64 generic target makes "
dma_error" a #define.diff -u -ur
2.6-mm/drivers/ide/ide-cd.c2.6/drivers/ide/ide-cd.c
drivers/ide/ide-cd.c line 1047
Quoted 5 lines
drivers/ide/ide-cd.c +1
-1@@ -1044,7 +1044,7 @@int ireason, len, sectors_to_transfer, nskip;struct cdrom_info *info = drive->driver_data;u8 lowcyl =0 , highcyl =0 ; -int dma = info->dma, dma_error =0 ; +int dma = info->dma, dma_err =0 ;
This is really silly imho, make ia64 generic target cut down on it's name space polution instead then.
Signature · 1 line
Jens Axboe
Quoted 5 lines · Jens Axboe
Quoted 2 lines
- int dma =
info->dma,dma_error= 0;
+ int dma =info->dma,dma_err= 0;This is really silly imho, make ia64 generic target cut down on it's name space polution instead then.
Yeah, that's fair enough, but I'm not ready to sign up for that. Maybe someone else more expert than I in the machvecs will.
Quoted 7 lines · Bjorn Helgaas
Quoted 2 lines · Andrew Morton
This adds the necessary stubs for ia64 and builds OK with my config, but it needs a double-check.
In addition, I needed the following patch to build the ide-cd driver because the ia64 generic target makes "
dma_error" a #define.
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
25-akpm/arch/ia64/hp/common/sba_iommu.c | 7 +++++++ 25-akpm/arch/ia64/lib/swiotlb.c | 7 +++++++ 25-akpm/arch/ia64/sn/io/machvec/pci_dma.c | 7 +++++++ 25-akpm/drivers/ide/ide-cd.c | 20 ++++++++++---------- 25-akpm/include/asm-ia64/dma-mapping.h | 1 + 25-akpm/include/asm-ia64/machvec.h | 8 ++++++++ 25-akpm/include/asm-ia64/machvec_hpzx1.h | 2 ++ 25-akpm/include/asm-ia64/machvec_sn2.h | 2 ++ 8 files changed, 44 insertions(+), 10 deletions(-)
include/asm-ia64/dma-mapping.h renamed from include/asm-ia64/dma-mapping.h~ia64-dma_error-fix +1 -0
@@ -18,6 +18,7 @@#define dma_sync_sg_for_cpu platform_dma_sync_sg_for_cpu#define dma_sync_single_for_device platform_dma_sync_single_for_device#define dma_sync_sg_for_device platform_dma_sync_sg_for_device +#define dma_error platform_dma_error#define dma_map_page (dev, pg, off, size, dir) \ dma_map_single(dev, page_address(pg) + (off), (size), (dir))
include/asm-ia64/machvec.h renamed from include/asm-ia64/machvec.h~ia64-dma_error-fix +8 -0
@@ -46,6 +46,7 @@ typedef void ia64_mv_dma_sync_single_fortypedef void ia64_mv_dma_sync_sg_for_cpu (struct device *,struct scatterlist *,int ,int );typedef void ia64_mv_dma_sync_single_for_device (struct device *,dma_addr_t ,size_t ,int );typedef void ia64_mv_dma_sync_sg_for_device (struct device *,struct scatterlist *,int ,int ); +typedef int ia64_mv_dma_error (dma_addr_t dma_addr);typedef int ia64_mv_dma_supported (struct device *,u64 );/*
@@ -110,6 +111,7 @@ extern void machvec_memory_fence (void);# define platform_dma_sync_sg_for_cpu ia64_mv.dma_sync_sg_for_cpu# define platform_dma_sync_single_for_device ia64_mv.dma_sync_single_for_device# define platform_dma_sync_sg_for_device ia64_mv.dma_sync_sg_for_device +# define platform_dma_error ia64_mv.dma_error# define platform_dma_supported ia64_mv.dma_supported# define platform_irq_desc ia64_mv.irq_desc# define platform_irq_to_vector ia64_mv.irq_to_vector
@@ -158,6 +160,7 @@ struct ia64_machine_vector {ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; +ia64_mv_dma_error *dma_error;ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
@@ -202,6 +205,7 @@ struct ia64_machine_vector { platform_dma_sync_sg_for_cpu, \ platform_dma_sync_single_for_device, \ platform_dma_sync_sg_for_device, \ + platform_dma_error, \ platform_dma_supported, \ platform_irq_desc, \ platform_irq_to_vector, \
@@ -243,6 +247,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu swiotlb_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device swiotlb_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device swiotlb_sync_sg_for_device; +extern ia64_mv_dma_error swiotlb_dma_error;extern ia64_mv_dma_supported swiotlb_dma_supported;/*
@@ -312,6 +317,9 @@ extern ia64_mv_dma_supported swiotlb_dm#ifndef platform_dma_sync_sg_for_device# define platform_dma_sync_sg_for_device swiotlb_sync_sg_for_device#endif +#ifndef platform_dma_error +# define platform_dma_error swiotlb_dma_error +#endif #ifndef platform_dma_supported# define platform_dma_supported swiotlb_dma_supported#endif
include/asm-ia64/machvec_hpzx1.h renamed from include/asm-ia64/machvec_hpzx1.h~ia64-dma_error-fix +2 -0
@@ -9,6 +9,7 @@ extern ia64_mv_dma_unmap_single sba_unmextern ia64_mv_dma_map_sg sba_map_sg;extern ia64_mv_dma_unmap_sg sba_unmap_sg;extern ia64_mv_dma_supported sba_dma_supported; +extern ia64_mv_dma_error sba_dma_error;/* * This stuff has dual use!
@@ -31,5 +32,6 @@ extern ia64_mv_dma_supported sba_dma_su#define platform_dma_sync_single_for_device ((ia64_mv_dma_sync_single_for_device *) machvec_memory_fence)#define platform_dma_sync_sg_for_device ((ia64_mv_dma_sync_sg_for_device *) machvec_memory_fence)#define platform_dma_supported sba_dma_supported +#define platform_dma_error sba_dma_error#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
include/asm-ia64/machvec_sn2.h renamed from include/asm-ia64/machvec_sn2.h~ia64-dma_error-fix +2 -0
@@ -66,6 +66,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device sn_dma_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device sn_dma_sync_sg_for_device; +extern ia64_mv_dma_error sn_dma_error;extern ia64_mv_dma_supported sn_dma_supported;/*
@@ -111,6 +112,7 @@ extern ia64_mv_dma_supported sn_dma_sup#define platform_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu#define platform_dma_sync_single_for_device sn_dma_sync_single_for_device#define platform_dma_sync_sg_for_device sn_dma_sync_sg_for_device +#define platform_dma_error sn_dma_error#define platform_dma_supported sn_dma_supported#include <asm/sn/sn2/io.h>
arch/ia64/lib/swiotlb.c renamed from arch/ia64/lib/swiotlb.c~ia64-dma_error-fix +7 -0
@@ -498,6 +498,12 @@ swiotlb_sync_sg_for_device (struct devicsync_single (hwdev, (void *) sg->dma_address, sg->dma_length, dir); } +int +swiotlb_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/* * Return whether the given PCI device DMA address mask can be supported properly. For * example, if your device can only drive the low 24-bits during PCI bus mastering, then
@@ -518,6 +524,7 @@ EXPORT_SYMBOL(swiotlb_sync_single_for_cpEXPORT_SYMBOL (swiotlb_sync_single_for_device);EXPORT_SYMBOL (swiotlb_sync_sg_for_cpu);EXPORT_SYMBOL (swiotlb_sync_sg_for_device); +EXPORT_SYMBOL (swiotlb_dma_error);EXPORT_SYMBOL (swiotlb_alloc_coherent);EXPORT_SYMBOL (swiotlb_free_coherent);EXPORT_SYMBOL (swiotlb_dma_supported);
arch/ia64/sn/io/machvec/pci_dma.c renamed from arch/ia64/sn/io/machvec/pci_dma.c~ia64-dma_error-fix +7 -0
@@ -652,6 +652,13 @@ sn_dma_sync_sg_for_device(struct device }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); +int +sn_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} + +EXPORT_SYMBOL (sn_dma_error);EXPORT_SYMBOL (sn_pci_unmap_single);EXPORT_SYMBOL (sn_pci_map_single);EXPORT_SYMBOL (sn_pci_dma_sync_single_for_cpu);
arch/ia64/hp/common/sba_iommu.c renamed from arch/ia64/hp/common/sba_iommu.c~ia64-dma_error-fix +7 -0
@@ -1979,6 +1979,12 @@ sba_dma_supported (struct device *dev, ureturn ((mask &0xFFFFFFFFUL ) =0xFFFFFFFFUL ); } +int +sba_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +__setup ("nosbagart" , nosbagart); static int __init
@@ -2004,6 +2010,7 @@ sba_page_override(char *str)__setup ("sbapagesize=" ,sba_page_override); +EXPORT_SYMBOL (sba_dma_error);EXPORT_SYMBOL (sba_map_single);EXPORT_SYMBOL (sba_unmap_single);EXPORT_SYMBOL (sba_map_sg);
drivers/ide/ide-cd.c renamed from drivers/ide/ide-cd.c~ia64-dma_error-fix +10 -10
@@ -1044,7 +1044,7 @@ static ide_startstop_t cdrom_read_intr (int ireason, len, sectors_to_transfer, nskip;struct cdrom_info *info = drive->driver_data;u8 lowcyl =0 , highcyl =0 ; -int dma = info->dma, dma_error =0 ; +int dma = info->dma, dma_err =0 ;struct request *rq =HWGROUP (drive)->rq;
@@ -1053,7 +1053,7 @@ static ide_startstop_t cdrom_read_intr (*/ if (dma) { info->dma =0 ; -if ((dma_error =HWIF (drive)->ide_dma_end (drive))) +if ((dma_err =HWIF (drive)->ide_dma_end (drive)))__ide_dma_off (drive); }
@@ -1061,7 +1061,7 @@ static ide_startstop_t cdrom_read_intr (return ide_stopped;if (dma) { -if (!dma_error) { +if (!dma_err) {ide_end_request (drive,1 , rq->nr_sectors);return ide_stopped; }else
@@ -1645,17 +1645,17 @@ static ide_startstop_t cdrom_newpc_intr( {struct cdrom_info *info = drive->driver_data;struct request *rq =HWGROUP (drive)->rq; -int dma_error, dma, stat, ireason, len, thislen; +int dma_err, dma, stat, ireason, len, thislen;u8 lowcyl, highcyl;xfer_func_t *xferfunc;unsigned long flags;/* Check for errors. */ - dma_error =0 ; + dma_err =0 ; dma = info->dma;if (dma) { info->dma =0 ; - dma_error =HWIF (drive)->ide_dma_end (drive); + dma_err =HWIF (drive)->ide_dma_end (drive); }if (cdrom_decode_status (drive,0 , &stat)) {
@@ -1671,7 +1671,7 @@ static ide_startstop_t cdrom_newpc_intr(* using dma, transfer is complete now */ if (dma) { -if (dma_error) { +if (dma_err) {printk ("ide-cd: dma error\n" );__ide_dma_off (drive);return DRIVER (drive)->error (drive,"dma error" , stat);
@@ -1790,7 +1790,7 @@ static ide_startstop_t cdrom_write_intr( {int stat, ireason, len, sectors_to_transfer, uptodate;struct cdrom_info *info = drive->driver_data; -int dma_error =0 , dma = info->dma; +int dma_err =0 , dma = info->dma;u8 lowcyl =0 , highcyl =0 ;struct request *rq =HWGROUP (drive)->rq;
@@ -1798,7 +1798,7 @@ static ide_startstop_t cdrom_write_intr(/* Check for errors. */ if (dma) { info->dma =0 ; -if ((dma_error =HWIF (drive)->ide_dma_end (drive))) { +if ((dma_err =HWIF (drive)->ide_dma_end (drive))) {printk ("ide-cd: write dma error\n" );__ide_dma_off (drive); }
@@ -1811,7 +1811,7 @@ static ide_startstop_t cdrom_write_intr(* using dma, transfer is complete now */ if (dma) { -if (dma_error) +if (dma_err)return DRIVER (drive)->error (drive,"dma error" , stat);ide_end_request (drive,1 , rq->nr_sectors);
_
Quoted 3 lines · Andrew Morton
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
Not to prolong the agony, but using the following asm-ia64/dma-mapping.h patch fixes the namespace pollution problem, obviating the need for the ide-cd.c patch:
=== include/asm-ia64/dma-mapping.h 1.3 vs edited ==--- 1.3/include/asm-ia64/dma-mapping.h Sat Mar 13 23:54:58 2004
+++ edited/include/asm-ia64/dma-mapping.h Mon Mar 22 14:29:43 2004
@@ -19,6 +19,12 @@
#define dma_sync_single_for_device platform_dma_sync_single_for_device
#define dma_sync_sg_for_device platform_dma_sync_sg_for_device
+/* inline function to avoid namespace pollution */ +static inline int dma_error (dma_addr_t dma_addr)
+{
+ return platform_dma_error(dma_addr);
+}
+
#define dma_map_page(dev, pg, off, size, dir) \
dma_map_single(dev, page_address(pg) + (off), (size), (dir))
#define dma_unmap_page(dev, dma_addr, size, dir) \
Quoted 9 lines · Bjorn Helgaas
Quoted 3 lines · Andrew Morton
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
Not to prolong the agony, but using the following
asm-ia64/dma-mapping.hpatch fixes the namespace pollution problem, obviating the need for theide-cd.cpatch:
OK, updated rollup:
25-akpm/arch/ia64/hp/common/sba_iommu.c | 7 +++++++ 25-akpm/arch/ia64/lib/swiotlb.c | 7 +++++++ 25-akpm/arch/ia64/sn/io/machvec/pci_dma.c | 7 +++++++ 25-akpm/include/asm-ia64/dma-mapping.h | 7 +++++++ 25-akpm/include/asm-ia64/machvec.h | 8 ++++++++ 25-akpm/include/asm-ia64/machvec_hpzx1.h | 2 ++ 25-akpm/include/asm-ia64/machvec_sn2.h | 2 ++ 7 files changed, 40 insertions(+)
arch/ia64/hp/common/sba_iommu.c renamed from arch/ia64/hp/common/sba_iommu.c~ia64-dma_error-fix +7 -0
@@ -1979,6 +1979,12 @@ sba_dma_supported (struct device *dev, ureturn ((mask &0xFFFFFFFFUL ) =0xFFFFFFFFUL ); } +int +sba_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +__setup ("nosbagart" , nosbagart); static int __init
@@ -2004,6 +2010,7 @@ sba_page_override(char *str)__setup ("sbapagesize=" ,sba_page_override); +EXPORT_SYMBOL (sba_dma_error);EXPORT_SYMBOL (sba_map_single);EXPORT_SYMBOL (sba_unmap_single);EXPORT_SYMBOL (sba_map_sg);
arch/ia64/lib/swiotlb.c renamed from arch/ia64/lib/swiotlb.c~ia64-dma_error-fix +7 -0
@@ -498,6 +498,12 @@ swiotlb_sync_sg_for_device (struct devicsync_single (hwdev, (void *) sg->dma_address, sg->dma_length, dir); } +int +swiotlb_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/* * Return whether the given PCI device DMA address mask can be supported properly. For * example, if your device can only drive the low 24-bits during PCI bus mastering, then
@@ -518,6 +524,7 @@ EXPORT_SYMBOL(swiotlb_sync_single_for_cpEXPORT_SYMBOL (swiotlb_sync_single_for_device);EXPORT_SYMBOL (swiotlb_sync_sg_for_cpu);EXPORT_SYMBOL (swiotlb_sync_sg_for_device); +EXPORT_SYMBOL (swiotlb_dma_error);EXPORT_SYMBOL (swiotlb_alloc_coherent);EXPORT_SYMBOL (swiotlb_free_coherent);EXPORT_SYMBOL (swiotlb_dma_supported);
arch/ia64/sn/io/machvec/pci_dma.c renamed from arch/ia64/sn/io/machvec/pci_dma.c~ia64-dma_error-fix +7 -0
@@ -652,6 +652,13 @@ sn_dma_sync_sg_for_device(struct device }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); +int +sn_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} + +EXPORT_SYMBOL (sn_dma_error);EXPORT_SYMBOL (sn_pci_unmap_single);EXPORT_SYMBOL (sn_pci_map_single);EXPORT_SYMBOL (sn_pci_dma_sync_single_for_cpu);
include/asm-ia64/dma-mapping.h renamed from include/asm-ia64/dma-mapping.h~ia64-dma_error-fix +7 -0
@@ -18,6 +18,13 @@#define dma_sync_sg_for_cpu platform_dma_sync_sg_for_cpu#define dma_sync_single_for_device platform_dma_sync_single_for_device#define dma_sync_sg_for_device platform_dma_sync_sg_for_device +#define dma_error platform_dma_error + +/* inline function to avoid namespace pollution */ +static inline int dma_error (dma_addr_t dma_addr) +{ +return platform_dma_error (dma_addr); +}#define dma_map_page (dev, pg, off, size, dir) \ dma_map_single(dev, page_address(pg) + (off), (size), (dir))
include/asm-ia64/machvec.h renamed from include/asm-ia64/machvec.h~ia64-dma_error-fix +8 -0
@@ -46,6 +46,7 @@ typedef void ia64_mv_dma_sync_single_fortypedef void ia64_mv_dma_sync_sg_for_cpu (struct device *,struct scatterlist *,int ,int );typedef void ia64_mv_dma_sync_single_for_device (struct device *,dma_addr_t ,size_t ,int );typedef void ia64_mv_dma_sync_sg_for_device (struct device *,struct scatterlist *,int ,int ); +typedef int ia64_mv_dma_error (dma_addr_t dma_addr);typedef int ia64_mv_dma_supported (struct device *,u64 );/*
@@ -110,6 +111,7 @@ extern void machvec_memory_fence (void);# define platform_dma_sync_sg_for_cpu ia64_mv.dma_sync_sg_for_cpu# define platform_dma_sync_single_for_device ia64_mv.dma_sync_single_for_device# define platform_dma_sync_sg_for_device ia64_mv.dma_sync_sg_for_device +# define platform_dma_error ia64_mv.dma_error# define platform_dma_supported ia64_mv.dma_supported# define platform_irq_desc ia64_mv.irq_desc# define platform_irq_to_vector ia64_mv.irq_to_vector
@@ -158,6 +160,7 @@ struct ia64_machine_vector {ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; +ia64_mv_dma_error *dma_error;ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
@@ -202,6 +205,7 @@ struct ia64_machine_vector { platform_dma_sync_sg_for_cpu, \ platform_dma_sync_single_for_device, \ platform_dma_sync_sg_for_device, \ + platform_dma_error, \ platform_dma_supported, \ platform_irq_desc, \ platform_irq_to_vector, \
@@ -243,6 +247,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu swiotlb_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device swiotlb_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device swiotlb_sync_sg_for_device; +extern ia64_mv_dma_error swiotlb_dma_error;extern ia64_mv_dma_supported swiotlb_dma_supported;/*
@@ -312,6 +317,9 @@ extern ia64_mv_dma_supported swiotlb_dm#ifndef platform_dma_sync_sg_for_device# define platform_dma_sync_sg_for_device swiotlb_sync_sg_for_device#endif +#ifndef platform_dma_error +# define platform_dma_error swiotlb_dma_error +#endif #ifndef platform_dma_supported# define platform_dma_supported swiotlb_dma_supported#endif
include/asm-ia64/machvec_hpzx1.h renamed from include/asm-ia64/machvec_hpzx1.h~ia64-dma_error-fix +2 -0
@@ -9,6 +9,7 @@ extern ia64_mv_dma_unmap_single sba_unmextern ia64_mv_dma_map_sg sba_map_sg;extern ia64_mv_dma_unmap_sg sba_unmap_sg;extern ia64_mv_dma_supported sba_dma_supported; +extern ia64_mv_dma_error sba_dma_error;/* * This stuff has dual use!
@@ -31,5 +32,6 @@ extern ia64_mv_dma_supported sba_dma_su#define platform_dma_sync_single_for_device ((ia64_mv_dma_sync_single_for_device *) machvec_memory_fence)#define platform_dma_sync_sg_for_device ((ia64_mv_dma_sync_sg_for_device *) machvec_memory_fence)#define platform_dma_supported sba_dma_supported +#define platform_dma_error sba_dma_error#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
include/asm-ia64/machvec_sn2.h renamed from include/asm-ia64/machvec_sn2.h~ia64-dma_error-fix +2 -0
@@ -66,6 +66,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device sn_dma_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device sn_dma_sync_sg_for_device; +extern ia64_mv_dma_error sn_dma_error;extern ia64_mv_dma_supported sn_dma_supported;/*
@@ -111,6 +112,7 @@ extern ia64_mv_dma_supported sn_dma_sup#define platform_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu#define platform_dma_sync_single_for_device sn_dma_sync_single_for_device#define platform_dma_sync_sg_for_device sn_dma_sync_sg_for_device +#define platform_dma_error sn_dma_error#define platform_dma_supported sn_dma_supported#include <asm/sn/sn2/io.h>
_
Quoted 5 lines · Andrew Morton
Quoted 3 lines
Not to prolong the agony, but using the following
asm-ia64/dma-mapping.hpatch fixes the namespace pollution problem, obviating the need for theide-cd.cpatch:OK, updated rollup:
Oops, I meant for my dma-mapping.h patch to be *instead of* yours. It's definitely a Monday :-)
OK, 2.5 + your updated rollup + the patch below builds and boots for me (generic_defconfig):
=== include/asm-ia64/dma-mapping.h 1.4 vs edited ==--- 1.4/include/asm-ia64/dma-mapping.h Mon Mar 22 15:09:49 2004
+++ edited/include/asm-ia64/dma-mapping.h Mon Mar 22 15:12:26 2004
@@ -18,7 +18,6 @@
#define dma_sync_sg_for_cpu platform_dma_sync_sg_for_cpu
#define dma_sync_single_for_device platform_dma_sync_single_for_device
#define dma_sync_sg_for_device platform_dma_sync_sg_for_device
-#define dma_error platform_dma_error
/* inline function to avoid namespace pollution */ static inline int dma_error (dma_addr_t dma_addr)
Quoted 6 lines · Bjorn Helgaas
Quoted 4 lines · Andrew Morton
Quoted 3 lines
Not to prolong the agony, but using the following
asm-ia64/dma-mapping.hpatch fixes the namespace pollution problem, obviating the need for theide-cd.cpatch:
Quoted 7 lines
Quoted 1 line
OK, updated rollup:
Oops, I meant for my
dma-mapping.hpatch to be *instead of* yours. It's definitely a Monday :-)OK, 2.5 + your updated rollup + the patch below builds and boots for me (
generic_defconfig):
OK. Latest version:
25-akpm/arch/ia64/hp/common/sba_iommu.c | 7 +++++++ 25-akpm/arch/ia64/lib/swiotlb.c | 7 +++++++ 25-akpm/arch/ia64/sn/io/machvec/pci_dma.c | 7 +++++++ 25-akpm/include/asm-ia64/dma-mapping.h | 6 ++++++ 25-akpm/include/asm-ia64/machvec.h | 8 ++++++++ 25-akpm/include/asm-ia64/machvec_hpzx1.h | 2 ++ 25-akpm/include/asm-ia64/machvec_sn2.h | 2 ++ 7 files changed, 39 insertions(+)
arch/ia64/hp/common/sba_iommu.c renamed from arch/ia64/hp/common/sba_iommu.c~ia64-dma_error-fix +7 -0
@@ -1979,6 +1979,12 @@ sba_dma_supported (struct device *dev, ureturn ((mask &0xFFFFFFFFUL ) =0xFFFFFFFFUL ); } +int +sba_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +__setup ("nosbagart" , nosbagart); static int __init
@@ -2004,6 +2010,7 @@ sba_page_override(char *str)__setup ("sbapagesize=" ,sba_page_override); +EXPORT_SYMBOL (sba_dma_error);EXPORT_SYMBOL (sba_map_single);EXPORT_SYMBOL (sba_unmap_single);EXPORT_SYMBOL (sba_map_sg);
arch/ia64/lib/swiotlb.c renamed from arch/ia64/lib/swiotlb.c~ia64-dma_error-fix +7 -0
@@ -498,6 +498,12 @@ swiotlb_sync_sg_for_device (struct devicsync_single (hwdev, (void *) sg->dma_address, sg->dma_length, dir); } +int +swiotlb_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/* * Return whether the given PCI device DMA address mask can be supported properly. For * example, if your device can only drive the low 24-bits during PCI bus mastering, then
@@ -518,6 +524,7 @@ EXPORT_SYMBOL(swiotlb_sync_single_for_cpEXPORT_SYMBOL (swiotlb_sync_single_for_device);EXPORT_SYMBOL (swiotlb_sync_sg_for_cpu);EXPORT_SYMBOL (swiotlb_sync_sg_for_device); +EXPORT_SYMBOL (swiotlb_dma_error);EXPORT_SYMBOL (swiotlb_alloc_coherent);EXPORT_SYMBOL (swiotlb_free_coherent);EXPORT_SYMBOL (swiotlb_dma_supported);
arch/ia64/sn/io/machvec/pci_dma.c renamed from arch/ia64/sn/io/machvec/pci_dma.c~ia64-dma_error-fix +7 -0
@@ -652,6 +652,13 @@ sn_dma_sync_sg_for_device(struct device }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); +int +sn_dma_error (dma_addr_t dma_addr) +{ +return 0 ; +} + +EXPORT_SYMBOL (sn_dma_error);EXPORT_SYMBOL (sn_pci_unmap_single);EXPORT_SYMBOL (sn_pci_map_single);EXPORT_SYMBOL (sn_pci_dma_sync_single_for_cpu);
include/asm-ia64/dma-mapping.h renamed from include/asm-ia64/dma-mapping.h~ia64-dma_error-fix +6 -0
@@ -19,6 +19,12 @@#define dma_sync_single_for_device platform_dma_sync_single_for_device#define dma_sync_sg_for_device platform_dma_sync_sg_for_device +/* inline function to avoid namespace pollution */ +static inline int dma_error (dma_addr_t dma_addr) +{ +return platform_dma_error (dma_addr); +} +#define dma_map_page (dev, pg, off, size, dir) \ dma_map_single(dev, page_address(pg) + (off), (size), (dir))#define dma_unmap_page (dev, dma_addr, size, dir) \
include/asm-ia64/machvec.h renamed from include/asm-ia64/machvec.h~ia64-dma_error-fix +8 -0
@@ -46,6 +46,7 @@ typedef void ia64_mv_dma_sync_single_fortypedef void ia64_mv_dma_sync_sg_for_cpu (struct device *,struct scatterlist *,int ,int );typedef void ia64_mv_dma_sync_single_for_device (struct device *,dma_addr_t ,size_t ,int );typedef void ia64_mv_dma_sync_sg_for_device (struct device *,struct scatterlist *,int ,int ); +typedef int ia64_mv_dma_error (dma_addr_t dma_addr);typedef int ia64_mv_dma_supported (struct device *,u64 );/*
@@ -110,6 +111,7 @@ extern void machvec_memory_fence (void);# define platform_dma_sync_sg_for_cpu ia64_mv.dma_sync_sg_for_cpu# define platform_dma_sync_single_for_device ia64_mv.dma_sync_single_for_device# define platform_dma_sync_sg_for_device ia64_mv.dma_sync_sg_for_device +# define platform_dma_error ia64_mv.dma_error# define platform_dma_supported ia64_mv.dma_supported# define platform_irq_desc ia64_mv.irq_desc# define platform_irq_to_vector ia64_mv.irq_to_vector
@@ -158,6 +160,7 @@ struct ia64_machine_vector {ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; +ia64_mv_dma_error *dma_error;ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
@@ -202,6 +205,7 @@ struct ia64_machine_vector { platform_dma_sync_sg_for_cpu, \ platform_dma_sync_single_for_device, \ platform_dma_sync_sg_for_device, \ + platform_dma_error, \ platform_dma_supported, \ platform_irq_desc, \ platform_irq_to_vector, \
@@ -243,6 +247,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu swiotlb_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device swiotlb_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device swiotlb_sync_sg_for_device; +extern ia64_mv_dma_error swiotlb_dma_error;extern ia64_mv_dma_supported swiotlb_dma_supported;/*
@@ -312,6 +317,9 @@ extern ia64_mv_dma_supported swiotlb_dm#ifndef platform_dma_sync_sg_for_device# define platform_dma_sync_sg_for_device swiotlb_sync_sg_for_device#endif +#ifndef platform_dma_error +# define platform_dma_error swiotlb_dma_error +#endif #ifndef platform_dma_supported# define platform_dma_supported swiotlb_dma_supported#endif
include/asm-ia64/machvec_hpzx1.h renamed from include/asm-ia64/machvec_hpzx1.h~ia64-dma_error-fix +2 -0
@@ -9,6 +9,7 @@ extern ia64_mv_dma_unmap_single sba_unmextern ia64_mv_dma_map_sg sba_map_sg;extern ia64_mv_dma_unmap_sg sba_unmap_sg;extern ia64_mv_dma_supported sba_dma_supported; +extern ia64_mv_dma_error sba_dma_error;/* * This stuff has dual use!
@@ -31,5 +32,6 @@ extern ia64_mv_dma_supported sba_dma_su#define platform_dma_sync_single_for_device ((ia64_mv_dma_sync_single_for_device *) machvec_memory_fence)#define platform_dma_sync_sg_for_device ((ia64_mv_dma_sync_sg_for_device *) machvec_memory_fence)#define platform_dma_supported sba_dma_supported +#define platform_dma_error sba_dma_error#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
include/asm-ia64/machvec_sn2.h renamed from include/asm-ia64/machvec_sn2.h~ia64-dma_error-fix +2 -0
@@ -66,6 +66,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device sn_dma_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device sn_dma_sync_sg_for_device; +extern ia64_mv_dma_error sn_dma_error;extern ia64_mv_dma_supported sn_dma_supported;/*
@@ -111,6 +112,7 @@ extern ia64_mv_dma_supported sn_dma_sup#define platform_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu#define platform_dma_sync_single_for_device sn_dma_sync_single_for_device#define platform_dma_sync_sg_for_device sn_dma_sync_sg_for_device +#define platform_dma_error sn_dma_error#define platform_dma_supported sn_dma_supported#include <asm/sn/sn2/io.h>
_
Quoted 4 lines · Andrew Morton
Quoted 2 lines
OK, 2.5 + your updated rollup + the patch below builds and boots for me (
generic_defconfig):OK. Latest version:
I built and booted this (generic_defconfig) with no problems.
Quoted 12 lines · Bjorn Helgaas
Quoted 3 lines · Andrew Morton
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
Not to prolong the agony, but using the following
asm-ia64/dma-mapping.hpatch fixes the namespace pollution problem, obviating the need for theide-cd.cpatch:===
include/asm-ia64/dma-mapping.h1.3 vs edited ==> ---1.3/include/asm-ia64/dma-mapping.hSat Mar 13 23:54:58 2004
+++edited/include/asm-ia64/dma-mapping.hMon Mar 22 14:29:43 2004
Review line 27
Quoted 9 lines
(quoted diff) +6
-0@@ -19,6 +19,12 @@ #define dma_sync_single_for_device platform_dma_sync_single_for_device #define dma_sync_sg_for_device platform_dma_sync_sg_for_device +/* inline function to avoid namespace pollution */ +static inline int dma_error (dma_addr_t dma_addr) +{ + return platform_dma_error(dma_addr); +} +
Yeah, apparently it's kernel wide damage already, super.
Signature · 1 line
Jens Axboe
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Bjorn Helgaas
Quoted 4 lines · Andrew Morton
Quoted 4 lines
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
Bjorn> Not to prolong the agony, but using the following Bjorn> asm-ia64/dma-mapping.h patch fixes the namespace pollution Bjorn> problem, obviating the need for the ide-cd.c patch:
But let's put the blame where it belongs: the name space was "polluted" by introducing dma_error(). It certainly must be legal to implement basic APIs using macros.
--david
Quoted 9 lines · David Mosberger
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines · Bjorn Helgaas
Quoted 4 lines · Andrew Morton
Quoted 4 lines
gack, what a fiasco.
Here's a new patch which includes everyone's 2000 millicents' worth:
Quoted 7 lines
Bjorn> Not to prolong the agony, but using the following Bjorn>
asm-ia64/dma-mapping.hpatch fixes the namespace pollution Bjorn> problem, obviating the need for theide-cd.cpatch:But let's put the blame where it belongs: the name space was "polluted" by introducing
dma_error(). It certainly must be legal to implement basic APIs using macros.
yes, perhaps it's not too late to change it. Anton, what will this break?
---
25-akpm/Documentation/DMA-API.txt | 6 +++--- 25-akpm/Documentation/DMA-mapping.txt | 4 ++-- 25-akpm/include/asm-generic/dma-mapping.h | 4 ++-- 25-akpm/include/asm-generic/pci-dma-compat.h | 4 ++-- 25-akpm/include/asm-i386/dma-mapping.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
Documentation/DMA-API.txt renamed from Documentation/DMA-API.txt~rename-dma_error +3 -3
@@ -279,14 +279,14 @@ recommended that you never use these unl cache width is. int -dma_error(dma_addr_t dma_addr) +dma_mapping_error(dma_addr_t dma_addr) int -pci_dma_error(dma_addr_t dma_addr) +pci_dma_mapping_error(dma_addr_t dma_addr) In some circumstances dma_map_single and dma_map_page will fail to create a mapping. A driver can check for these errors by testing the returned -dma address with dma_error(). A non zero return value means the mapping +dma address with dma_mapping_error(). A non zero return value means the mapping could not be created and the driver should take appropriate action (eg reduce current DMA mapping usage or delay and try again later).
Documentation/DMA-mapping.txt renamed from Documentation/DMA-mapping.txt~rename-dma_error +2 -2
@@ -850,12 +850,12 @@ failure can be determined by: - checking if pci_alloc_consistent returns NULL or pci_map_sg returns 0 - checking the returned dma_addr_t of pci_map_single and pci_map_page - by using pci_dma_error(): + by using pci_dma_mapping_error(): dma_addr_t dma_handle; dma_handle = pci_map_single(dev, addr, size, direction); - if (pci_dma_error(dma_handle)) { + if (pci_dma_mapping_error(dma_handle)) { /* * reduce current DMA mapping usage, * delay and try again later or
include/asm-generic/dma-mapping.h renamed from include/asm-generic/dma-mapping.h~rename-dma_error +2 -2
@@ -141,9 +141,9 @@ dma_sync_sg_for_device(struct device *de }static inline int -dma_error (dma_addr_t dma_addr) +dma_mapping_error (dma_addr_t dma_addr) { -return pci_dma_error (dma_addr); +return pci_dma_mapping_error (dma_addr); }/* Now for the API extensions over the pci_ one */
include/asm-generic/pci-dma-compat.h renamed from include/asm-generic/pci-dma-compat.h~rename-dma_error +2 -2
@@ -99,9 +99,9 @@ pci_dma_sync_sg_for_device(struct pci_de }static inline int -pci_dma_error (dma_addr_t dma_addr) +pci_dma_mapping_error (dma_addr_t dma_addr) { -return dma_error (dma_addr); +return dma_mapping_error (dma_addr); }#endif
include/asm-i386/dma-mapping.h renamed from include/asm-i386/dma-mapping.h~rename-dma_error +1 -1
@@ -111,7 +111,7 @@ dma_sync_sg_for_device(struct device *de }static inline int -dma_error (dma_addr_t dma_addr) +dma_mapping_error (dma_addr_t dma_addr) {return 0 ; }
_
Quoted 6 lines · Andrew Morton
Quoted 4 lines
But let's put the blame where it belongs: the name space was "polluted" by introducing
dma_error(). It certainly must be legal to implement basic APIs using macros.yes, perhaps it's not too late to change it. Anton, what will this break?
Here's a completer patch. I'll submit this I think.
We're getting namespace collisions from the new dma_error(). Rename it to dma_mapping_error().
---
25-akpm/Documentation/DMA-API.txt | 6 +++--- 25-akpm/Documentation/DMA-mapping.txt | 4 ++-- 25-akpm/include/asm-generic/dma-mapping.h | 4 ++-- 25-akpm/include/asm-generic/pci-dma-compat.h | 4 ++-- 25-akpm/include/asm-i386/dma-mapping.h | 2 +- 25-akpm/include/asm-ppc64/pci.h | 2 +- 25-akpm/include/asm-sparc64/pci.h | 2 +- 7 files changed, 12 insertions(+), 12 deletions(-)
Documentation/DMA-API.txt renamed from Documentation/DMA-API.txt~rename-dma_error +3 -3
@@ -279,14 +279,14 @@ recommended that you never use these unl cache width is. int -dma_error(dma_addr_t dma_addr) +dma_mapping_error(dma_addr_t dma_addr) int -pci_dma_error(dma_addr_t dma_addr) +pci_dma_mapping_error(dma_addr_t dma_addr) In some circumstances dma_map_single and dma_map_page will fail to create a mapping. A driver can check for these errors by testing the returned -dma address with dma_error(). A non zero return value means the mapping +dma address with dma_mapping_error(). A non zero return value means the mapping could not be created and the driver should take appropriate action (eg reduce current DMA mapping usage or delay and try again later).
Documentation/DMA-mapping.txt renamed from Documentation/DMA-mapping.txt~rename-dma_error +2 -2
@@ -850,12 +850,12 @@ failure can be determined by: - checking if pci_alloc_consistent returns NULL or pci_map_sg returns 0 - checking the returned dma_addr_t of pci_map_single and pci_map_page - by using pci_dma_error(): + by using pci_dma_mapping_error(): dma_addr_t dma_handle; dma_handle = pci_map_single(dev, addr, size, direction); - if (pci_dma_error(dma_handle)) { + if (pci_dma_mapping_error(dma_handle)) { /* * reduce current DMA mapping usage, * delay and try again later or
include/asm-generic/dma-mapping.h renamed from include/asm-generic/dma-mapping.h~rename-dma_error +2 -2
@@ -141,9 +141,9 @@ dma_sync_sg_for_device(struct device *de }static inline int -dma_error (dma_addr_t dma_addr) +dma_mapping_error (dma_addr_t dma_addr) { -return pci_dma_error (dma_addr); +return pci_dma_mapping_error (dma_addr); }/* Now for the API extensions over the pci_ one */
include/asm-generic/pci-dma-compat.h renamed from include/asm-generic/pci-dma-compat.h~rename-dma_error +2 -2
@@ -99,9 +99,9 @@ pci_dma_sync_sg_for_device(struct pci_de }static inline int -pci_dma_error (dma_addr_t dma_addr) +pci_dma_mapping_error (dma_addr_t dma_addr) { -return dma_error (dma_addr); +return dma_mapping_error (dma_addr); }#endif
include/asm-i386/dma-mapping.h renamed from include/asm-i386/dma-mapping.h~rename-dma_error +1 -1
@@ -111,7 +111,7 @@ dma_sync_sg_for_device(struct device *de }static inline int -dma_error (dma_addr_t dma_addr) +dma_mapping_error (dma_addr_t dma_addr) {return 0 ; }
include/asm-ppc64/pci.h renamed from include/asm-ppc64/pci.h~rename-dma_error +1 -1
@@ -170,7 +170,7 @@ static inline int pci_dac_dma_supported( }#define PCI_DMA_ERROR_CODE (~(dma_addr_t)0x0) -static inline int pci_dma_error (dma_addr_t dma_addr) +static inline int pci_dma_mapping_error (dma_addr_t dma_addr) {return (dma_addr =PCI_DMA_ERROR_CODE ); }
include/asm-sparc64/pci.h renamed from include/asm-sparc64/pci.h~rename-dma_error +1 -1
@@ -215,7 +215,7 @@ pci_dac_dma_sync_single_for_device(struc#define PCI_DMA_ERROR_CODE (~(dma_addr_t)0x0) -static inline int pci_dma_error (dma_addr_t dma_addr) +static inline int pci_dma_mapping_error (dma_addr_t dma_addr) {return (dma_addr =PCI_DMA_ERROR_CODE ); }
_
Quoted 7 lines · Andrew Morton
Quoted 5 lines · Andrew Morton
Quoted 4 lines
But let's put the blame where it belongs: the name space was "polluted" by introducing
dma_error(). It certainly must be legal to implement basic APIs using macros.
Quoted 9 lines
Quoted 1 line
yes, perhaps it's not too late to change it. Anton, what will this break?
Here's a completer patch. I'll submit this I think.
We're getting namespace collisions from the new
dma_error(). Rename it todma_mapping_error().
Updated ia64 patch:
25-akpm/arch/ia64/hp/common/sba_iommu.c | 7 +++++++ 25-akpm/arch/ia64/lib/swiotlb.c | 7 +++++++ 25-akpm/arch/ia64/sn/io/machvec/pci_dma.c | 7 +++++++ 25-akpm/include/asm-ia64/dma-mapping.h | 6 ++++++ 25-akpm/include/asm-ia64/machvec.h | 8 ++++++++ 25-akpm/include/asm-ia64/machvec_hpzx1.h | 2 ++ 25-akpm/include/asm-ia64/machvec_sn2.h | 2 ++ 7 files changed, 39 insertions(+)
arch/ia64/hp/common/sba_iommu.c renamed from arch/ia64/hp/common/sba_iommu.c~ia64-dma_mapping_error-fix +7 -0
@@ -1979,6 +1979,12 @@ sba_dma_supported (struct device *dev, ureturn ((mask &0xFFFFFFFFUL ) =0xFFFFFFFFUL ); } +int +sba_dma_mapping_error (dma_addr_t dma_addr) +{ +return 0 ; +} +__setup ("nosbagart" , nosbagart); static int __init
@@ -2004,6 +2010,7 @@ sba_page_override(char *str)__setup ("sbapagesize=" ,sba_page_override); +EXPORT_SYMBOL (sba_dma_mapping_error);EXPORT_SYMBOL (sba_map_single);EXPORT_SYMBOL (sba_unmap_single);EXPORT_SYMBOL (sba_map_sg);
arch/ia64/lib/swiotlb.c renamed from arch/ia64/lib/swiotlb.c~ia64-dma_mapping_error-fix +7 -0
@@ -498,6 +498,12 @@ swiotlb_sync_sg_for_device (struct devicsync_single (hwdev, (void *) sg->dma_address, sg->dma_length, dir); } +int +swiotlb_dma_mapping_error (dma_addr_t dma_addr) +{ +return 0 ; +} +/* * Return whether the given PCI device DMA address mask can be supported properly. For * example, if your device can only drive the low 24-bits during PCI bus mastering, then
@@ -518,6 +524,7 @@ EXPORT_SYMBOL(swiotlb_sync_single_for_cpEXPORT_SYMBOL (swiotlb_sync_single_for_device);EXPORT_SYMBOL (swiotlb_sync_sg_for_cpu);EXPORT_SYMBOL (swiotlb_sync_sg_for_device); +EXPORT_SYMBOL (swiotlb_dma_mapping_error);EXPORT_SYMBOL (swiotlb_alloc_coherent);EXPORT_SYMBOL (swiotlb_free_coherent);EXPORT_SYMBOL (swiotlb_dma_supported);
arch/ia64/sn/io/machvec/pci_dma.c renamed from arch/ia64/sn/io/machvec/pci_dma.c~ia64-dma_mapping_error-fix +7 -0
@@ -652,6 +652,13 @@ sn_dma_sync_sg_for_device(struct device }EXPORT_SYMBOL (sn_dma_sync_sg_for_device); +int +sn_dma_mapping_error (dma_addr_t dma_addr) +{ +return 0 ; +} + +EXPORT_SYMBOL (sn_dma_mapping_error);EXPORT_SYMBOL (sn_pci_unmap_single);EXPORT_SYMBOL (sn_pci_map_single);EXPORT_SYMBOL (sn_pci_dma_sync_single_for_cpu);
include/asm-ia64/dma-mapping.h renamed from include/asm-ia64/dma-mapping.h~ia64-dma_mapping_error-fix +6 -0
@@ -19,6 +19,12 @@#define dma_sync_single_for_device platform_dma_sync_single_for_device#define dma_sync_sg_for_device platform_dma_sync_sg_for_device +/* inline function to avoid namespace pollution */ +static inline int dma_mapping_error (dma_addr_t dma_addr) +{ +return platform_dma_mapping_error (dma_addr); +} +#define dma_map_page (dev, pg, off, size, dir) \ dma_map_single(dev, page_address(pg) + (off), (size), (dir))#define dma_unmap_page (dev, dma_addr, size, dir) \
include/asm-ia64/machvec.h renamed from include/asm-ia64/machvec.h~ia64-dma_mapping_error-fix +8 -0
@@ -46,6 +46,7 @@ typedef void ia64_mv_dma_sync_single_fortypedef void ia64_mv_dma_sync_sg_for_cpu (struct device *,struct scatterlist *,int ,int );typedef void ia64_mv_dma_sync_single_for_device (struct device *,dma_addr_t ,size_t ,int );typedef void ia64_mv_dma_sync_sg_for_device (struct device *,struct scatterlist *,int ,int ); +typedef int ia64_mv_dma_mapping_error (dma_addr_t dma_addr);typedef int ia64_mv_dma_supported (struct device *,u64 );/*
@@ -110,6 +111,7 @@ extern void machvec_memory_fence (void);# define platform_dma_sync_sg_for_cpu ia64_mv.dma_sync_sg_for_cpu# define platform_dma_sync_single_for_device ia64_mv.dma_sync_single_for_device# define platform_dma_sync_sg_for_device ia64_mv.dma_sync_sg_for_device +# define platform_dma_mapping_error ia64_mv.dma_mapping_error# define platform_dma_supported ia64_mv.dma_supported# define platform_irq_desc ia64_mv.irq_desc# define platform_irq_to_vector ia64_mv.irq_to_vector
@@ -158,6 +160,7 @@ struct ia64_machine_vector {ia64_mv_dma_sync_sg_for_cpu *dma_sync_sg_for_cpu;ia64_mv_dma_sync_single_for_device *dma_sync_single_for_device;ia64_mv_dma_sync_sg_for_device *dma_sync_sg_for_device; +ia64_mv_dma_mapping_error *dma_mapping_error;ia64_mv_dma_supported *dma_supported;ia64_mv_irq_desc *irq_desc;ia64_mv_irq_to_vector *irq_to_vector;
@@ -202,6 +205,7 @@ struct ia64_machine_vector { platform_dma_sync_sg_for_cpu, \ platform_dma_sync_single_for_device, \ platform_dma_sync_sg_for_device, \ + platform_dma_mapping_error, \ platform_dma_supported, \ platform_irq_desc, \ platform_irq_to_vector, \
@@ -243,6 +247,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu swiotlb_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device swiotlb_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device swiotlb_sync_sg_for_device; +extern ia64_mv_dma_mapping_error swiotlb_dma_mapping_error;extern ia64_mv_dma_supported swiotlb_dma_supported;/*
@@ -312,6 +317,9 @@ extern ia64_mv_dma_supported swiotlb_dm#ifndef platform_dma_sync_sg_for_device# define platform_dma_sync_sg_for_device swiotlb_sync_sg_for_device#endif +#ifndef platform_dma_mapping_error +# define platform_dma_mapping_error swiotlb_dma_mapping_error +#endif #ifndef platform_dma_supported# define platform_dma_supported swiotlb_dma_supported#endif
include/asm-ia64/machvec_hpzx1.h renamed from include/asm-ia64/machvec_hpzx1.h~ia64-dma_mapping_error-fix +2 -0
@@ -9,6 +9,7 @@ extern ia64_mv_dma_unmap_single sba_unmextern ia64_mv_dma_map_sg sba_map_sg;extern ia64_mv_dma_unmap_sg sba_unmap_sg;extern ia64_mv_dma_supported sba_dma_supported; +extern ia64_mv_dma_mapping_error sba_dma_mapping_error;/* * This stuff has dual use!
@@ -31,5 +32,6 @@ extern ia64_mv_dma_supported sba_dma_su#define platform_dma_sync_single_for_device ((ia64_mv_dma_sync_single_for_device *) machvec_memory_fence)#define platform_dma_sync_sg_for_device ((ia64_mv_dma_sync_sg_for_device *) machvec_memory_fence)#define platform_dma_supported sba_dma_supported +#define platform_dma_mapping_error sba_dma_mapping_error#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
include/asm-ia64/machvec_sn2.h renamed from include/asm-ia64/machvec_sn2.h~ia64-dma_mapping_error-fix +2 -0
@@ -66,6 +66,7 @@ extern ia64_mv_dma_sync_single_for_cpu sextern ia64_mv_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu;extern ia64_mv_dma_sync_single_for_device sn_dma_sync_single_for_device;extern ia64_mv_dma_sync_sg_for_device sn_dma_sync_sg_for_device; +extern ia64_mv_dma_mapping_error sn_dma_mapping_error;extern ia64_mv_dma_supported sn_dma_supported;/*
@@ -111,6 +112,7 @@ extern ia64_mv_dma_supported sn_dma_sup#define platform_dma_sync_sg_for_cpu sn_dma_sync_sg_for_cpu#define platform_dma_sync_single_for_device sn_dma_sync_single_for_device#define platform_dma_sync_sg_for_device sn_dma_sync_sg_for_device +#define platform_dma_mapping_error sn_dma_mapping_error#define platform_dma_supported sn_dma_supported#include <asm/sn/sn2/io.h>
_
Quoted 2 lines
yes, perhaps it's not too late to change it. Anton, what will this break?
pci_dma_error came from x86-64, and dma_error was the natural counterpart. Due to the conflicts in ide-cd.c I guess we should change it.
Anton
Quoted 4 lines · Andrew Morton
Quoted 2 lines
We're getting namespace collisions from the new
dma_error(). Rename it todma_mapping_error().Updated ia64 patch:
I verified that current linux-2.5 BK + this patch builds and boots OK (generic_defconfig), FWIW.
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Bjorn Helgaas
Quoted 4 lines · Andrew Morton
Quoted 4 lines
Quoted 2 lines
We're getting namespace collisions from the new
dma_error(). Rename it todma_mapping_error().Updated ia64 patch:
Bjorn> I verified that current linux-2.5 BK + this patch builds and boots OK Bjorn> (generic_defconfig), FWIW.
I already checked in a slightly modified version of Andrew's patch into to to-linus-2.5 repo. The modification was to avoid the needless inline-function in the machvec_hpzx1.h.
--david