Skip to contentSkip to conversation

sys_uselib in exec.c

DISCUSSION Shaya Potter 2 participants 2 messages Mar 24, 2004 VFS

lore
Share & tools
lore
#0 lore raw

the code there is (2.6.1)

125 error = __user_walk(library, LOOKUP_FOLLOW|LOOKUP_OPEN,
&nd);
126 if (error)
127 goto out;
128
129 error = -EINVAL;
130 if (!S_ISREG(nd.dentry->d_inode->i_mode))
131 goto exit;
132
133 error = permission(nd.dentry->d_inode, MAY_READ | MAY_EXEC,
&nd);
134 if (error)
135 goto exit;
136

137         file = dentry_open(nd.dentry, nd.mnt, O_RDONLY);
138         error = PTR_ERR(file);
139         if (IS_ERR(file))

140 goto out;

where exit does a path_release(&nd) and return's error while out just returns error.

if dentry_open fails, we don't call path_release(&nd). Is this correct?

thanks,

shaya

#1 lore raw
Quoted 19 lines · Shaya Potter

the code there is (2.6.1)

125 error = __user_walk(library, LOOKUP_FOLLOW|LOOKUP_OPEN,
&nd);
126 if (error)
127 goto out;
128
129 error = -EINVAL;
130 if (!S_ISREG(nd.dentry->d_inode->i_mode))
131 goto exit;
132
133 error = permission(nd.dentry->d_inode, MAY_READ | MAY_EXEC,
&nd);
134 if (error)
135 goto exit;
136

137         file = dentry_open(nd.dentry, nd.mnt, O_RDONLY);
138         error = PTR_ERR(file);
139         if (IS_ERR(file))
Quoted 6 lines

140 goto out;

where exit does a path_release(&nd) and return's error while out just returns error.

if dentry_open fails, we don't call path_release(&nd). Is this correct?

dentry_open, cleans up dentry and mnt if it has to return error..

Maneesh

Signature · 6 lines
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: [email protected]
Phone: 91-80-25044999 Fax: 91-80-25268553
T/L : 9243696