various linux kernel devtools : device handling/memory mapping/profiling/etc
Quoted 3 lines · Greg KH
I don't see anything in there that will work properly for udev. Am I just missing the code somewhere? Remember, for udev to work, you have to create stuff in sysfs, which I don't see this code doing.
indeed, automatic creation of the device files is not yet incorporated under udev, but at least it then reverts back to the oldstyle (mknod) device file system, right? That's a work in progress as my systems don't actually use udev just yet.
Quoted 4 lines
Ick, you are using
pci_find_device()which is racy, depreciated, and does not play nice with the rest of the kernel. Yes, it's the lowest common denominater accross 2.2, 2.4, and 2.6, but please don't sink to that level if you don't have to. For 2.6 it's just not acceptable.
hmm, really? thanks for the tip. I basically looked at O'Reilly's book when I coded that. Do you have a quick alternative for me to use?
Quoted 6 lines
I agree that at times the current kernel driver api learning curve is a bit steep. But people are working to reduce that curve where they can, and it's one of my main priorities for 2.7. Any help and suggestions that you might have in that area are greatly appreciated.
perhaps some of this code (when cleaned up) can serve as a guide. I was actually wondering when a 2.7 release was scheduled.
Thanks for taking the time to look at the code,
Willem
ps: my regular smtp server stopped, so I had to copy-paste this into webmail. Therefore, the in-reply-to, etc. tags are ommitted, possibly causing a threadbreak. Sorry.
Quoted 8 lines · On Mon, Apr 05, 2004 at 09:00:22PM +0200, [email protected] wrote:
Quoted 3 lines · Greg KH
I don't see anything in there that will work properly for udev. Am I just missing the code somewhere? Remember, for udev to work, you have to create stuff in sysfs, which I don't see this code doing.
indeed, automatic creation of the device files is not yet incorporated under udev,
Huh?
Quoted 3 lines
but at least it then reverts back to the oldstyle (mknod) device file system, right? That's a work in progress as my systems don't actually use udev just yet.
I don't think you understand how udev works. Who are you thinking does the mknod of the device files? udev does it only if it sees a file called "dev" in sysfs for a device. Your wrapper does not do this at all (it could be changed to use class_simple to get it, if you so desired.)
Quoted 7 lines
Quoted 4 lines
Ick, you are using
pci_find_device()which is racy, depreciated, and does not play nice with the rest of the kernel. Yes, it's the lowest common denominater accross 2.2, 2.4, and 2.6, but please don't sink to that level if you don't have to. For 2.6 it's just not acceptable.hmm, really? thanks for the tip. I basically looked at O'Reilly's book when I coded that. Do you have a quick alternative for me to use?
pci_register_driver() as Documentation/pci.txt says to use. Works just wonderful from 2.4 to 2.6, and I think it's even been backported to work on 2.2 if you so desire.
Quoted 6 lines
Quoted 5 lines
I agree that at times the current kernel driver api learning curve is a bit steep. But people are working to reduce that curve where they can, and it's one of my main priorities for 2.7. Any help and suggestions that you might have in that area are greatly appreciated.
perhaps some of this code (when cleaned up) can serve as a guide.
Well, feel free to submit portions of it as patches that clean up the current API, if you think it will help out any. In my short glance, I didn't really see anything that would help out all that much, but I'm probably missing something.
thanks,
greg k-h
Quoted 3 lines
pci_register_driver()asDocumentation/pci.txtsays to use. Works just wonderful from 2.4 to 2.6, and I think it's even been backported to work on 2.2 if you so desire.
thanks. I need something that works with a specially patched 2.3.99-pre3-rmk3-ds1 kernel for an IXP1200 network processor. Porting the original patch to 2.6 is simply too much work, so everything *must* be backward compatible to this prerelease. Hence the module template files.
Quoted 6 lines
Well, feel free to submit portions of it as patches that clean up the current API, if you think it will help out any. In my short glance, I didn't really see anything that would help out all that much, but I'm probably missing something.
AFAIK there the kernel reverts to a standard llseek implementation when this operation is left empty. How about having standard fallback behaviour for all system call handlers? That's what most of my device code is about:
implementing regular file access and memory mapping, so that device driver writers won't have to do that each time for themselves. 9 times of out 10 people will want the same .nopage handler, right? Why implement it for each driver individually?
having a generic interface does entail that drivers must export the memory region information in a standard fashion, which is why I created the dev_file_t, dev_file_open_t and dev_file_open_region_t structures (for lack of a better name). Once these were finished, adding automatic default handling was relatively straightforward. However, as you pointed out, I shouldn't have made claims about udev, as I never actually tested that.
considering udev and devfs are both still being developed (although the latter is marked `deprecated'), a single interface to the device file creation, would IMO, also be useful, as not all drivers have to be updated or filled with KERNEL_VERSION statements. The actual code is quite small (it all resides in dev.c), but even without supporting udev I have 3 different cases to deal with (2devfs+mknod).
I'm not saying my code should be used for this per se, but I do believe that these two features are so generic across drivers that they deserve to be included in the main tree somewhere. As for the rest of the package, that might not be too useful. I discussed the addition of prepending __FILE__, __FUNCTION__ and clockcycles to printk previously and someone else actually sent in a patch to printk allowing vsprintf functionality. The buffer structure is probably too heavyweight for kernel inclusion, anyway.
Willem
Signature · 2 lines
Dit bericht is gescand op virussen en andere gevaarlijke inhoud door ULCN MailScanner en het bericht lijkt schoon te zijn. This message has been scanned for viruses and dangerous content by ULCN MailScanner, and is believed to be clean.