Skip to contentSkip to conversation

Sensors (W83627HF) in Tyan S2882

DISCUSSION Applied Jean Delvare 3 participants 13 messages Apr 19, 2004 – May 5, 2004 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi Fabian,

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 line 161

Quoted 11 lines

Probably unrelated to your problem, but isn't there a typo in drivers/i2c/chips/Kconfig ? maybe patch below ?

diff -Nru drivers/i2c/chips/Kconfig.orig drivers/i2c/chips/Kconfig

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 renamed from i2c/chips/Kconfig.orig Fri Apr 16 11:12:17 2004 +0 -1
@@ -158,7 +158,7 @@
           will be called via686a.
 
 config SENSORS_W83781D
-       tristate "Winbond W83781D, W83782D, W83783S, W83627HF, Asus

AS99127F"

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 line 161

Quoted 1 line
i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 renamed from i2c/chips/Kconfig.orig Fri Apr 16 11:12:17 2004 +1 -0
+       tristate "Winbond W83781D, W83782D, W83783S, W83682HF, Asus

AS99127F"

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 line 164

Quoted 3 lines
i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 renamed from i2c/chips/Kconfig.orig Fri Apr 16 11:12:17 2004 +0 -0
         depends on I2C && EXPERIMENTAL
         select I2C_SENSOR
         help

Nice catching. However the fix is not correct. "W83627HF" is the correct name and "W83682HF" is the typo.

Care to send the correct fix to Greg? Please CC: me or the lm_sensors mailing-list so that I can enqueue the patch on my side.

Thanks.

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
#1 lore raw

Jean Delvare a écrit le 19.04.2004 17:18:

Quoted 8 lines

Hi Fabian,

Quoted 6 lines

diff -Nru drivers/i2c/chips/Kconfig.orig drivers/i2c/chips/Kconfig

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 renamed from i2c/chips/Kconfig.orig Fri Apr 16 11:12:17 2004 +0 -0
@@ -158,7 +158,7 @@
          will be called via686a.
 
Quoted 10 lines

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004

Quoted 6 lines

config SENSORS_W83781D

i2c/chips/Kconfig Mon Apr 19 15:23:48 2004 renamed from i2c/chips/Kconfig.orig Fri Apr 16 11:12:17 2004 +1 -1
-       tristate "Winbond W83781D, W83782D, W83783S, W83627HF, Asus AS99127F"
+       tristate "Winbond W83781D, W83782D, W83783S, W83682HF, Asus AS99127F"
        depends on I2C && EXPERIMENTAL
        select I2C_SENSOR
        help

Nice catching. However the fix is not correct. "W83627HF" is the correct name and "W83682HF" is the typo.

You sure ? Looks like W83627HF is handled by the 2nd one, no ?

#2 lore raw

Fabian Fenaut a écrit le 19.04.2004 17:59:

Quoted 6 lines

Jean Delvare a écrit le 19.04.2004 17:18:

Quoted 2 lines

Nice catching. However the fix is not correct. "W83627HF" is the correct name and "W83682HF" is the typo.

You sure ? Looks like W83627HF is handled by the 2nd one, no ?

... namely SENSORS_W83627HF

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 4 lines
Quoted 2 lines

Nice catching. However the fix is not correct. "W83627HF" is the correct name and "W83682HF" is the typo.

You sure ? Looks like W83627HF is handled by the 2nd one, no ?

Sure. Both drivers handle it. The w83267hf driver is prefered if the chip is found on the ISA bus, however the w83781d is the only one that can handle the chip if it's on the I2C bus.

For a list of supported chips for each driver, you can take a look at the comments in the headers of the source files.

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
#5 lore raw
Quoted 10 lines · Jean Delvare
Quoted 4 lines
Quoted 2 lines

Nice catching. However the fix is not correct. "W83627HF" is the
correct name and "W83682HF" is the typo.

You sure ? Looks like W83627HF is handled by the 2nd one, no ?

Sure. Both drivers handle it. The w83267hf driver is prefered if the
chip is found on the ISA bus, however the w83781d is the only one that can handle the chip if it's on the I2C bus.

For a list of supported chips for each driver, you can take a look at the comments in the headers of the source files.

Ok, so I suppose this is the appropriate patch :

i2c/chips/Kconfig 2004-04-19 19:10:15.000000000 +0200 renamed from i2c/chips/Kconfig.orig 2004-04-19 19:05:53.000000000 +0200 +1 -1
@@ -163,7 +163,7 @@
        select I2C_SENSOR
        help
          If you say yes here you get support for the Winbond W8378x series
-         of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+         of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
          and the similar Asus AS99127F.
 
          This driver can also be built as a module.  If so, the module

--
Fabian

#6 lore raw
Quoted 1 line

Ok, so I suppose this is the appropriate patch :

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
#7 lore raw
Quoted 5 lines · Jean Delvare
Quoted 1 line

Ok, so I suppose this is the appropriate patch :

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

Sorry, see attachment.

--
Fabian

i2c/chips/Kconfig renamed from i2c/chips/Kconfig.orig +1 -1
@@ -163,7 +163,7 @@
 	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
 	  and the similar Asus AS99127F.
 	  
 	  This driver can also be built as a module.  If so, the module
#8 lore raw
Quoted 5 lines
Quoted 3 lines

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

Sorry, see attachment.

I forgot to tell you... Patches are prefered in such a form that patch -p1 from inside the linux directory works. Yours don't. I don't think Greg will like it. That said, I don't think Greg likes patches as attachements anyway ;)

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
#9 lore raw
Quoted 11 lines · Jean Delvare
Quoted 5 lines
Quoted 3 lines

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

Sorry, see attachment.

I forgot to tell you... Patches are prefered in such a form that patch -p1 from inside the linux directory works. Yours don't. I don't think Greg will like it. That said, I don't think Greg likes patches as attachements anyway ;)

Ok, same player shoot again...

drivers/i2c/chips/Kconfig +1 -1
@@ -163,7 +163,7 @@
 	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
 	  and the similar Asus AS99127F.
 	
 	  This driver can also be built as a module.  If so, the module
#10 lore raw
Quoted 1 line

Ok, same player shoot again...

Just perfect :) Thanks.

Greg, please apply. Thanks.

Signature · 2 lines
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
#11 lore raw
In reply to Fabian Fenaut
Quoted 8 lines · Fabian Fenaut
Quoted 7 lines · Jean Delvare
Quoted 5 lines
Quoted 3 lines

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

Sorry, see attachment.

Quoted 7 lines
Quoted 4 lines

I forgot to tell you... Patches are prefered in such a form that patch -p1 from inside the linux directory works. Yours don't. I don't think Greg will like it. That said, I don't think Greg likes patches as attachements anyway ;)

Ok, same player shoot again...

For some reason this patch doesn't apply at all. Care to rediff against the next -mm release and resend it to me?

thanks,

greg k-h

#12 lore raw
Quoted 2 lines

For some reason this patch doesn't apply at all. Care to rediff against the next -mm release and resend it to me?

Actually the patch wasn't as perfect as I first thought, there were still indentation issues. I had to rework it a bit so that it would apply. Here is my modified version.

Thanks.

drivers/i2c/chips/Kconfig +1 -1
@@ -163,7 +163,7 @@
 	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
 	  and the similar Asus AS99127F.
 	  
 	  This driver can also be built as a module.  If so, the module
Signature · 2 lines
Jean Delvare
http://khali.linux-fr.org/
Applied
#13 lore raw
Quoted 6 lines · Jean Delvare
Quoted 2 lines

For some reason this patch doesn't apply at all. Care to rediff against the next -mm release and resend it to me?

Actually the patch wasn't as perfect as I first thought, there were still indentation issues. I had to rework it a bit so that it would apply. Here is my modified version.

Applied, thanks.

greg k-h