Skip to contentSkip to conversation

siginfo & 32 bits compat, what is the story ?

DISCUSSION Benjamin Herrenschmidt 2 participants 3 messages Apr 19, 2004

lore
Share & tools
lore
#0 lore raw

Hi folks !

So I've been playing around the siginfo copy code for 32 bits processes on ppc64 and found some interesting stuffs that I don't know how to fix at this point.

So I rewrote the routine copying a siginfo to a 32 bits one in a way that is similar to s390 (that's part of the ppc64 message queue patch I sent earlier). However, I just noticed we also do the opposite conversion for the sys32_rt_sigqueueinfo syscall, and we do it "the old way" (based on signal number, which is apparently incorrect).

Now my question: What to copy ? I suppose I need at least to be consistent between the 2 functions between what is done for a userland siginfo. Right now, I am not. I followed Stephen suggestions and I'm copying the whole padding after the first 3 fields in the 64 -> 32 bits copy, but the opposite conversion function that I just noticed will explicitely copy/convert some fields (si_pid, si_uid and si_int).

I looked at x86-64, and they always copy/convert those 3 fields, never copy the rest of the siginfo. I looked at s390 and they do the opposite: just copy the rest of the structure...

So I suppose I need to choose between those 2 methods and be consistent between the 32->64 and 64->32 routines, but which one ?

Ben.

#1 lore raw
Quoted 7 lines · Benjamin Herrenschmidt

So I've been playing around the siginfo copy code for 32 bits processes on ppc64 and found some interesting stuffs that I don't know how to fix at this point.

I looked at x86-64, and they always copy/convert those 3 fields, never copy the rest of the siginfo. I looked at s390 and they do the opposite: just copy the rest of the structure...

I believe the x86_64 method is correct.

It might be worth moving this compatibility code to a common place where all architectures could reference it.

Joe

#2 lore raw
Quoted 5 lines

I believe the x86_64 method is correct.

It might be worth moving this compatibility code to a common place where all architectures could reference it.

Hrm... I just heard the opposite: that is, the x86_64 code allows some cruft to communicate between 32 and 64 bits, but breaks anything that uses more than those 3 copied fields, even between 2 32 bits applications.

I'm lost, I don't know in which way to fix ppc64 at this point...

Ben.