kernel/softirq.c issues under 2.6.5
Hi all!
My 2.6.5 will not start until i applay patch bellow:
kernel/softirq.chg.c 2004-04-20 10:48:28.000000000 +0300 renamed from kernel/softirq.c 2004-04-04 06:36:47.000000000 +0300 +2 -2
@@ -409,8 +409,8 @@ static int __devinit cpu_callback(struct switch (action) { case CPU_UP_PREPARE: - BUG_ON(per_cpu(tasklet_vec, hotcpu).list); - BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list); + per_cpu(tasklet_vec, cpu).list = NULL; + per_cpu(tasklet_hi_vec, cpu).list = NULL; p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu); if (IS_ERR(p)) { printk("ksoftirqd for %i failed\n", hotcpu);
What mean that? Mr. akpm will check out how good is our c compilers?
Aivils Stoss
Quoted 6 lines · Aivils
Hi all!
My 2.6.5 will not start until i applay patch bellow:
kernel/softirq.chg.c 2004-04-20 10:48:28.000000000 +0300 static int __devinit cpu_callback(struct · line 416
Quoted 10 lines
kernel/softirq.chg.c 2004-04-20 10:48:28.000000000 +0300 renamed from kernel/softirq.c 2004-04-04 06:36:47.000000000 +0300 +2
-2@@ -409,8 +409,8 @@ static int __devinit cpu_callback(struct switch (action) { case CPU_UP_PREPARE: - BUG_ON(per_cpu(tasklet_vec, hotcpu).list); - BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list); + per_cpu(tasklet_vec, cpu).list = NULL; + per_cpu(tasklet_hi_vec, cpu).list = NULL; p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu); if (IS_ERR(p)) { printk("ksoftirqd for %i failed\n", hotcpu);
This patch should be completely unnecessary.
One possibility is that your compiler isn't obeying the section attribute for some reason. Please send .config and output of "gcc -v".
Thanks!
Rusty.
Signature · 1 line
Anyone who quotes me in their signature is an idiot -- Rusty Russell