Skip to contentSkip to conversation

nfs-access-acl

PATCH In review Andreas Gruenbacher 1 participant 1 message Apr 26, 2004 NFS client

lore
Share & tools
lore
#0 lore raw

PATCH 7/11 nfs-access-acl

NFS mount parameter noacl

Add the [no]acl mount parameter for the nfs filesystem, as discussed with Trond Myklebust <[email protected]> and Olaf Kirch <[email protected]>. This parameter disables the ACCESS procedure call which is otherwise used to determine whether or not a user is granted access to a file system object.

Andreas Gruenbacher <[email protected]>

fs/nfs/dir.c +2 -1
Index: linux-2.6.6-rc2/fs/nfs/dir.c
===================================================================
@@ -1501,6 +1501,7 @@ out:
 int
 nfs_permission(struct inode *inode, int mask, struct nameidata *nd)
 {
+	struct nfs_server *server = NFS_SERVER(inode);
 	struct nfs_access_cache *cache = &NFS_I(inode)->cache_access;
 	struct rpc_cred *cred;
 	int mode = inode->i_mode;
@@ -1538,7 +1539,7 @@ nfs_permission(struct inode *inode, int 
 
 	lock_kernel();
 
-	if (!NFS_PROTO(inode)->access)
+	if ((server->flags & NFS_MOUNT_NOACL) || !NFS_PROTO(inode)->access)
 		goto out_notsup;
 
 	cred = rpcauth_lookupcred(NFS_CLIENT(inode)->cl_auth, 0);
fs/nfs/inode.c +1 -0
Index: linux-2.6.6-rc2/fs/nfs/inode.c
===================================================================
@@ -559,6 +559,7 @@ static int nfs_show_options(struct seq_f
 		{ NFS_MOUNT_NOAC, ",noac", "" },
 		{ NFS_MOUNT_NONLM, ",nolock", ",lock" },
 		{ NFS_MOUNT_BROKEN_SUID, ",broken_suid", "" },
+		{ NFS_MOUNT_NOACL, ",noacl", "" },
 		{ 0, NULL, NULL }
 	};
 	struct proc_nfs_info *nfs_infop;
include/linux/nfs_mount.h +1 -0
Index: linux-2.6.6-rc2/include/linux/nfs_mount.h
===================================================================
@@ -58,6 +58,7 @@ struct nfs_mount_data {
 #define NFS_MOUNT_KERBEROS	0x0100	/* 3 */
 #define NFS_MOUNT_NONLM		0x0200	/* 3 */
 #define NFS_MOUNT_BROKEN_SUID	0x0400	/* 4 */
+#define NFS_MOUNT_NOACL		0x0800  /* 4 */
 #define NFS_MOUNT_STRICTLOCK	0x1000	/* reserved for NFSv4 */
 #define NFS_MOUNT_SECFLAVOUR	0x2000	/* 5 */
 #define NFS_MOUNT_FLAGMASK	0xFFFF