Skip to contentSkip to conversation

missing put in AFS client

PATCH New David Howells 1 participant 1 message Oct 18, 2002 Afs filesystem

lore
Share & tools
lore

David Howells

author maintainer
#0 lore raw

PATCH 1/1 missing put in AFS client

Hi Linus,

This patch fixes a bug in my AFS client in which a put of an outstanding call was missing in the unmount cleanup code. This occasionally resulted in the AFS module becoming unremovable.

David

fs/afs/cmservice.c +3 -4
diff -ur -x '*.o' -x '*.cmd' -x '*~' linux-2.5.43/fs/afs/cmservice.c afs-devel/fs/afs/cmservice.c
@@ -129,11 +129,7 @@
 	/* only certain signals are of interest */
 	spin_lock_irq(&current->sig->siglock);
 	siginitsetinv(&current->blocked,0);
-#if LINUX_VERSION_CODE > KERNEL_VERSION(2,5,3)
 	recalc_sigpending();
-#else
-	recalc_sigpending(current);
-#endif
 	spin_unlock_irq(&current->sig->siglock);
 
 	/* loop around looking for things to attend to */

@@ -360,6 +356,9 @@
 
 			rxrpc_call_abort(call,-ESRCH); /* abort, dequeue and put */
 
+			_debug("nuking active call %08x.%d",
+			       ntohl(call->conn->conn_id),ntohl(call->call_id));
+			rxrpc_put_call(call);
 			rxrpc_put_call(call);
 
 			spin_lock(&afscm_calls_lock);