Skip to contentSkip to conversation

i8042 debug broken

PATCH In review FabF 2 participants 2 messages May 16, 2004 – May 29, 2004 Input drivers

lore
Share & tools
lore

FabF

author
#0 lore raw

PATCH 1/1 i8042 debug broken

Hi,

i8042 handle_data debug was broken -trying to display unknown
irq-.Here's a quick fix.

Regards,
FabF

drivers/input/serio/i8042.c +4 -4
diff -Naur orig/drivers/input/serio/i8042.c edited/drivers/input/serio/i8042.c
@@ -420,16 +420,16 @@
 				data = 0xfe;
 			} else dfl = 0;
 
-			dbg("%02x <- i8042 (interrupt, aux%d, %d%s%s)",
-				data, (str >> 6), irq,
+			dbg("%02x <- i8042 (interrupt, aux%d, %s%s)",
+				data, (str >> 6), 
 				dfl & SERIO_PARITY ? ", bad parity" : "",
 				dfl & SERIO_TIMEOUT ? ", timeout" : "");
 
 			serio_interrupt(i8042_mux_port + ((str >> 6) & 3), data, dfl, NULL);
 		} else {
 
-			dbg("%02x <- i8042 (interrupt, %s, %d%s%s)",
-				data, (str & I8042_STR_AUXDATA) ? "aux" : "kbd", irq,
+			dbg("%02x <- i8042 (interrupt, %s, %s%s)",
+				data, (str & I8042_STR_AUXDATA) ? "aux" : "kbd",
 				dfl & SERIO_PARITY ? ", bad parity" : "",
 				dfl & SERIO_TIMEOUT ? ", timeout" : "");
 
#1 lore raw
Quoted 4 lines · FabF

Hi,

i8042 handle_data debug was broken -trying to display unknown
irq-.Here's a quick fix.

I reverted the tasklet conversion of i8042. It should be OK now. And also you shouldn't have a dead keyboard after you press CapsLock. That was likely what your cat did.

Signature · 2 lines
Vojtech Pavlik
SuSE Labs, SuSE CR