Skip to contentSkip to conversation

drivers_scsi_mvme147.c: kill duplicate #include

TRIVIAL Rusty Russell 2 participants 2 messages May 20, 2004

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: [email protected] (Arthur Othieno)

---
Hi,

Quoted 1 line

From scripts/checkincludes.pl:

./drivers/scsi/mvme147.c: mvme147.h is included more than once.

Output from `grep' shows:

    $ grep -n 'mvme147.h' drivers/scsi/mvme147.c
    16:#include "mvme147.h"
    125:#include "mvme147.h"

Against 2.6.5. Thanks.

drivers/scsi/mvme147.c renamed from drivers/scsi/mvme147.c.orig +0 -2
@@ -122,8 +122,6 @@
 
 #define HOSTS_C
 
-#include "mvme147.h"
-
 static Scsi_Host_Template driver_template = {
 	.proc_name		= "MVME147",
 	.name			= "MVME147 built-in SCSI",
Signature · 3 lines
  What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
  Don't blame me: the Monkey is driving
  File: [email protected] (Arthur Othieno): [TRIVIAL 2.6] drivers_scsi_mvme147.c: kill duplicate #include
#1 lore raw

drivers/scsi/mvme147.c line 127

Quoted 11 lines · Rusty Russell
drivers/scsi/mvme147.c renamed from drivers/scsi/mvme147.c.orig +0 -2
@@ -122,8 +122,6 @@
 
 #define HOSTS_C
 
-#include "mvme147.h"
-
 static Scsi_Host_Template driver_template = {
 	.proc_name		= "MVME147",
 	.name			= "MVME147 built-in SCSI",

Same for this. HOST_C alters the behaviour of the second include.

James