Skip to contentSkip to conversation

trashing bootmem on non-NUMA boxes

PATCH New Alex Williamson 1 participant 1 message Jun 25, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trashing bootmem on non-NUMA boxes

call_pernode_memory() is rounding memory regions to page boundaries,
but in the non-NUMA case, it's incorrectly passing the rounded start and the original length. Any reserved memory regions sitting beyond a memory region that isn't nicely aligned is potentially at risk for getting freed and trashed. This is a fairly nasty bug that can bite in very hard to find ways. In my case, the EFI memory map was getting overwritten, causing the ACPI methods to access chipset registers cachable instead of uncachable. It could potentially be causing some of the random hangs and strange behavior we're seeing lately.

=== arch/ia64/mm/discontig.c 1.15 vs edited ==--- 1.15/arch/ia64/mm/discontig.c Thu Jun 24 02:55:57 2004
+++ edited/arch/ia64/mm/discontig.c Fri Jun 25 09:39:20 2004
@@ -549,7 +549,7 @@
if (!num_node_memblks) {
/* No SRAT table, so assume one node (node 0) */ if (start < end)
- (*func)(start, len, 0);
+ (*func)(start, end - start, 0);
return;
}