acpi_pci_link_allocate() -- latent bug?

DISCUSSION joanna marsden 2 participants 2 messages Aug 1, 2004 – Aug 4, 2004 1 message not in the archive ACPI

Share & tools

joanna marsden

author

2004-08-01 02:40 UTC #0 lore raw

I am investigating an interrupt problem on my machine and came across the following code, in drivers/acpi/pci_link.c

What happens here if the BIOS sets up these links at the IRQ router at boot time, but doesn't restore them after a resume from S3? Is this a latent bug? Seems like this routine would eventually be called from pci_device_enable, but wouldn't perform the setup we need.

static int acpi_pci_link_allocate(struct acpi_pci_link* link) {
       int irq;
       int i;

       ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");

       if (link->irq.setonboot)
               return_VALUE(0);

-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

Len Brown

2004-08-04 03:52 UTC #2 lore raw

Yes, per my response to Nathan's patch, I think you did find an issue, but should be okay after his patch.

thanks,
-Len

Quoted 19 lines · joanna marsden

I am investigating an interrupt problem on my machine and came across the following code, in drivers/acpi/pci_link.c
What happens here if the BIOS sets up these links at the IRQ router at boot time, but doesn't restore them after a resume from S3? Is this a latent bug? Seems like this routine would eventually be called from pci_device_enable, but wouldn't perform the setup we need.
static int acpi_pci_link_allocate(struct acpi_pci_link* link) {
        int irq;
        int i;

        ACPI_FUNCTION_TRACE("acpi_pci_link_allocate");

        if (link->irq.setonboot)
                return_VALUE(0);

Quoted 9 lines

-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
Acpi-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-devel