Skip to contentSkip to conversation

Remove unneeded #ifdef kernel from ppc unaligned.h

PATCH In review GOTO Masanori 2 participants 4 messages Aug 9, 2004

lore
Share & tools
lore

GOTO Masanori

author
#0 lore raw

PATCH 1/1 Remove unneeded #ifdef kernel from ppc unaligned.h

This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h. There's no reason to enclose __KERNEL__, similar to other architectures. It also fixes the compilation failure building userland helper application reiserfsprogs on ppc which includes asm/unaligned.h.

Signed-off-by GOTO Masanori <[email protected]>
asm-ppc/unaligned.h.new renamed from asm-ppc/unaligned.h +0 -2
@@ -1,4 +1,3 @@
-#ifdef __KERNEL__
 #ifndef __PPC_UNALIGNED_H
 #define __PPC_UNALIGNED_H
 

@@ -15,4 +14,3 @@
 #define put_unaligned(val, ptr) ((void)( *(ptr) = (val) ))
 
 #endif
-#endif /* __KERNEL__ */
#1 lore raw
Quoted 5 lines · GOTO Masanori

This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h. There's no reason to enclose __KERNEL__, similar to other architectures. It also fixes the compilation failure building userland helper application reiserfsprogs on ppc which includes asm/unaligned.h.

Well, userland isn't supposed to use those ...

Ben.

author
#2 lore raw

At Mon, 09 Aug 2004 18:07:45 +1000,

Quoted 8 lines · Benjamin Herrenschmidt
Quoted 5 lines · GOTO Masanori

This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h. There's no reason to enclose __KERNEL__, similar to other architectures. It also fixes the compilation failure building userland helper application reiserfsprogs on ppc which includes asm/unaligned.h.

Well, userland isn't supposed to use those ...

I know. It's just side effect. But there's no reason to enclose #ifdef __KERNEL__.

Regards,
-- gotom

#3 lore raw
Quoted 9 lines · GOTO Masanori

At Mon, 09 Aug 2004 18:07:45 +1000,

Quoted 7 lines · Benjamin Herrenschmidt
Quoted 5 lines · GOTO Masanori

This patch removes unneeded #ifdef __KERNEL__ from ppc unaligned.h. There's no reason to enclose __KERNEL__, similar to other architectures. It also fixes the compilation failure building userland helper application reiserfsprogs on ppc which includes asm/unaligned.h.

Quoted 4 lines
Quoted 1 line

Well, userland isn't supposed to use those ...

I know. It's just side effect. But there's no reason to enclose #ifdef __KERNEL__.

Hrm... I'd say there is no reason not to enclose it in it, but I'll let Paul make a final decision here.

Ben.