Skip to contentSkip to conversation

Remove whitespace from ALI15x3 IDE driver name

PATCH In review Pekka Enberg 4 participants 6 messages Aug 12, 2004 – Aug 15, 2004

lore
Share & tools
lore

Pekka Enberg

author
#0 lore raw

PATCH 1/1 Remove whitespace from ALI15x3 IDE driver name

This patch removes whitespace from ALI15x3 IDE driver name that appears in the sysfs directory. It is against 2.6.7.

Signed-off-by Pekka Enberg <[email protected]>
 alim15x3.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/ide/pci/alim15x3.c +1 -1
Index: linux-2.6.7-pe/drivers/ide/pci/alim15x3.c
===================================================================
@@ -893,7 +893,7 @@
 MODULE_DEVICE_TABLE(pci, alim15x3_pci_tbl);
 
 static struct pci_driver driver = {
-	.name		= "ALI15x3 IDE",
+	.name		= "ALI15x3_IDE",
 	.id_table	= alim15x3_pci_tbl,
 	.probe		= alim15x3_init_one,
 };
#1 lore raw
Quoted 2 lines · Pekka Enberg

This patch removes whitespace from ALI15x3 IDE driver name that appears in the sysfs directory. It is against 2.6.7.

You jnow that this breaks every tool that knew of the names so far? E.g. Debian mkinitrd (now has a patch to deal with both the whitespace and non-whitespace variants) and probably quite a few installers out there.

author
#2 lore raw

Hi Christoph,

Quoted 2 lines · Pekka Enberg
Quoted 2 lines

This patch removes whitespace from ALI15x3 IDE driver name that appears in the sysfs directory. It is against 2.6.7.

Quoted 3 lines · Christoph Hellwig

You jnow that this breaks every tool that knew of the names so far? E.g. Debian mkinitrd (now has a patch to deal with both the whitespace and non-whitespace variants) and probably quite a few installers out there.

Sorry, I did not know that. I only booted to my Gentoo box with it. I saw similar patches go into other PCI drivers which is why I thought it was appropriate.

Pekka

#3 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 2 lines · Pekka Enberg

This patch removes whitespace from ALI15x3 IDE driver name that appears in the sysfs directory. It is against 2.6.7.

You jnow that this breaks every tool that knew of the names so far? E.g. Debian mkinitrd (now has a patch to deal with both the whitespace and non-whitespace variants) and probably quite a few installers out there.

Greg okayed a pile of other related changes including some that were not just white space to _ but changed the actual string. So you may want to take it up with Greg rather than Pekka who is just filling in one that was missed

#4 lore raw

On Aug 12 2004, at 20:55, Alan Cox was caught saying:

Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Pekka Enberg
Quoted 2 lines

This patch removes whitespace from ALI15x3 IDE driver name that appears in the sysfs directory. It is against 2.6.7.

Quoted 8 lines
Quoted 3 lines

You jnow that this breaks every tool that knew of the names so far? E.g. Debian mkinitrd (now has a patch to deal with both the whitespace and non-whitespace variants) and probably quite a few installers out there.

Greg okayed a pile of other related changes including some that were not just white space to _ but changed the actual string. So you may want to take it up with Greg rather than Pekka who is just filling in one that was missed

Not having touched installer code, can someone enlighten me on why the installer would break with 's/ /_' or any other change to driver name?

~Deepak

Signature · 4 lines
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/

"Unlike me, many of you have accepted the situation of your imprisonment and
 will die here like rotten cabbages." - Number 6
#5 lore raw
Quoted 3 lines · Deepak Saxena

Not having touched installer code, can someone enlighten me on why the installer would break with 's/ /_' or any other change to driver name?

driver name <-> module name mapping