Skip to contentSkip to conversation

emu10k1: don't bother to invalidate cache for the extra voice

PATCH New Lee Revell 1 participant 1 message Aug 27, 2004

lore
Share & tools
lore

Lee Revell

author
#0 lore raw

PATCH 1/1 emu10k1: don't bother to invalidate cache for the extra voice

Since the extra voice is only used to generate the period interrupts and is always silent, I don't see why we need to invalidate its cache. Apparently the author of the driver felt the same way. Latency tracing shows that this can shave 20 usecs off the 120 usecs required for startup and xrun recovery.

Lee

pci/emu10k1/emupcm.c renamed from pci/emu10k1/emupcm.c~ +0 -1
@@ -574,7 +574,6 @@
 	spin_lock(&emu->reg_lock);
 	switch (cmd) {
 	case SNDRV_PCM_TRIGGER_START:
-		snd_emu10k1_playback_invalidate_cache(emu, epcm->extra);	/* do we need this? */
 		snd_emu10k1_playback_invalidate_cache(emu, epcm->voices[0]);
 		/* follow thru */
 	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:

-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33 Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285