radeonfb: do not blank during swsusp snapshot
Hi!
With display blanked, it is hard to debug anything. And display blanking is not really needed there... Does it look okay?
Pavel
drivers/video/aty/radeon_pm.c +8 -6
@@ -880,12 +880,14 @@radeon_engine_idle (); } -/* Blank display and LCD */ -radeonfb_blank (VESA_POWERDOWN , info); - -/* Sleep */ - rinfo->asleep =1 ; - rinfo->lock_blank =1 ; +if (system_state !=SYSTEM_SNAPSHOT ) { +/* Blank display and LCD */ +radeonfb_blank (VESA_POWERDOWN , info); + +/* Sleep */ + rinfo->asleep =1 ; + rinfo->lock_blank =1 ; + }/* Suspend the chip to D2 state when supported */
Signature · 2 lines
People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
Quoted 4 lines · Pavel Machek
Hi!
With display blanked, it is hard to debug anything. And display blanking is not really needed there... Does it look okay?
Well... I have some patches for that, though not using the system_state global (that I don't like, but it seems that you decided to go that way anyways)....
You probably wnat to avoid the call to fb_set_suspend as well
Ben.
Hi!
Quoted 7 lines
Quoted 3 lines
With display blanked, it is hard to debug anything. And display blanking is not really needed there... Does it look okay?
Well... I have some patches for that, though not using the
system_stateglobal (that I don't like, but it seems that you decided to go that way anyways)....
It was basically akpm's idea. I don't like it much, but it is better than existing mess.
Quoted 1 line
You probably wnat to avoid the call to
fb_set_suspendas well
Ok.
Signature · 1 line
Horseback riding is like software...