Skip to contentSkip to conversation

allow OEM written modules to make calls to ia64 OEM SAL functions.

IA64 Arjan van de Ven 5 participants 7 messages Sep 4, 2004 – Sep 7, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

are there any such modules? Are they GPL licensed or all proprietary ?

#2 lore raw
Quoted 11 lines · Arjan van de Ven
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

#3 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 10 lines · Arjan van de Ven
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

Quoted 4 lines
Quoted 1 line

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

if there are no open source modules that use these exports I would like to ask these exports to be undone again..

#4 lore raw
Quoted 13 lines · Arjan van de Ven
Quoted 11 lines · Christoph Hellwig
Quoted 10 lines · Arjan van de Ven
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

if there are no open source modules that use these exports I would like to ask these exports to be undone again..

Yes. Guys, these are the rules we all live by.

Arjan, please submit a patch.

#5 lore raw
Quoted 19 lines · Andrew Morton
Quoted 18 lines · Arjan van de Ven
Quoted 15 lines · Christoph Hellwig
Quoted 11 lines · Arjan van de Ven
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

Quoted 6 lines
Quoted 2 lines

if there are no open source modules that use these exports I would like to ask these exports to be undone again..

Yes. Guys, these are the rules we all live by.

Arjan, please submit a patch.

well all that is needed is to revert changeset 1.1803.128.1 since that is the entire and exclusive purpose of this changeset.. but for your convenience below

arch/ia64/kernel/sal.c +0 -38
@@ -10,7 +10,6 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/string.h>
 
@@ -263,40 +262,3 @@
 		p += SAL_DESC_SIZE(*p);
 	}
 }
-
-int
-ia64_sal_oemcall(struct ia64_sal_retval *isrvp, u64 oemfunc, u64 arg1,
-		 u64 arg2, u64 arg3, u64 arg4, u64 arg5, u64 arg6, u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6, arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall);
-
-int
-ia64_sal_oemcall_nolock(struct ia64_sal_retval *isrvp, u64 oemfunc, u64 arg1,
-			u64 arg2, u64 arg3, u64 arg4, u64 arg5, u64 arg6,
-			u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL_NOLOCK(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6,
-			arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall_nolock);
-
-int
-ia64_sal_oemcall_reentrant(struct ia64_sal_retval *isrvp, u64 oemfunc,
-			   u64 arg1, u64 arg2, u64 arg3, u64 arg4, u64 arg5,
-			   u64 arg6, u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL_REENTRANT(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6,
-			   arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall_reentrant);

reverted:

include/asm-ia64/sal.h +0 -10
@@ -819,16 +819,6 @@
 	long r8; long r9; long r10; long r11;
 };
 
-#define IA64_SAL_OEMFUNC_MIN		0x02000000
-#define IA64_SAL_OEMFUNC_MAX		0x03ffffff
-
-extern int ia64_sal_oemcall(struct ia64_sal_retval *, u64, u64, u64, u64, u64,
-			    u64, u64, u64);
-extern int ia64_sal_oemcall_nolock(struct ia64_sal_retval *, u64, u64, u64,
-				   u64, u64, u64, u64, u64);
-extern int ia64_sal_oemcall_reentrant(struct ia64_sal_retval *, u64, u64, u64,
-				      u64, u64, u64, u64, u64);
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_IA64_SAL_H */
#6 lore raw

Can we hold off on reverting this until more discussion occurs.

SGI introduced this as part of our work to push the open source XPC code into the kernel. Tony Luck included the patch after discussions about XPC splintered into a seperate discussion about what was acceptable for the SAL call. SGI had originally intended this to be part of that patch set.

The OEM functions that are referred to do things like modify memory timeout values on OEM equipment, adjust memory protections, inject double bit errors to test error recovery, and adjust queue lengths inside of hardware. These things are extremely OEM specific. Making the SAL calls only rely on "Kernel Code" for the definition of the kernel function calls which is a gateway into SAL.

What the kernel's SAL call is providing to the module is a pointer to a generic function entry point for SAL that was provided to the kernel by SAL. This is the proscribed method defined in the Intel Itanium System Abstraction Layer specification available on the Intel web site. The kernel has no knowledge of what SAL will do with this function code nor what the caller is asking. In essence this is equivalent to a PCI command.

Having this functionality in the kernel is important to SGI even before the code is written. This allows us to use the SAL call from error injection diagnostics on older kernels. The code limits the SAL functions to those in the OEM range as defined by the Intel specification.

Robin Holt

Quoted 108 lines · Arjan van de Ven
Quoted 19 lines · Andrew Morton
Quoted 18 lines · Arjan van de Ven
Quoted 15 lines · Christoph Hellwig
Quoted 11 lines · Arjan van de Ven
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1803.128.1, 2004/08/25 18:27:33+00:00, [email protected]

[IA64] allow OEM written modules to make calls to ia64 OEM SAL functions.

Add wrapper functions for SAL_CALL(), SAL_CALL_NOLOCK(), and SAL_CALL_REENTRANT() that allow OEM written modules to make calls to ia64 OEM SAL functions.

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

Quoted 6 lines
Quoted 2 lines

if there are no open source modules that use these exports I would like to ask these exports to be undone again..

Yes. Guys, these are the rules we all live by.

Arjan, please submit a patch.

well all that is needed is to revert changeset 1.1803.128.1 since that is the entire and exclusive purpose of this changeset.. but for your convenience below

arch/ia64/kernel/sal.c +0 -38
@@ -10,7 +10,6 @@
 
 #include <linux/kernel.h>
 #include <linux/init.h>
-#include <linux/module.h>
 #include <linux/spinlock.h>
 #include <linux/string.h>
 
@@ -263,40 +262,3 @@
 		p += SAL_DESC_SIZE(*p);
 	}
 }
-
-int
-ia64_sal_oemcall(struct ia64_sal_retval *isrvp, u64 oemfunc, u64 arg1,
-		 u64 arg2, u64 arg3, u64 arg4, u64 arg5, u64 arg6, u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6, arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall);
-
-int
-ia64_sal_oemcall_nolock(struct ia64_sal_retval *isrvp, u64 oemfunc, u64 arg1,
-			u64 arg2, u64 arg3, u64 arg4, u64 arg5, u64 arg6,
-			u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL_NOLOCK(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6,
-			arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall_nolock);
-
-int
-ia64_sal_oemcall_reentrant(struct ia64_sal_retval *isrvp, u64 oemfunc,
-			   u64 arg1, u64 arg2, u64 arg3, u64 arg4, u64 arg5,
-			   u64 arg6, u64 arg7)
-{
-	if (oemfunc < IA64_SAL_OEMFUNC_MIN || oemfunc > IA64_SAL_OEMFUNC_MAX)
-		return -1;
-	SAL_CALL_REENTRANT(*isrvp, oemfunc, arg1, arg2, arg3, arg4, arg5, arg6,
-			   arg7);
-	return 0;
-}
-EXPORT_SYMBOL(ia64_sal_oemcall_reentrant);

reverted:

include/asm-ia64/sal.h +0 -11
@@ -819,16 +819,6 @@
 	long r8; long r9; long r10; long r11;
 };
 
-#define IA64_SAL_OEMFUNC_MIN		0x02000000
-#define IA64_SAL_OEMFUNC_MAX		0x03ffffff
-
-extern int ia64_sal_oemcall(struct ia64_sal_retval *, u64, u64, u64, u64, u64,
-			    u64, u64, u64);
-extern int ia64_sal_oemcall_nolock(struct ia64_sal_retval *, u64, u64, u64,
-				   u64, u64, u64, u64, u64);
-extern int ia64_sal_oemcall_reentrant(struct ia64_sal_retval *, u64, u64, u64,
-				      u64, u64, u64, u64, u64);
-
 #endif /* __ASSEMBLY__ */
 
 #endif /* _ASM_IA64_SAL_H */
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#7 lore raw
In reply to Christoph Hellwig
Quoted 4 lines · Christoph Hellwig
Quoted 1 line

are there any such modules? Are they GPL licensed or all proprietary ?

SGI has stated they have propritary modules that need this, that's why it's got added despite my objections.

Wouldn't that be "had" since they are clearly now derivative works of the GPL OS core.