unexport get_wchan
Subsystems (4)
PATCH 1/1 unexport get_wchan
only usedby procfs which certainly can't be modular
arch/alpha/kernel/alpha_ksyms.c +0 -2
@@ -258,8 +258,6 @@EXPORT_SYMBOL_NOVERS (memset);EXPORT_SYMBOL_NOVERS (memchr); -EXPORT_SYMBOL (get_wchan); -#ifdef CONFIG_ALPHA_IRONGATE EXPORT_SYMBOL (irongate_ioremap);EXPORT_SYMBOL (irongate_iounmap);
arch/arm/kernel/process.c +0 -1
@@ -452,4 +452,3 @@ }while (count ++ <16 );return 0 ; } -EXPORT_SYMBOL (get_wchan);
arch/arm26/kernel/armksyms.c +0 -2
@@ -219,8 +219,6 @@EXPORT_SYMBOL_NOVERS (__down_trylock_failed);EXPORT_SYMBOL_NOVERS (__up_wakeup); -EXPORT_SYMBOL (get_wchan); -#ifdef CONFIG_PREEMPT EXPORT_SYMBOL (kernel_flag);#endif
arch/h8300/kernel/h8300_ksyms.c +0 -2
@@ -58,8 +58,6 @@EXPORT_SYMBOL_NOVERS (memscan);EXPORT_SYMBOL_NOVERS (memmove); -EXPORT_SYMBOL (get_wchan); -/* * libgcc functions - functions that are used internally by the * compiler... (prototypes are not correct though, but that
arch/i386/kernel/i386_ksyms.c +0 -2
@@ -167,8 +167,6 @@EXPORT_SYMBOL (screen_info);#endif -EXPORT_SYMBOL (get_wchan); -EXPORT_SYMBOL (rtc_lock);EXPORT_SYMBOL_GPL (set_nmi_callback);
arch/m68k/kernel/m68k_ksyms.c +0 -2
@@ -85,5 +85,3 @@EXPORT_SYMBOL_NOVERS (__down_failed_interruptible);EXPORT_SYMBOL_NOVERS (__down_failed_trylock);EXPORT_SYMBOL_NOVERS (__up_wakeup); - -EXPORT_SYMBOL (get_wchan);
arch/m68knommu/kernel/m68k_ksyms.c +0 -2
@@ -61,8 +61,6 @@EXPORT_SYMBOL_NOVERS (__down_failed_trylock);EXPORT_SYMBOL_NOVERS (__up_wakeup); -EXPORT_SYMBOL (get_wchan); -/* * libgcc functions - functions that are used internally by the * compiler... (prototypes are not correct though, but that
===== arch/mips/kernel/process.c 1.14 vs edited =====
arch/mips/kernel/process.c +0 -2
@@ -340,5 +340,3 @@return pc; } - -EXPORT_SYMBOL (get_wchan);
arch/ppc/kernel/ppc_ksyms.c +0 -1
@@ -295,7 +295,6 @@void ppc_irq_dispatch_handler (struct pt_regs *,int );EXPORT_SYMBOL (ppc_irq_dispatch_handler);EXPORT_SYMBOL (tb_ticks_per_jiffy); -EXPORT_SYMBOL (get_wchan);EXPORT_SYMBOL (console_drivers);#ifdef CONFIG_XMON EXPORT_SYMBOL (xmon);
arch/ppc64/kernel/ppc_ksyms.c +0 -1
@@ -157,7 +157,6 @@EXPORT_SYMBOL (timer_interrupt);EXPORT_SYMBOL (irq_desc); -EXPORT_SYMBOL (get_wchan);EXPORT_SYMBOL (console_drivers);EXPORT_SYMBOL (tb_ticks_per_usec);
Quoted 1 line · Christoph Hellwig
only usedby procfs which certainly can't be modular
And multiple out of tree debuggers. Christoph - do some basic homework. Also save the "so merge it" crap for someone else before you come up with that comment. Given the choice between a few exports of relevant functionality and merging some of the open source stuff that uses it we are far far better off with the export.
Plus Linus has a random personal and unreasonable hatred of debugging tools so they'll never get merged anyway without forking the kernel.
Alan
Quoted 11 lines · Alan Cox
Quoted 1 line · Christoph Hellwig
only usedby procfs which certainly can't be modular
And multiple out of tree debuggers. Christoph - do some basic homework. Also save the "so merge it" crap for someone else before you come up with that comment. Given the choice between a few exports of relevant functionality and merging some of the open source stuff that uses it we are far far better off with the export.
Plus Linus has a random personal and unreasonable hatred of debugging tools so they'll never get merged anyway without forking the kernel.
Which debuging tool? Both kdb and xmon don't use it.
Quoted 1 line · Christoph Hellwig
Which debuging tool? Both kdb and xmon don't use it.
You broke my kgdb 8)
Quoted 4 lines · Alan Cox
Quoted 1 line · Christoph Hellwig
Which debuging tool? Both kdb and xmon don't use it.
You broke my kgdb 8)
Well, you kdb cotains quite a few other patches to core code already, no? And it could add back a single EXPORT_SYMBOL in a common place instead of duplicated over every architecture..
Quoted 3 lines · Christoph Hellwig
Well, you kdb cotains quite a few other patches to core code already, no? And it could add back a single
EXPORT_SYMBOLin a common place instead of duplicated over every architecture..
I think most projects' goals is to reduce the number of patches they need to make to the kernel instead of increasing them... If you think it is ugly to have multiple EXPORT_SYMBOLS() then it should just be moved to the line after the function definition. Having to add another configure rule to check for now-unexported symbols isn't my idea of time well spent (not that I care about this one in particular).
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/
Quoted 4 lines · Alan Cox
Quoted 1 line · Christoph Hellwig
Which debuging tool? Both kdb and xmon don't use it.
You broke my kgdb 8)
kgdb surely uses the kallsyms stuff instead... far more reliable...