Skip to contentSkip to conversation

ppc32: Fix potentially uninitialized var in chrp_setup.c

PATCH New Benjamin Herrenschmidt 1 participant 1 message Sep 24, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc32: Fix potentially uninitialized var in chrp_setup.c

Hi !

In chrp_setup.c, chrp_int_ack could be left uninitialized and passed "as-is" to i8259_init() if the OF node for the 8259 wasn't found. I don't know if that should happen, but the i8259 code can deal with int_ack beeing 0, so let's be safe, initialize it, and remove a warning at the same time.

===== arch/ppc/platforms/chrp_setup.c 1.34 vs edited =====

arch/ppc/platforms/chrp_setup.c +1 -1
@@ -375,7 +375,7 @@
 {
 	struct device_node *np;
 	int i;
-	unsigned long chrp_int_ack;
+	unsigned long chrp_int_ack = 0;
 	unsigned char init_senses[NR_IRQS - NUM_8259_INTERRUPTS];
 #if defined(CONFIG_VT) && defined(CONFIG_INPUT_ADBHID) && defined(XMON)
 	struct device_node *kbd;