Skip to contentSkip to conversation

-mm swsusp: copy_page is harmfull

PATCH Benjamin Herrenschmidt 3 participants 4 messages Oct 3, 2004 – Oct 4, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1983.1.3, 2004/09/24 17:27:41-07:00, [email protected]

[PATCH] -mm swsusp: copy_page is harmfull

From: Pavel Machek <[email protected]>

This is my fault from long time ago: copy_page can't be used for copying task struct, therefore we can't use it in swsusp.

Hi !

Just curious, but why ?

It would be useful to have this in platform code, I don't see why I couldn't use copy_page() on ppc and I suspect it will be more efficient than memcpy since it has specific optimisations due to the fact that we are known to be fully aligned and the size of the copy is a constant aligned power of 2.

Ben.

#2 lore raw

Hi.

Quoted 10 lines · Benjamin Herrenschmidt
Quoted 8 lines · Linux Kernel Mailing List

ChangeSet 1.1983.1.3, 2004/09/24 17:27:41-07:00, [email protected]

[PATCH] -mm swsusp: copy_page is harmfull

From: Pavel Machek <[email protected]>

This is my fault from long time ago: copy_page can't be used for copying task struct, therefore we can't use it in swsusp.

Quoted 8 lines

Hi !

Just curious, but why ?

It would be useful to have this in platform code, I don't see why I couldn't use copy_page() on ppc and I suspect it will be more efficient than memcpy since it has specific optimisations due to the fact that we are known to be fully aligned and the size of the copy is a constant aligned power of 2.

I think I can answer that one, seeing as Pavel seems to be asleep at the mo :>.

On x86 at least (perhaps your platform is different), copy_page can resolve to different implementations. If you have 3D_NOW, the preempt count will be incremented prior to copying the page via a fpu_begin call. Sooner or later in doing the atomic copy of memory, you'll be copying the page containing the preempt count (the task struct) for the process doing the suspending. At that stage, you'll copy the preempt count being one too high, and at resume time it will still be one too high (we definitely can't use copy_page then). The simple solution would be to use copy_page and have something like

#ifdef 3D_NOW
	dec_preempt_count();

#endif

But I'm sure you'll agree that even if it's faster, it's less clear and uglier.

Regards,

Nigel

#3 lore raw
In reply to Benjamin Herrenschmidt

Hi!

Quoted 10 lines
Quoted 6 lines

[PATCH] -mm swsusp: copy_page is harmfull

From: Pavel Machek <[email protected]>

This is my fault from long time ago: copy_page can't be used for copying task struct, therefore we can't use it in swsusp.

Hi !

Just curious, but why ?

Nigel already provided right explanation.

Quoted 4 lines

It would be useful to have this in platform code, I don't see why I couldn't use copy_page() on ppc and I suspect it will be more efficient than memcpy since it has specific optimisations due to the fact that we are known to be fully aligned and the size of the copy is a constant aligned power of 2.

Hmm but does it matter? Is that operation really that slow on ppc? This whole copy takes maybe second on x86, other operations are way slower...
Pavel

Signature · 2 lines
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
#4 lore raw
Quoted 3 lines · Pavel Machek

Hmm but does it matter? Is that operation really that slow on ppc? This whole copy takes maybe second on x86, other operations are way slower...

No, you are right, it probably doesn't matter.

Ben.