Skip to contentSkip to conversation

scheduler: remove NODE_BALANCE_RATE definitions

PATCH In review Matthew Dobson 2 participants 2 messages Oct 6, 2004 Generic include/asm header files

lore
Share & tools
lore

Matthew Dobson

author
#0 lore raw

PATCH 1/1 scheduler: remove NODE_BALANCE_RATE definitions

NODE_BALANCE_RATE is defined all over the place, but used nowhere. Let's remove it.

[mcd@arrakis source]$ diffstat ~/linux/patches/remove-NODE_BALANCE_RATE.patch

 asm-alpha/topology.h          |    3 ---
 asm-generic/topology.h        |    5 -----
 asm-i386/topology.h           |    3 ---
 asm-ia64/topology.h           |    3 ---
 asm-m32r/topology.h           |    5 -----
 asm-mips/mach-ip27/topology.h |    3 ---
 asm-ppc64/topology.h          |    3 ---
 asm-x86_64/topology.h         |    2 --
 8 files changed, 27 deletions(-)

-Matt

include/asm-alpha/topology.h +0 -3
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-alpha/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-alpha/topology.h
@@ -39,9 +39,6 @@ static inline cpumask_t node_to_cpumask(
 	return node_cpu_mask;
 }
 
-/* Cross-node load balancing interval. */
-# define NODE_BALANCE_RATE 10
-
 #define pcibus_to_cpumask(bus)	(cpu_online_map)
 
 #else /* CONFIG_NUMA */
include/asm-generic/topology.h +0 -5
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-generic/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-generic/topology.h
@@ -45,9 +45,4 @@
 #define pcibus_to_cpumask(bus)	(cpu_online_map)
 #endif
 
-/* Cross-node load balancing interval. */
-#ifndef NODE_BALANCE_RATE
-#define NODE_BALANCE_RATE 10
-#endif
-
 #endif /* _ASM_GENERIC_TOPOLOGY_H */
include/asm-i386/topology.h +0 -3
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-i386/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-i386/topology.h
@@ -69,9 +69,6 @@ static inline cpumask_t pcibus_to_cpumas
 /* Node-to-Node distance */
 #define node_distance(from, to) ((from) != (to))
 
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 100
-
 /* sched_domains SD_NODE_INIT for NUMAQ machines */
 #define SD_NODE_INIT (struct sched_domain) {		\
 	.span			= CPU_MASK_NONE,	\
include/asm-ia64/topology.h +0 -3
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-ia64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ia64/topology.h
@@ -40,9 +40,6 @@
  */
 #define node_to_first_cpu(node) (__ffs(node_to_cpumask(node)))
 
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 10
-
 void build_cpu_to_node_map(void);
 
 /* sched_domains SD_NODE_INIT for IA64 NUMA machines */
include/asm-m32r/topology.h +0 -5
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-m32r/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-m32r/topology.h
@@ -45,9 +45,4 @@
 #define pcibus_to_cpumask(bus)	(cpu_online_map)
 #endif
 
-/* Cross-node load balancing interval. */
-#ifndef NODE_BALANCE_RATE
-#define NODE_BALANCE_RATE 10
-#endif
-
 #endif /* _ASM_M32R_TOPOLOGY_H */
include/asm-mips/mach-ip27/topology.h +0 -3
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-mips/mach-ip27/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-mips/mach-ip27/topology.h
@@ -12,7 +12,4 @@
 extern int node_distance(nasid_t nasid_a, nasid_t nasid_b);
 #define node_distance(from, to)	node_distance(from, to)
 
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE	10
-
 #endif /* _ASM_MACH_TOPOLOGY_H */
include/asm-ppc64/topology.h +0 -3
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-ppc64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-ppc64/topology.h
@@ -37,9 +37,6 @@ static inline int node_to_first_cpu(int 
 
 #define nr_cpus_node(node)	(nr_cpus_in_node[node])
 
-/* Cross-node load balancing interval. */
-#define NODE_BALANCE_RATE 10
-
 /* sched_domains SD_NODE_INIT for PPC64 machines */
 #define SD_NODE_INIT (struct sched_domain) {		\
 	.span			= CPU_MASK_NONE,	\
include/asm-x86_64/topology.h +0 -2
diff -Nurp --exclude-from=/home/mcd/.dontdiff linux-2.6.9-rc3-mm2/include/asm-x86_64/topology.h linux-2.6.9-rc3-mm2-NODE_BALANCE_RATE/include/asm-x86_64/topology.h
@@ -32,8 +32,6 @@ static inline cpumask_t __pcibus_to_cpum
 /* broken generic file uses #ifndef later on this */
 #define pcibus_to_cpumask(bus) __pcibus_to_cpumask(bus)
 
-#define NODE_BALANCE_RATE 30	/* CHECKME */ 
-
 #ifdef CONFIG_NUMA
 /* sched_domains SD_NODE_INIT for x86_64 machines */
 #define SD_NODE_INIT (struct sched_domain) {		\
#1 lore raw
Quoted 2 lines · Matthew Dobson

NODE_BALANCE_RATE is defined all over the place, but used nowhere. Let's remove it.

Yep that looks good. Andrew, can you queue this for when 2.6.10 opens please.