Skip to contentSkip to conversation

vm-thrashing-control-tuning

PATCH Andi Kleen 4 participants 7 messages Oct 5, 2004 – Oct 11, 2004 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw
Quoted 3 lines · Hideo AOKI

This patch adds "swap_token_timeout" parameter in /proc/sys/vm.
The parameter means expired time of token. Unit of the value is HZ, and the default value is the same as current SWAP_TOKEN_TIMEOUT (i.e. HZ * 300). The patch can be applied to both 2.6.9-rc2 and 2.6.9-rc3.

Please don't export any sysctls as jiffies. The values of jiffies changes. Use s or ms instead. sysctl has convenience functions for this.

-Andi

#2 lore raw
Quoted 8 lines · Andi Kleen
Quoted 3 lines · Hideo AOKI

This patch adds "swap_token_timeout" parameter in /proc/sys/vm.
The parameter means expired time of token. Unit of the value is HZ, and the default value is the same as current SWAP_TOKEN_TIMEOUT (i.e. HZ * 300). The patch can be applied to both 2.6.9-rc2 and 2.6.9-rc3.

Please don't export any sysctls as jiffies. The values of jiffies changes. Use s or ms instead. sysctl has convenience functions for this.

Andi,

Thank you very much for useful suggestion.
I changed unit of the parameter from jiffies to second.

Andrew,

I apologize for wasting for your time in last mail. Attached patch is fixed the unit issue Andi noticed. Additionally, the patch is fixed writespace issue.

Best regards,
Hideo AOKI

Systems Development Laboratory, Hitachi, Ltd.

 include/linux/swap.h   |    1 +
 include/linux/sysctl.h |    1 +
 kernel/sysctl.c        |    9 +++++++++
 mm/thrash.c            |    5 +++--
 4 files changed, 14 insertions(+), 2 deletions(-)
include/linux/swap.h +1 -0
diff -uprN linux-2.6.9-rc3/include/linux/swap.h linux-2.6.9-rc3-vm-thrashing-control-tuning/include/linux/swap.h
@@ -230,6 +230,7 @@ extern spinlock_t swaplock;
 
 /* linux/mm/thrash.c */
 extern struct mm_struct * swap_token_mm;
+extern unsigned long swap_token_default_timeout;
 extern void grab_swap_token(void);
 extern void __put_swap_token(struct mm_struct *);
 
include/linux/sysctl.h +1 -0
diff -uprN linux-2.6.9-rc3/include/linux/sysctl.h linux-2.6.9-rc3-vm-thrashing-control-tuning/include/linux/sysctl.h
@@ -167,6 +167,7 @@ enum
 	VM_HUGETLB_GROUP=25,	/* permitted hugetlb group */
 	VM_VFS_CACHE_PRESSURE=26, /* dcache/icache reclaim pressure */
 	VM_LEGACY_VA_LAYOUT=27, /* legacy/compatibility virtual address space layout */
+	VM_SWAP_TOKEN_TIMEOUT=28 /* default time for token time out */
 };
 
 
kernel/sysctl.c +9 -0
diff -uprN linux-2.6.9-rc3/kernel/sysctl.c linux-2.6.9-rc3-vm-thrashing-control-tuning/kernel/sysctl.c
@@ -800,6 +800,15 @@ static ctl_table vm_table[] = {
 		.extra1		= &zero,
 	},
 #endif
+	{
+		.ctl_name	= VM_SWAP_TOKEN_TIMEOUT,
+		.procname	= "swap_token_timeout",
+		.data		= &swap_token_default_timeout,
+		.maxlen		= sizeof(swap_token_default_timeout),
+		.mode		= 0644,
+		.proc_handler	= &proc_dointvec_jiffies,
+		.strategy	= &sysctl_jiffies,
+	},
 	{ .ctl_name = 0 }
 };
 
mm/thrash.c +3 -2
diff -uprN linux-2.6.9-rc3/mm/thrash.c linux-2.6.9-rc3-vm-thrashing-control-tuning/mm/thrash.c
@@ -20,6 +20,7 @@ struct mm_struct * swap_token_mm = &init
 
 #define SWAP_TOKEN_CHECK_INTERVAL (HZ * 2)
 #define SWAP_TOKEN_TIMEOUT (HZ * 300)
+unsigned long swap_token_default_timeout = SWAP_TOKEN_TIMEOUT;
 
 /*
  * Take the token away if the process had no page faults
@@ -75,10 +76,10 @@ void grab_swap_token(void)
 		if ((reason = should_release_swap_token(mm))) {
 			unsigned long eligible = jiffies;
 			if (reason == SWAP_TOKEN_TIMED_OUT) {
-				eligible += SWAP_TOKEN_TIMEOUT;
+				eligible += swap_token_default_timeout;
 			}
 			mm->swap_token_time = eligible;
-			swap_token_timeout = jiffies + SWAP_TOKEN_TIMEOUT;
+			swap_token_timeout = jiffies + swap_token_default_timeout;
 			swap_token_mm = current->mm;
 		}
 		spin_unlock(&swap_token_lock);
#3 lore raw
Quoted 2 lines · Hideo AOKI

[vm-thrashing-control-tuning.patch text/plain (3256 bytes)]

Please send an additional patch to update Documentation/filesystems/proc.txt and Documentation/sysctl/vm.txt

#4 lore raw
Quoted 4 lines · Andrew Morton
Quoted 1 line

[vm-thrashing-control-tuning.patch text/plain (3256 bytes)]

Please send an additional patch to update Documentation/filesystems/proc.txt and Documentation/sysctl/vm.txt

Certainly.

Attached patch is a short description for /proc/sys/vm/swap_token_timeout.

Best regards,

Hideo AOKI

Systems Development Laboratory, Hitachi, Ltd.

 filesystems/proc.txt |    8 ++++++++
 sysctl/vm.txt        |    2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)
Documentation/filesystems/proc.txt +8 -0
diff -uprN linux-2.6.9-rc3-vm-thrashing-control-tuning/Documentation/filesystems/proc.txt linux-2.6.9-rc3-vm-tuning-doc/Documentation/filesystems/proc.txt
@@ -1269,6 +1269,14 @@ block_dump
 block_dump enables block I/O debugging when set to a nonzero value. More
 information on block I/O debugging is in Documentation/laptop-mode.txt.
 
+swap_token_timeout
+------------------
+
+This file contains valid hold time of swap out protection token. The Linux
+VM has token based thrashing control mechanism and uses the token to prevent
+unnecessary page faults in thrashing situation. The unit of the value is
+second. The value would be useful to tune thrashing behavior.
+
 2.5 /proc/sys/dev - Device specific parameters
 ----------------------------------------------
 
Documentation/sysctl/vm.txt +1 -1
diff -uprN linux-2.6.9-rc3-vm-thrashing-control-tuning/Documentation/sysctl/vm.txt linux-2.6.9-rc3-vm-tuning-doc/Documentation/sysctl/vm.txt
@@ -31,7 +31,7 @@ Currently, these files are in /proc/sys/
 
 dirty_ratio, dirty_background_ratio, dirty_expire_centisecs,
 dirty_writeback_centisecs, vfs_cache_pressure, laptop_mode,
-block_dump:
+block_dump, swap_token_timeout:
 
 See Documentation/filesystems/proc.txt
 
#5 lore raw

Re: [PATCH 2.6] Documentation/filesystems/proc.txt

Quoted 8 lines · Hideo AOKI
Quoted 2 lines · Andrew Morton

Please send an additional patch to update Documentation/filesystems/proc.txt and Documentation/sysctl/vm.txt

Certainly.

Attached patch is a short description for /proc/sys/vm/swap_token_timeout.

By the way, in Documentation/filesystems/proc.txt, explanation of /proc/meminfo is described in section 1.3 (IDE devices in /proc/ide). I think that it should be described in section 1.2 (Kernel data).

Attached patch fixes it. This patch has to be applied after my previous patch is applied.

Kind regards,

Hideo AOKI

Systems Development Laboratory, Hitachi, Ltd.

 proc.txt |   31 ++++++++++++++++---------------
 1 files changed, 16 insertions(+), 15 deletions(-)
Documentation/filesystems/proc.txt +16 -16
diff -uprN linux-2.6.9-rc3-vm-tuning-doc/Documentation/filesystems/proc.txt linux-2.6.9-rc3-doc-fs-proc-fix/Documentation/filesystems/proc.txt
@@ -350,22 +350,6 @@ available.  In this case, there are 0 ch
 ZONE_DMA, 4 chunks of 2^1*PAGE_SIZE in ZONE_DMA, 101 chunks of 2^4*PAGE_SIZE 
 available in ZONE_NORMAL, etc... 
 
-
-1.3 IDE devices in /proc/ide
-----------------------------
-
-The subdirectory /proc/ide contains information about all IDE devices of which
-the kernel  is  aware.  There is one subdirectory for each IDE controller, the
-file drivers  and a link for each IDE device, pointing to the device directory
-in the controller specific subtree.
-
-The file  drivers  contains general information about the drivers used for the
-IDE devices:
-
-  > cat /proc/ide/drivers 
-  ide-cdrom version 4.53 
-  ide-disk version 1.08 
-
 ..............................................................................
 
 meminfo:
@@ -454,6 +438,22 @@ VmallocTotal: total size of vmalloc memo
  VmallocUsed: amount of vmalloc area which is used
 VmallocChunk: largest contigious block of vmalloc area which is free
 
+
+1.3 IDE devices in /proc/ide
+----------------------------
+
+The subdirectory /proc/ide contains information about all IDE devices of which
+the kernel  is  aware.  There is one subdirectory for each IDE controller, the
+file drivers  and a link for each IDE device, pointing to the device directory
+in the controller specific subtree.
+
+The file  drivers  contains general information about the drivers used for the
+IDE devices:
+
+  > cat /proc/ide/drivers 
+  ide-cdrom version 4.53 
+  ide-disk version 1.08 
+
 More detailed  information  can  be  found  in  the  controller  specific
 subdirectories. These  are  named  ide0,  ide1  and  so  on.  Each  of  these
 directories contains the files shown in table 1-4.
#6 lore raw
In reply to Hideo AOKI

Hi,

In include/linux/sysctl.h of 2.6.9-rc3-mm3, both VM_HEAP_STACK_GAP and VM_SWAP_TOKEN_TIMEOUT are 28. Maybe one of them should be 29?

linux/sysctl.h (local) renamed from linux/sysctl.h (revision 11) +0 -0
@@ -168,7 +168,7 @@
 	VM_VFS_CACHE_PRESSURE=26, /* dcache/icache reclaim pressure */
 	VM_LEGACY_VA_LAYOUT=27, /* legacy/compatibility virtual address space

layout */
VM_HEAP_STACK_GAP=28, /* int: page gap between heap and stack */
- VM_SWAP_TOKEN_TIMEOUT=28, /* default time for token time out */
+ VM_SWAP_TOKEN_TIMEOUT=29, /* default time for token time out */
};

Signature · 2 lines
Best Regards,
Wen-chien Jesse Sung
author
#7 lore raw
Quoted 4 lines · Wen-chien Jesse Sung

Hi,

In include/linux/sysctl.h of 2.6.9-rc3-mm3, both VM_HEAP_STACK_GAP and VM_SWAP_TOKEN_TIMEOUT are 28. Maybe one of them should be 29?

It doesn't really matter much anymore because the numerical sysctl values are deprecated. Everybody should use the names in /proc/sys instead. Hopefully they will eventually go away completely and avoid a lot of patch conflicts.

-Andi